unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Roel Janssen <roel@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/4] gnu: Add r-bigmemory-sri.
Date: Fri, 28 Oct 2016 22:44:54 +0200	[thread overview]
Message-ID: <87lgx8jja2.fsf@elephly.net> (raw)
In-Reply-To: <87a8dohd7q.fsf@gnu.org>


Roel Janssen <roel@gnu.org> writes:

> * gnu/packages/statistics.scm (r-bigmemory-sri): New variable.
> ---
>  gnu/packages/statistics.scm | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>
> diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
> index 9e2d4a9..a50e792 100644
> --- a/gnu/packages/statistics.scm
> +++ b/gnu/packages/statistics.scm
> @@ -2810,6 +2810,25 @@ via mutexes and may eventually support interprocess communication and
>  message passing.")
>      (license (list license:lgpl2.1 license:asl2.0))))
>  
> +(define-public r-bigmemory-sri
> +  (package
> +    (name "r-bigmemory-sri")
> +    (version "0.1.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (cran-uri "bigmemory.sri" version))

I think this should have a property to record the upstream name to help
the updater.

> +       (sha256
> +        (base32
> +         "0mg14ilwdkd64q2ri9jdwnk7mp55dqim7xfifrs65sdsv1934h2m"))))
> +    (build-system r-build-system)
> +    (home-page
> +     "http://cran.r-project.org/web/packages/bigmemory.sri")

Please pull them onto one line.

> +    (synopsis "A shared resource interface for the bigmemory
> package")

Don’t start with “A”.

> +    (description "This package provides a shared resource interface for the
> +bigmemory and synchronicity packages.")
> +    (license (list license:lgpl3 license:asl2.0))))

What does this list mean?
Also: is this LGPL3+ or LGPL3 only?

~~ Ricardo

  reply	other threads:[~2016-10-28 20:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-28 12:26 [PATCH 2/4] gnu: Add r-bigmemory-sri Roel Janssen
2016-10-28 20:44 ` Ricardo Wurmus [this message]
2016-10-31  9:18   ` Roel Janssen
2016-11-03 13:33     ` Roel Janssen
2016-11-03 14:19       ` Ricardo Wurmus
2016-11-03 14:36         ` Roel Janssen
2016-11-03 15:41           ` Ricardo Wurmus
2016-11-04 13:15             ` Roel Janssen
2016-11-04 13:21               ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lgx8jja2.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=guix-devel@gnu.org \
    --cc=roel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).