From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add radeontop.
Date: Fri, 28 Oct 2016 15:49:45 +0200
Message-ID: <87lgx8a8hy.fsf@gnu.org>
References: <20161027230749.23186-1-me@tobias.gr>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56351)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1c07Xc-0001Ha-6N
	for guix-devel@gnu.org; Fri, 28 Oct 2016 09:49:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1c07XX-0000km-Kk
	for guix-devel@gnu.org; Fri, 28 Oct 2016 09:49:52 -0400
In-Reply-To: <20161027230749.23186-1-me@tobias.gr> (Tobias Geerinckx-Rice's
	message of "Fri, 28 Oct 2016 01:07:49 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: guix-devel@gnu.org

Hi!

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> * gnu/packages/linux.scm (radeontop): New variable.

[...]

> I'm too ignorant of anything beyond x86 to know if supported-systems is
> needed or even makes sense here.

I=E2=80=99m guessing the program is not very useful on non-x86 machines=E2=
=80=A6 but it
may build fine anyway.

We can add =E2=80=98supported-systems=E2=80=99 later if/when we have eviden=
ce that it
doesn=E2=80=99t build on other arches.

> +(define-public radeontop
> +  (package
> +    (name "radeontop")
> +    (version "0.9")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://github.com/clbr/radeontop/arc=
hive/v"

You could move =E2=80=98home-page=E2=80=99 above =E2=80=98source=E2=80=99 a=
nd reference it here.

Otherwise LGTM, thanks!

> +    (license license:gpl3)))

It=E2=80=99s indeed v3-only, bah.

Ludo=E2=80=99.