From: ludo@gnu.org (Ludovic Courtès)
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add radeontop.
Date: Fri, 28 Oct 2016 15:49:45 +0200 [thread overview]
Message-ID: <87lgx8a8hy.fsf@gnu.org> (raw)
In-Reply-To: <20161027230749.23186-1-me@tobias.gr> (Tobias Geerinckx-Rice's message of "Fri, 28 Oct 2016 01:07:49 +0200")
Hi!
Tobias Geerinckx-Rice <me@tobias.gr> skribis:
> * gnu/packages/linux.scm (radeontop): New variable.
[...]
> I'm too ignorant of anything beyond x86 to know if supported-systems is
> needed or even makes sense here.
I’m guessing the program is not very useful on non-x86 machines… but it
may build fine anyway.
We can add ‘supported-systems’ later if/when we have evidence that it
doesn’t build on other arches.
> +(define-public radeontop
> + (package
> + (name "radeontop")
> + (version "0.9")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "https://github.com/clbr/radeontop/archive/v"
You could move ‘home-page’ above ‘source’ and reference it here.
Otherwise LGTM, thanks!
> + (license license:gpl3)))
It’s indeed v3-only, bah.
Ludo’.
next prev parent reply other threads:[~2016-10-28 13:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 23:07 [PATCH] gnu: Add radeontop Tobias Geerinckx-Rice
2016-10-28 13:49 ` Ludovic Courtès [this message]
2016-10-28 15:55 ` Tobias Geerinckx-Rice
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgx8a8hy.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).