From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH 3/3] gnu: nmap: Update to 7.31. Date: Tue, 01 Nov 2016 00:00:14 +0000 Message-ID: <87lgx4ul0x.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me> References: <20161031132944.2353-1-mbakke@fastmail.com> <20161031132944.2353-4-mbakke@fastmail.com> <20161031175347.GA27555@jasmine> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44329) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1MV3-0003hP-Aq for guix-devel@gnu.org; Mon, 31 Oct 2016 20:00:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1MUy-0003hW-Us for guix-devel@gnu.org; Mon, 31 Oct 2016 20:00:21 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:36344) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c1MUy-0003hL-RO for guix-devel@gnu.org; Mon, 31 Oct 2016 20:00:16 -0400 In-Reply-To: <20161031175347.GA27555@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Famulari writes: > On Mon, Oct 31, 2016 at 01:29:44PM +0000, Marius Bakke wrote: >> * gnu/packages/admin.scm (nmap): Update to 7.31. >> [arguments]: Add phase 'patch-Makefile' to prevent lua from being built. >> --- >> gnu/packages/admin.scm | 10 ++++++++-- >> 1 file changed, 8 insertions(+), 2 deletions(-) >>=20 >> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm >> index d9b08ef..35156f6 100644 >> --- a/gnu/packages/admin.scm >> +++ b/gnu/packages/admin.scm >> @@ -1570,14 +1570,14 @@ done with the @code{auditctl} utility.") >> (define-public nmap >> (package >> (name "nmap") >> - (version "7.12") >> + (version "7.31") >> (source (origin >> (method url-fetch) >> (uri (string-append "https://nmap.org/dist/nmap-" version >> ".tar.bz2")) >> (sha256 >> (base32 >> - "014vagh9ak10hidwzp9s6g30y5h5fhsh8wykcnc1hnn9hwm0ipv3")) >> + "0hiqb28950kn4bjsmw0ksfyss7j2qdmgrj3xsjf7073pq01lx7yb")) > > Okay! > >> (modules '((guix build utils))) >> (snippet >> '(map delete-file-recursively >> @@ -1603,6 +1603,12 @@ done with the @code{auditctl} utility.") >> '(#:configure-flags '("--without-zenmap") >> #:phases >> (modify-phases %standard-phases >> + (add-after 'configure 'patch-Makefile >> + (lambda _ >> + (substitute* "Makefile" >> + ;; Do not attempt to build lua. >> + (("build-dnet build-lua") "build-dnet")) >> + #t)) > > So, in this new release it tries to build the bundled Lua and fails > because we've deleted it? Correct, "build-lua" is now part of the default make target. Don't know how it worked before, there have been a few changes to the Makefile: https://github.com/nmap/nmap/commits/master/Makefile.in Reading through the commits, I will double check that the NSE stuff still works with our Lua ;) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCgAGBQJYF9sOAAoJEKKgbfKjOlT6GdkH/jJreQz+o/AvrXOv7iSpcCcO JdqqahDYIxohsxfI86mx5gEb/upk99Saotnw0vb0bzJaGjR73rowXkI6QRrDkwrc ycIouCJlXmDJZHFGpDYUr7nZ78aPQRqeXUxCms0W1LQL6RgXyp/F3hHZCfGSJIzU l4RC/qoQJ0m6QvRU/SDDDpWuHLmwaj58zhhyz4lRR3vVI6fMNHHE0hQfFDogKO/C akAjPRkRpP8rCkaFLew8si//uUt8njqGxH43aPVIlbz7ISGGzW0mFG4vgdpacJmK +vxjAeyiWHONk+XKcPfMzzA+uuYaAy94loz0HsEwmu/yAaSHqvkrOjec7t8uogY= =Doyu -----END PGP SIGNATURE----- --=-=-=--