From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [Patch v2 3/3] gnu: Add pdfposter.
Date: Thu, 10 Nov 2016 11:48:46 +0100
Message-ID: <87lgwrtxtd.fsf@gnu.org>
References: <1478641022-30723-1-git-send-email-h.goebel@crazy-compilers.com>
	<1478731153-27023-1-git-send-email-h.goebel@crazy-compilers.com>
	<1478731153-27023-3-git-send-email-h.goebel@crazy-compilers.com>
	<20161110075128.GF2348@macbook42.flashner.co.il>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34854)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1c4muc-0005Gn-1t
	for guix-devel@gnu.org; Thu, 10 Nov 2016 05:48:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1c4muX-00019z-MF
	for guix-devel@gnu.org; Thu, 10 Nov 2016 05:48:53 -0500
In-Reply-To: <20161110075128.GF2348@macbook42.flashner.co.il> (Efraim
	Flashner's message of "Thu, 10 Nov 2016 09:51:28 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org

Efraim Flashner <efraim@flashner.co.il> skribis:

> On Wed, Nov 09, 2016 at 11:39:13PM +0100, Hartmut Goebel wrote:
>> * gnu/packages/pdf.scm(pdfposter): New variable.
                         ^
Space.  :-)

[...]

>> +    (arguments
>> +     `(#:tests? #f  ; no test suite, only for visula control
>                                                 ^^^^^^^
>                                             typo

[...]

>> +PDF.  Since sometimes @command{poster} does not like your files convert=
ed from
>> +PDF. :-) Indeed @command{pdfposter} was inspired by @command{poster}.")
>         ^^^^
> I would leave this out

I agree with Efraim.

LGTM with these changes.

Thanks!

Ludo=E2=80=99.