From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: [PATCH] gnu: Fix load-extension path in packaging of
	guile-ncurses.
Date: Tue, 20 Dec 2016 02:17:42 -0500
Message-ID: <87lgvb9ii1.fsf@netris.org>
References: <1482169820-2043-1-git-send-email-jmd@gnu.org>
	<1482169820-2043-2-git-send-email-jmd@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43048)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1cJEgQ-00072r-TK
	for guix-devel@gnu.org; Tue, 20 Dec 2016 02:17:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1cJEgL-0005yN-Uc
	for guix-devel@gnu.org; Tue, 20 Dec 2016 02:17:58 -0500
In-Reply-To: <1482169820-2043-2-git-send-email-jmd@gnu.org> (John Darrington's
	message of "Mon, 19 Dec 2016 18:50:20 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org

Hi John,

John Darrington <jmd@gnu.org> writes:
> * gnu/packages/guile.scm (guile-ncurses) [arguments]: Install shared object before
> attempting to build the package.  Patch load-extension path before building instead
> of after.

The first sentence above is mistaken or misleading:

  "Install shared object before attempting to build the package."

Of course this is not possible, and it's not what happens after applying
this commit.

> +         (add-before 'build 'fix-libguile-ncurses-file-name
>             (lambda* (#:key outputs #:allow-other-keys)
> - [...]
> +             (and (zero? (system* "make" "install"
> +                                  "-C" "src/ncurses"
> +                                  "-j" (number->string
> +                                        (parallel-job-count))))
> +                  (let* ((out   (assoc-ref outputs "out"))
> +                         (dir   "src/ncurses")
> +                         (files (find-files dir ".scm")))
> +                    (substitute* files
> +                      (("\"libguile-ncurses\"")
> +                       (format #f "\"~a/lib/guile/2.0/libguile-ncurses\""
> +                               out)))
> +                    #t)))))))

By running "make install -C src/ncurses [...]", you are in fact causing
most if not all of the package to be built and installed right here in
the 'fix-libguile-ncurses-file-name' phase.  This is no good.

Can you help me understand what you're trying to do here, and why?

     Thanks,
       Mark