From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH] gnu: Add python-hdf4. Date: Fri, 23 Dec 2016 15:21:05 +0100 Message-ID: <87lgv6afqm.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <20161222.112321.737083559510333929.thomas.danckaert@gmail.com> <87tw9vao24.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <20161223.080120.818405214972923128.post@thomasdanckaert.be> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKQib-0001hl-EM for guix-devel@gnu.org; Fri, 23 Dec 2016 09:21:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cKQia-0006hT-9H for guix-devel@gnu.org; Fri, 23 Dec 2016 09:21:09 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:44157) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cKQia-0006g6-6A for guix-devel@gnu.org; Fri, 23 Dec 2016 09:21:08 -0500 In-Reply-To: <20161223.080120.818405214972923128.post@thomasdanckaert.be> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Thomas Danckaert Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Thomas Danckaert writes: > From: Marius Bakke > Subject: Re: [PATCH] gnu: Add python-hdf4. > Date: Thu, 22 Dec 2016 18:09:07 +0100 > >> Thomas Danckaert writes: >> >>> Hi Guix, >>> >>> this patch adds python-hdf4. I'm not sure if the line =E2=80=9CPython-= HDF4 >>> is a fork of pyhdf.=E2=80=9D in the description is necessary. The orig= inal >>> and =E2=80=9Cofficial=E2=80=9D pyhdf (http://hdfeos.org/software/pyhdf.= php) is >>> somewhat outdated (e.g. doesn't support python3). >> >> The "official" pyhdf and this fork was released around the same=20 >> time and >> have the same version number. Confusing! But I'll take your word=20 >> that >> this one is better. > > Yes, it seems it mirrors updates in the =E2=80=9Cofficial=E2=80=9D one, a= nd keeps the=20 > same version numbers. Thanks for clarifying. > >> Regarding the patch, I wonder if it should go in (gnu packages=20 >> maths), >> similar to how we put PDF libraries in pdf.scm and XML in xml.scm=20 >> etc. >> But no strong opinion here. > > I've wondered the same. Right now, h5py, which is a similar package=20 > for HDF5, is also in python.scm, so I decided to add this package=20 > next to it. As an aside, I find many packages in maths.scm are not=20 > really =E2=80=9Cmathy=E2=80=9D (=E2=80=9Cscience=E2=80=9D maybe), but any= way :-) OK! :) >> The 'check' phase seems to run the build again, and prints at the=20 >> end >> "Ran 0 tests in 0.000s". Looking at the Github ".travis.yml", the CI >> tool runs the command "nosetests" instead of 'python setup.py test'=20 >> like >> python-build-system does by default. Can you try replacing the=20 >> 'check' >> phase with that command? You'll need 'python-nose' as a=20 >> native-input. > > I hadn't noticed that. This patch adds nosetests, but that just=20 > prints =E2=80=9CRan 0 tests in .005s=E2=80=9D, so it seems there are no t= ests. Shall=20 > we just delete the 'check' phase? Ha, it seems the one nosetest was added after the 0.9 release. But I missed another script from the ".travis.yml" which runs through some example scripts. I added that as well, and kept nose so that it "just works" when this package is updated. Applied! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlhdMtEACgkQoqBt8qM6 VPphtggA1SGB+IF/vB9WoI9RSmYRFCtbgiEoHRyJKc6LRmtVtXe/OGxDQslJuVNo VkmIP5cCtLC00pyEKdXmek+M5DPVN98e7Jb7M5+i+dfcQzR9o4KekgQZcqI0gkjj Deto0sBlQoNMRmX9tLP2pwW8t7dlp/PW+WWjLuVqtZEd/rC4SpfjaCM1PkGR8G11 ixtSBeCAqOPbTwV1ZomHzP0DyK3V09CKYs/mlsajdrQ8c+eilaDeo599AUa5A8hK HHx0kVoP9IGA7MbW8O+fiGYdopa3QL7HBpN8zw/Vtdfaq7mywZUT4jekKGa9eRA2 tV9B8fajS5RZszfyMt4Op3A+AogwcQ== =x5eO -----END PGP SIGNATURE----- --=-=-=--