From: ludo@gnu.org (Ludovic Courtès)
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH core-updates 6/6] utils: Add helper method to make files writable.
Date: Thu, 26 Jan 2017 10:50:50 +0100 [thread overview]
Message-ID: <87lgty5ev9.fsf@gnu.org> (raw)
In-Reply-To: <20170125171938.27271-7-mbakke@fastmail.com> (Marius Bakke's message of "Wed, 25 Jan 2017 18:19:38 +0100")
Marius Bakke <mbakke@fastmail.com> skribis:
> * gnu/build/activation.scm (make-file-writable): Move this to ...
> * guix/build/utils.scm (make-file-writable): ... here. Export it.
> * guix/build/gnu-build-system.scm (strip): Use it.
[...]
> --- a/guix/build/gnu-build-system.scm
> +++ b/guix/build/gnu-build-system.scm
> @@ -393,8 +393,10 @@ makefiles."
> (or (elf-file? file) (ar-file? file))
> (or (not debug-output)
> (make-debug-file file))
> - ;; Ensure libraries are writable.
> - (chmod file #o755)
> +
> + ;; Ensure the file is writable.
> + (make-file-writable file)
The return value of ‘chmod’ and ‘make-file-writable’ is unspecified, so
you need to write:
(begin (make-file-writable file) #t)
> +(define (make-file-writable file)
> + "Make FILE writable for its owner.."
^
Take it as an opportunity to remove this extra period. :-)
Otherwise LGTM.
Ludo’.
next prev parent reply other threads:[~2017-01-26 9:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 17:19 [PATCH core-updates 0/6] Wait up! Marius Bakke
2017-01-25 17:19 ` [PATCH core-updates 1/6] gnu: Add libxfont2 Marius Bakke
2017-01-25 17:19 ` [PATCH core-updates 2/6] gnu: xorg-server: Use 'modify-phases' syntax Marius Bakke
2017-01-25 17:19 ` [PATCH core-updates 3/6] gnu: xorg-server: Update to 1.19.1 Marius Bakke
2017-01-25 17:19 ` [PATCH core-updates 4/6] gnu: xf86-video-qxl: Change to libxfont2 ABI Marius Bakke
2017-01-25 17:19 ` [PATCH core-updates 5/6] gnu: xf86-video-intel: Update to 2.99.917-2-028c946 Marius Bakke
2017-01-25 17:19 ` [PATCH core-updates 6/6] utils: Add helper method to make files writable Marius Bakke
2017-01-26 9:50 ` Ludovic Courtès [this message]
2017-01-26 21:21 ` Marius Bakke
2017-01-25 19:05 ` [PATCH core-updates 0/6] Wait up! Leo Famulari
2017-01-26 16:27 ` Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgty5ev9.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).