From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxim Cournoyer Subject: Re: [PATCH 6/7] gnu: Add python-ruamel.yaml. Date: Wed, 01 Feb 2017 20:42:52 -0800 Message-ID: <87lgtp9p9v.fsf@gmail.com> References: <20160925173931.GD9499@jasmine> <20170131125339.18500-1-contact.ng0@cryptolab.net> <20170131125339.18500-7-contact.ng0@cryptolab.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZ9Ea-00083t-Sf for guix-devel@gnu.org; Wed, 01 Feb 2017 23:43:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZ9EZ-0003sv-TQ for guix-devel@gnu.org; Wed, 01 Feb 2017 23:43:00 -0500 Received: from mail-pg0-x243.google.com ([2607:f8b0:400e:c05::243]:34160) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cZ9EZ-0003sa-OK for guix-devel@gnu.org; Wed, 01 Feb 2017 23:42:59 -0500 Received: by mail-pg0-x243.google.com with SMTP id 3so654828pgj.1 for ; Wed, 01 Feb 2017 20:42:59 -0800 (PST) In-Reply-To: <20170131125339.18500-7-contact.ng0@cryptolab.net> (contact's message of "Tue, 31 Jan 2017 12:53:38 +0000") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: contact.ng0@cryptolab.net Cc: guix-devel@gnu.org, ng0 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi ng0! I've looked at this patch series and it looks good so far, except for the two inline comments I added below. contact.ng0@cryptolab.net writes: > From: ng0 > > * gnu/packages/python.scm (python-ruamel.yaml): New variable. > --- > gnu/packages/python.scm | 35 +++++++++++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm > index 285207543..583f57b6f 100644 > --- a/gnu/packages/python.scm > +++ b/gnu/packages/python.scm > @@ -2845,6 +2845,41 @@ object.") > (define-public python2-pyyaml > (package-with-python2 python-pyyaml)) >=20=20 > +(define-public python-ruamel.yaml > + (package > + (name "python-ruamel.yaml") > + (version "0.12.14") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "ruamel.yaml" version)) > + (sha256 > + (base32 > + "1w23nqswsq083xc0qpkw764n1a4v5g9p4fz1jkp6xbrzr9mrkqp7")))) > + (build-system python-build-system) > + (arguments > + `(;; Otherwise it complains that you have to do "pypi install ." > + #:configure-flags (list "--single-version-externally-managed" Have you tried removing this "--single-version-externally-managed" flag when using the latest Python build system? I believe it is always used now. See commit 7db40bce58. > + "--record=3Druamel.yaml.txt"))) > + (inputs > + `(("python-typing" ,python-typing))) > + (home-page "https://bitbucket.org/ruamel/yaml") > + (synopsis "YAML 1.2 loader/dumper package for Python") > + (description > + "@code{ruamel.yaml} is a YAML 1.2 parser/emitter that supports roun= dtrip > +preservation of comments, seq/map flow style, and map key order.") > + (license license:expat))) > + > +(define-public python2-ruamel.yaml > + (package (inherit (package-with-python2 > + (strip-python2-variant python-ruamel.yaml))) > + (name "python2-ruamel.yaml") > + (inputs > + `(("python2-ruamel.ordereddict" ,python2-ruamel.ordereddict) > + ("python2-typing" ,python2-typing))) > + (native-inputs > + `(("python2-setuptools" ,python2-setuptools))))) Is this really required? Setuptools now comes with our python packages, this was also introduced by Hartmut as part of the new Python build system. Maxim --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEJ9WGpPiQCFQyn/CfEmDkZILmNWIFAliSuMwACgkQEmDkZILm NWLG9Q/7B/wa6451tBk7//M334fZj5e/wyCs9t1khZjI4R/zlo+YxvE0SyHjsL2Y yqI+0FveqtwgKvmFPRr211f9xE6KUxvFD5eLcasKQI93zuXl3j2GW49bV9IIvHoW h4pk9DlFbPl5m9aGU4azeZiPOS6fEFrtQl4M/wXNIstAfRmAI7sGzQtoGvRZyp3A WLL6UhuczcKmwaUoP25hQ/wAvPaV1LeUeBQ9M+O5N9h1h/1tjQEhrEA/vYb4dad6 AVcOeNRQPJ7jpF+K5MsTRUiAlCB07IkWmUWrcTpiVKUmGSOrOwDjLpWg42A9MLBS MXRTVcIDryFUjFk8swQKO2t2ROI8Wk8RjW7tqpQSciro5jcejbIFQqcOHGP8oZGo Hwg7UWWFcYc47Tn+DvT6yqNaXDrqjPnBlgBaOKjGe6dPc0AJBQ4AbfuXylbqpLOI ln9/ttF0uE1fT5jBOkqAg8ihSX3H1DSKKdQSO6wbjrMtz/XvE+fRU3fVxYwBaMRo 5WDeZrvLj0YB9ZamfHbgB+bGmjOnooiEziL5Srn5X32urFip0l6Zaj/IpI9+Kc5a qRG2MzAtK2q7KFRbW/kz3le8oF5vRv7jIXczy/ClIHDyP70yESy+PwwgmOqyNZfh uGuwBCtdLJb0k+e3/z3IK/Elzgwayv22Ypb8MvGwcsk8EfBbFeg= =Kros -----END PGP SIGNATURE----- --=-=-=--