From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: contact.ng0@cryptolab.net
Cc: guix-devel@gnu.org, ng0 <ngillmann@runbox.com>
Subject: Re: [PATCH 6/7] gnu: Add python-ruamel.yaml.
Date: Wed, 01 Feb 2017 20:42:52 -0800 [thread overview]
Message-ID: <87lgtp9p9v.fsf@gmail.com> (raw)
In-Reply-To: <20170131125339.18500-7-contact.ng0@cryptolab.net> (contact's message of "Tue, 31 Jan 2017 12:53:38 +0000")
[-- Attachment #1: Type: text/plain, Size: 2425 bytes --]
Hi ng0!
I've looked at this patch series and it looks good so far, except for
the two inline comments I added below.
contact.ng0@cryptolab.net writes:
> From: ng0 <ngillmann@runbox.com>
>
> * gnu/packages/python.scm (python-ruamel.yaml): New variable.
> ---
> gnu/packages/python.scm | 35 +++++++++++++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 285207543..583f57b6f 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -2845,6 +2845,41 @@ object.")
> (define-public python2-pyyaml
> (package-with-python2 python-pyyaml))
>
> +(define-public python-ruamel.yaml
> + (package
> + (name "python-ruamel.yaml")
> + (version "0.12.14")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (pypi-uri "ruamel.yaml" version))
> + (sha256
> + (base32
> + "1w23nqswsq083xc0qpkw764n1a4v5g9p4fz1jkp6xbrzr9mrkqp7"))))
> + (build-system python-build-system)
> + (arguments
> + `(;; Otherwise it complains that you have to do "pypi install ."
> + #:configure-flags (list "--single-version-externally-managed"
Have you tried removing this "--single-version-externally-managed" flag
when using the latest Python build system? I believe it is always used
now. See commit 7db40bce58.
> + "--record=ruamel.yaml.txt")))
> + (inputs
> + `(("python-typing" ,python-typing)))
> + (home-page "https://bitbucket.org/ruamel/yaml")
> + (synopsis "YAML 1.2 loader/dumper package for Python")
> + (description
> + "@code{ruamel.yaml} is a YAML 1.2 parser/emitter that supports roundtrip
> +preservation of comments, seq/map flow style, and map key order.")
> + (license license:expat)))
> +
> +(define-public python2-ruamel.yaml
> + (package (inherit (package-with-python2
> + (strip-python2-variant python-ruamel.yaml)))
> + (name "python2-ruamel.yaml")
> + (inputs
> + `(("python2-ruamel.ordereddict" ,python2-ruamel.ordereddict)
> + ("python2-typing" ,python2-typing)))
> + (native-inputs
> + `(("python2-setuptools" ,python2-setuptools)))))
Is this really required? Setuptools now comes with our python packages,
this was also introduced by Hartmut as part of the new Python build
system.
Maxim
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-02-02 4:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 12:13 Addition to tinycm patch-series (corrects patch 8) ng0
2016-09-25 17:39 ` Leo Famulari
2017-01-31 12:53 ` tinycm contact.ng0
2017-01-31 12:53 ` [PATCH 1/7] gnu: Add python-boolexp contact.ng0
2017-01-31 12:53 ` [PATCH 2/7] gnu: Add python-colorlog contact.ng0
2017-01-31 12:53 ` [PATCH 3/7] gnu: Add python2-ruamel.ordereddict contact.ng0
2017-02-02 4:53 ` Maxim Cournoyer
2017-02-02 10:13 ` ng0
2017-02-02 10:46 ` Hartmut Goebel
2017-02-02 14:03 ` Tobias Geerinckx-Rice
2017-02-05 9:11 ` Maxim Cournoyer
2017-01-31 12:53 ` [PATCH 4/7] gnu: Add python-distro contact.ng0
2017-01-31 12:53 ` [PATCH 5/7] gnu: Add python-typing contact.ng0
2017-01-31 12:53 ` [PATCH 6/7] gnu: Add python-ruamel.yaml contact.ng0
2017-02-02 4:42 ` Maxim Cournoyer [this message]
2017-02-02 10:49 ` Hartmut Goebel
2017-01-31 12:53 ` [PATCH 7/7] gnu: Add tinycm contact.ng0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgtp9p9v.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=contact.ng0@cryptolab.net \
--cc=guix-devel@gnu.org \
--cc=ngillmann@runbox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).