From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id wJF0B2EryGIVOgEAbAwnHQ (envelope-from ) for ; Fri, 08 Jul 2022 15:04:33 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id MMCFB2EryGI6BgEAauVa8A (envelope-from ) for ; Fri, 08 Jul 2022 15:04:33 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CF7533C73F for ; Fri, 8 Jul 2022 15:04:32 +0200 (CEST) Received: from localhost ([::1]:52064 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9nep-00074v-Hf for larch@yhetil.org; Fri, 08 Jul 2022 09:04:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55726) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9nWz-0001Vj-GD for guix-devel@gnu.org; Fri, 08 Jul 2022 08:56:25 -0400 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:38699) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o9nWh-0002hV-58; Fri, 08 Jul 2022 08:56:25 -0400 Received: by mail-wr1-x429.google.com with SMTP id v14so30449944wra.5; Fri, 08 Jul 2022 05:56:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=OngYIDBIJ0jlPDwzM2OTt0YKdbRu+J2afGjmtIKTMB4=; b=duabxh1aZiAcGMB+oBGo4vO/obm9tRjEa9bhraJ0hkx3IzZKTozyNRESY/0x2U6wsU b6EdwvwiEkTtf/m1iq12/w8HpHrmOYw/2fOA9CxhyUYHBLzpEIObaoNc8mbWqXIvz7Xb nM1NSi7MBYSQ7YR6MDj7kxlwqJhnhRHW4mtv0/qaXyD7c94yCRi+/p8ZwTAHlkTId8K0 IbLwpKRwlYWhQbOrnOfJ4YEZ4Of+++sz21tFfkOUKvqKDo6IdIvc9Xq309kaQ7qtqOWf Y86EMVGEW7/ZqsF8fW0qJtQ2YeR7PsYRmXJZl4P4FmYjPGiKfwAGZNDzkE/ODf+jamG8 1e1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=OngYIDBIJ0jlPDwzM2OTt0YKdbRu+J2afGjmtIKTMB4=; b=Ux2J5wETMliYLm80xXyjqKupXAU3nDbMeY2PzidYhSWQOXveUquHVQaoXRDOQFn7+g 2hPCW1eEEWZ5zePLqHEvz9ei/iAkRTySwecLuUAeTBqRt3MWoCJXJBOy5x1JYcUNbO7p g2928JDQyIBVNiVT9MLpONt0W9+k4NU6j1PuVITm74VEnC4ZvucrV8VVXNuca14J5JBm smQ7p081cZinIF0zP3U7FgJqX6faGOercgWsvIFtzlu5qReJeZNNSvVaCsCWnc73MSGG W0jr82WoMz3XnN8j+sQjLZKIYe2YskRTzpvAcvc5Ae/1ieQfgVfmGR+gclsj10l9n+y0 8cHw== X-Gm-Message-State: AJIora+9R3HJg0ssU8nnOIJR69036fgu22ZkU3U3jCU/H2LDZS8XFlUu 4A8Kncs7+gQGDdAYAlEeITFB4EtwmMs= X-Google-Smtp-Source: AGRyM1tZuAdmJNUSrMGSDakf/XmhW2ATx2KQVOsRTQvIXCIjdvMPMbHDzCWpyZrGRWzpX9zUYRLJng== X-Received: by 2002:a05:6000:609:b0:21d:92ad:562 with SMTP id bn9-20020a056000060900b0021d92ad0562mr1309372wrb.369.1657284964360; Fri, 08 Jul 2022 05:56:04 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id t9-20020adfeb89000000b0021d887f9468sm3682367wrn.25.2022.07.08.05.56.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jul 2022 05:56:03 -0700 (PDT) From: zimoun To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: Hartmut Goebel , guix-devel Subject: Re: Shall updaters fall back to other updaters? In-Reply-To: <87o7y22un8.fsf@gnu.org> References: <71902b16-4c29-c2f3-c99b-c103f3f6647c@crazy-compilers.com> <86tu7xyo0p.fsf@gmail.com> <87o7y22un8.fsf@gnu.org> Date: Wed, 06 Jul 2022 18:24:41 +0200 Message-ID: <87let6b452.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=zimon.toutoune@gmail.com; helo=mail-wr1-x429.google.com X-Spam_score_int: -7 X-Spam_score: -0.8 X-Spam_bar: / X-Spam_report: (-0.8 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_24_48=1.34, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1657285472; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=OngYIDBIJ0jlPDwzM2OTt0YKdbRu+J2afGjmtIKTMB4=; b=kg7qYf9PdqrYcfhgFu3lKGrOifkmKFyh/egjaZAhSlTFMRxjxsh2NVR6arChkG3Jq1/ar8 5ibUQkdG6HDnYiiuPtbMDQPwxNTkf+1kSOxMsPclf9R3KmI6ECDTX7CyrzFzhVJrxGTWG9 V8CJUoAsUDhEvOS2fUyPB5qsRbjo/5Dhyr3ddrsfpFz6mCC5V4H0DFMnKhNj1OJoK2hKMF YAotY6A4TWCn6Buabz2YxASeDbBw3DcVbh7vP9I+XtUKQsipD2tJzwKsG8UWwKLOvMfK/x 9VKA8fAZPfgq1tbkJZexo9Qot0sSmTXLY+lh8ggLakSDKKMWlaTZLBkkd75g4g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1657285472; a=rsa-sha256; cv=none; b=R7E0QooSxHYRkzQrn3l9mfwFQWpglCjeG4YCrlt+0UCQj/gopOtt0fdeNadUFhyICkrB6f Bk/Hku1n11TOpONfSMU8Wc9PqO3F8VSJ7L51J22jV/uldFiyjyiHLkRRG++1enboB5Qi+5 tl7dcfHKXutQFi5t6y2pJAP03+VfxwHqRKyKB4flsXu0wrPa20ff8iJbivWKyjZ65e/uDN ykVRYtkjbZHpkfH15r6YziF/vD+eAyHEWwCQaxoAMKxGq3TjzY//YnW9nr+DxCwIsvlo6B 2wMOfYOx2UVp1y0vQGNh2MlyWBNSZLsR551G7pxRA6JaN6aBfClsgY+YH28cKg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=duabxh1a; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.95 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=duabxh1a; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: CF7533C73F X-Spam-Score: -1.95 X-Migadu-Scanner: scn0.migadu.com X-TUID: I2jeqzgB+Y0D Hi, On mer., 06 juil. 2022 at 16:16, Ludovic Court=C3=A8s wrote: > Nope! =E2=80=98all-modules=E2=80=99 *is* deterministic because it builds= upon > =E2=80=98scheme-files=E2=80=99, which is deterministic and documented as = such. Oh indeed! My bad, I have overlooked that =E2=80=99scheme-files=E2=80=99 u= ses =E2=80=99scandir*=E2=80=99 instead of Guile scandir; and this scandir* defi= ned in (guix syscall) sorts the result. >> Maybe sorting =E2=80=99%updaters=E2=80=99 would be enough; something lik= e, >> >> (define %updaters >> ;; The list of publically-known updaters. >> (delay (sort (fold-module-public-variables (lambda (obj result) > > Whether =E2=80=98fold-module-public-variables=E2=80=99 is deterministic d= epends on > whether =E2=80=98module-map=E2=80=99 is deterministic, which in turn depe= nds on > =E2=80=98hash-map->list=E2=80=99, which is not deterministic AFAICS. > > So what we could do is replace uses of =E2=80=98module-map=E2=80=99 with = a variant that > sorts variables. > > That said, the only case where it can influence updater order is when > several of them are defined in the same module. Indeed, and that=E2=80=99s the case, no? From [1]: bioconductor cran=20 savannah generic-html gnu-ftp sourceforge xorg kernel.org gnu cran bioconductor kernel.org sourceforge gnu generic-html gnu-ftp xorg savannah =20=20=20=20=20=20=20 bioconductor cran sourceforge generic-html gnu-ftp savannah xorg kernel.org gnu we see that the updaters are file-sorted (removed here) and only they appear unsorted when defined in the same module (underlined here). Well, I count 5 calls to =E2=80=99module-map=E2=80=99. Do you mean replace= all of them by =E2=80=99module-map*=E2=80=99 which guarantees a stable order? Or only = =E2=80=99module-map=E2=80=99 defined in =E2=80=99fold-module-public-variables=E2=80=99 and =E2=80=99fold-module-public-variables*=E2=80=99? 1: Cheers, simon