From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 0OhODIKJvmXkIgEA62LTzQ:P1 (envelope-from ) for ; Sat, 03 Feb 2024 19:44:18 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id 0OhODIKJvmXkIgEA62LTzQ (envelope-from ) for ; Sat, 03 Feb 2024 19:44:18 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1706985858; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=Mj7/A8yS9PkR7QCauPxSNtzDaxA+cCpX1FipmEntE08=; b=BS1/n06e6emS7LwCALKnnrUoBoCC+nTEk4AxSk5D738aYKERrP2bLX/7DmyAckmaVtHEzD VPXagFC6ZMP8gzRbIDGKYu/QPNcdPALt+HeSHyWdw1WTwhdpY2+RyBYteltg2PVeiaJnw8 7YkOCsd1C1hwrjj8OSQxorYWK2gvRGpsW3b0F9qXnwCJeyW/nomnDDjjHBnia/CQcTb2vu vmjKbDDsFSLGhy7/cU+/5fNpgF3FxFHAANl+oKgk67uXzKHudD9m1LbLGw4PIpfjaiypyp 0352vz0+O+pwecrgZkMiUIeI50pt7nGeTvZGrzEVk+X8zUWMLyRHLv5FoDSSfw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1706985858; a=rsa-sha256; cv=none; b=lReO6oRQSkX0tmH7L6KfiVoPF8L2EkIqa45ImBLyTs3Pd7VPWueJ7qOAg72gP9Qu3JjZOm rzys8gebwKcTLRnKT4+NceP9VWRGC3C6dQTekArOVlGswoM41CQCz6mJ7caO0naaopYOHX ZaMdaY1ZtZYPBXqfi4qyHDOIsOPXdTEcpnGb9yhhlQHccC7nYJGMgyjpElbURAsXKKVoHA r869HFhBIaXM4wrozWRMN8ZK8iumIqPwZYSK/b0h7JVPrUnIgmmaDRCWaMaVIhLPQFQxry 6sd1cwyHAgnv+AoGDNxxg7lcegWzoOMxP2qhTp8aFgZBoEJfGll5nwGGnsEtIw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E45AA128F1 for ; Sat, 3 Feb 2024 19:44:17 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rWKza-0003Pd-Qt; Sat, 03 Feb 2024 13:43:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rWKzX-0003PF-Ru for bug-guix@gnu.org; Sat, 03 Feb 2024 13:43:52 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rWKzX-00037D-Hq for bug-guix@gnu.org; Sat, 03 Feb 2024 13:43:51 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rWKzi-0002Z1-JA for bug-guix@gnu.org; Sat, 03 Feb 2024 13:44:02 -0500 Subject: bug#63775: git describe on current master says: v1.3.0-38775-g6192acf8b7 Resent-From: Giovanni Biscuolo Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Sat, 03 Feb 2024 18:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 63775 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Jonathan Brielmaier , 63775-close@debbugs.gnu.org Cc: guix-devel@gnu.org, Simon Tournier Mail-Followup-To: 63775@debbugs.gnu.org, g@xelera.eu, janneke@gnu.org Received: via spool by 63775-done@debbugs.gnu.org id=D63775.17069858279818 (code D ref 63775); Sat, 03 Feb 2024 18:44:02 +0000 Received: (at 63775-close) by debbugs.gnu.org; 3 Feb 2024 18:43:47 +0000 Received: from localhost ([127.0.0.1]:47066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rWKzT-0002YH-9V for submit@debbugs.gnu.org; Sat, 03 Feb 2024 13:43:47 -0500 Received: from ns13.heimat.it ([46.4.214.66]:56064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rWKzR-0002Y1-7n for 63775-close@debbugs.gnu.org; Sat, 03 Feb 2024 13:43:46 -0500 Received: from localhost (ip6-localhost [127.0.0.1]) by ns13.heimat.it (Postfix) with ESMTP id DD59B30081A; Sat, 3 Feb 2024 18:43:27 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at ns13.heimat.it Received: from ns13.heimat.it ([127.0.0.1]) by localhost (ns13.heimat.it [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vCAi5B3hVh0T; Sat, 3 Feb 2024 18:43:25 +0000 (UTC) Received: from bourrache.mug.xelera.it (unknown [93.56.171.217]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ns13.heimat.it (Postfix) with ESMTPSA id 189F53007E0; Sat, 3 Feb 2024 18:43:25 +0000 (UTC) Received: from roquette.mug.biscuolo.net (roquette [10.38.2.14]) by bourrache.mug.xelera.it (Postfix) with SMTP id AAAD92E27450; Sat, 3 Feb 2024 19:43:24 +0100 (CET) Received: (nullmailer pid 18874 invoked by uid 1000); Sat, 03 Feb 2024 18:43:24 -0000 From: Giovanni Biscuolo In-Reply-To: Organization: Xelera.eu References: <87pm6k5vwn.fsf@gnu.org> Date: Sat, 03 Feb 2024 19:43:14 +0100 Message-ID: <87le81bd8d.fsf@xelera.eu> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -7.27 X-Spam-Score: -7.27 X-Migadu-Queue-Id: E45AA128F1 X-Migadu-Scanner: mx12.migadu.com X-TUID: edHpO4MuVsWX --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Jonathan, I'm CC'ing guix-devel because I suspect many users who cloned/updated the Guix repo are having the same results... and concerns. This is a git bug, not an issue with our repo, and for this reason (I hope) I'm closing this bug; please see below. Jonathan Brielmaier via Bug reports for GNU Guix writes: > Hm, I'm hitting this bug while trying to work on the openSUSE package. > They offer a way to build RPM packages from the most recent master > commit, but it's get the wrong version (1.3.0 instead of 1.4.0) due to > this `git describe` result. As pointed out by Simon last June the result of "git describe" is not what users should get given the "Search strategy" documented in the command manual: https://git-scm.com/docs/git-describe#_search_strategy: =2D-8<---------------cut here---------------start------------->8--- If multiple tags were found during the walk then the tag which has the fewest commits different from the input commit-ish will be selected and output. Here fewest commits different is defined as the number of commits which would be shown by git log tag..input will be the smallest number of commits possible. =2D-8<---------------cut here---------------end--------------->8--- The upstream bug report (and a reproducer) is this one: =C2=ABSubject: [BUG] `git describe` doesn't traverse the graph in topologic= al order=C2=BB https://lore.kernel.org/git/ZNffWAgldUZdpQcr@farprobe/ Another user also reported the issue and a reproducer: https://public-inbox.org/git/PH0PR08MB773203CE3206B8DEFB172B2F94839@PH0PR08= MB7732.namprd08.prod.outlook.com/ The "executive summary" is that "git describe" gets the count of "fewest commits different from the input commit-ish" wrong (see anso previous messages in this thread for details). Anyway, even if this bug was solved, I'd warmly suggest NOT to base the check for the latest stable Guix commit (usually tagged as v[0-9]*) on the result of "git describe". Today, if "guix describe" had no bugs, the correct result would be: "base-for-issue-62196"... AFAIU :-) This is a reproducer: =2D-8<---------------cut here---------------start------------->8--- $ git describe $(git rev-list --tags --max-count=3D1) base-for-issue-62196 =2D-8<---------------cut here---------------end--------------->8--- To get the value corresponding to the latest tagged version, we should testrict the list of tags to the ones matching the "v[0-9]*" regexp: =2D-8<---------------cut here---------------start------------->8--- $ git describe $(git rev-list --tags=3D"v[0-9]*" --max-count=3D1) v1.4.0 =2D-8<---------------cut here---------------end--------------->8--- To browse all the tags there is the "git tag" command, for example to have the list and description of every Guix released version: =2D-8<---------------cut here---------------start------------->8--- $ git tag -l "v[0-9]*" --sort=3D-creatordate -n v1.4.0 GNU Guix 1.4.0. v1.4.0rc2 GNU Guix 1.4.0rc2. v1.4.0rc1 GNU Guix 1.4.0rc1. v1.3.0 GNU Guix 1.3.0. v1.3.0rc2 GNU Guix 1.3.0rc2. v1.3.0rc1 GNU Guix 1.3.0rc1. v1.2.0 GNU Guix 1.2.0. v1.2.0rc2 GNU Guix 1.2.0rc2. v1.2.0rc1 GNU Guix 1.2.0rc1. v1.1.0 GNU Guix 1.1.0. v1.1.0rc2 GNU Guix 1.1.0rc2. v1.1.0rc1 GNU Guix 1.1.0rc1. v1.0.1 GNU Guix 1.0.1. v1.0.0 GNU Guix 1.0.0. v0.16.0 GNU Guix 0.16.0. v0.15.0 GNU Guix 0.15.0. v0.14.0 GNU Guix 0.14.0. v0.13.0 GNU Guix 0.13.0. v0.12.0 GNU Guix 0.12.0 v0.11.0 GNU Guix 0.11.0. v0.10.0 GNU Guix 0.10.0. v0.9.0 GNU Guix 0.9.0. v0.8.3 GNU Guix 0.8.3. v0.8.2 GNU Guix 0.8.2. v0.8.1 GNU Guix 0.8.1. v0.8 GNU Guix 0.8. v0.7 GNU Guix 0.7. v0.6 GNU Guix 0.6. v0.5 GNU Guix 0.5. v0.4 GNU Guix 0.4. v0.3 GNU Guix 0.3. v0.2 GNU Guix 0.2. v0.1 GNU Guix 0.1. v0.0 Guix 0.0, initial announcement. =2D-8<---------------cut here---------------end--------------->8--- HTH! Happy hacking, Gio' =2D-=20 Giovanni Biscuolo Xelera IT Infrastructures --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJABAEBCgAqFiEERcxjuFJYydVfNLI5030Op87MORIFAmW+iUMMHGdAeGVsZXJh LmV1AAoJENN9DqfOzDkSFaQP/iYotAPeTDFBu+TZLh0vcE0SpIACEL5XFQj3tgDr eYx5b7ODJaESeqSLcJqbaQbe2/E95XicfCyC5tV5yDqpKqJ0qqBcG8EHqTU+Wp9x GwE8QjNsfgZKHSeFxS23Y1tGyYEU/uv8tr2o9KMLEI2jEcTDWBtPmjzhknKODhxl Cx9EfJ83Twz4h70NurG5iHAYUkYIyIRMrwHwx5EVv91WnRN5mkIyC0WJfyQxhbXo KNeZlH64YKELeWkjVsTnKDVapBQsgHJE2UBqZyiDXZDFoxhJo+BTRXHXWsRO4xao JbGpe/p77p2FxuuOjxk+1jhmwAKWASXkRTXIRdqx7odpx6tjz72KJqdIeSLxtNrR GOWhNXy2no6vmFkqK5diybGIR4Al9pbgNiS3SfNdXLFUodqhbFbO+4YtfFznhmQW 1vOOzofv2xGfXt0rnu9+0GaSgd0NfjJpbE/BsWYX9ILAQdXwBPkYLFVVBalKdrLk ontodcUcnbfii0kra+Ey2oygCE0aqJyReO0jEcl4DlYAEM5uW67Jfn9RN7A/ajE6 I5IDapq5RZkl4TYv0jAGrKnQrdqHRtjpZfC0YQJqORTZbqlvMx52JwVtifEPoFpJ JKEyrkSXdsoKg4OKTXfStGkZ+jP9Ol8USHgSXNxBgXgL5dymQsXlClvLCrcK/r5w YSsD =tnb7 -----END PGP SIGNATURE----- --=-=-=--