From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 3/4 v2] gnu: Enable tests in Python 3.
Date: Sat, 22 Mar 2014 15:32:41 +0100
Message-ID: <87k3bmwbg6.fsf@gnu.org>
References: <878usm9wik.fsf@gnu.org>
	<1395375140-18122-1-git-send-email-tipecaml@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60910)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1WRMyh-0001J5-Dm
	for guix-devel@gnu.org; Sat, 22 Mar 2014 10:32:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1WRMyZ-0000DV-6X
	for guix-devel@gnu.org; Sat, 22 Mar 2014 10:32:51 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:44539)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1WRMyY-0000DJ-W7
	for guix-devel@gnu.org; Sat, 22 Mar 2014 10:32:43 -0400
In-Reply-To: <1395375140-18122-1-git-send-email-tipecaml@gmail.com> (Cyril
	Roelandt's message of "Fri, 21 Mar 2014 05:12:20 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org

Cyril Roelandt <tipecaml@gmail.com> skribis:

> * gnu/packages/python.scm: enable tests for Python 3
> * gnu/packages/python-fix-tests.patch: New file.
> * gnu/packages/gnu-system.am (dist_patch_DATA): add it.

OK, with one detail:

> ++    @unittest.skipUnless(os.path.exists("/etc/gai.conf"),
> ++                         "getaddrinfo() will fail")
> +     def testGetaddrinfo(self):

Is this an upstream patch?  If yes, then fine, otherwise I think we
should not mention gai.conf since it=E2=80=99s really not the issue.

So @unittest.skipUnless(false, "getaddrinfo() will fail") would be good
enough IMO.

OK to push with these last thing addressed.  :-)

Ludo=E2=80=99.