From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add guile-opengl
Date: Wed, 25 Jun 2014 21:29:19 +0200
Message-ID: <87k384okj4.fsf@gnu.org>
References: <87pphxd9uf.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38615)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Wzssp-0001lN-Pj
	for guix-devel@gnu.org; Wed, 25 Jun 2014 15:29:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Wzssj-00039j-Ku
	for guix-devel@gnu.org; Wed, 25 Jun 2014 15:29:27 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:45318)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1Wzssj-00039W-Dm
	for guix-devel@gnu.org; Wed, 25 Jun 2014 15:29:21 -0400
In-Reply-To: <87pphxd9uf.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
	(David Thompson's message of "Tue, 24 Jun 2014 22:03:20 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org

David Thompson <dthompson2@worcester.edu> skribis:

> Finally got around to finishing up this package.  I ran the example
> programs shipped with guile-opengl and confirmed that they work as
> expected. :)
>
> How does it look?

Looks good to me!  One comment:

> +                   (define (dynamic-link-substitute file lib input)
> +                     (substitute* file
> +                       (((string-append "dynamic-link \"" lib "\""))
> +                        (string-append "dynamic-link \""
> +                                       (assoc-ref inputs input)
> +                                       "/lib/" lib "\""))))

Patterns in =E2=80=98substitute*=E2=80=99 are supposed to be literals.

Wouldn=E2=80=99t it work to do something like:

  (substitute* file
    (("dynamic-link \"lib[a-zA-Z]+\" _ libname)
     (string-append ...)))

?

Thanks,
Ludo=E2=80=99.