From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add sane-backends
Date: Sun, 19 Oct 2014 11:54:56 +0200
Message-ID: <87k33wz8nj.fsf@gnu.org>
References: <1413707083-6228-1-git-send-email-jmd@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45365)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XfnCS-0003LB-HF
	for guix-devel@gnu.org; Sun, 19 Oct 2014 05:55:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XfnCK-0005dr-7w
	for guix-devel@gnu.org; Sun, 19 Oct 2014 05:54:56 -0400
In-Reply-To: <1413707083-6228-1-git-send-email-jmd@gnu.org> (John Darrington's
	message of "Sun, 19 Oct 2014 10:24:43 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org

John Darrington <jmd@gnu.org> skribis:

> * gnu/packages/scanner.scm: New file.
> * gnu-system.am (gnu/packages/scanner.scm): Add it.

Should be:

    * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

> +  #:use-module ((guix licenses)
> +                #:renamer (symbol-prefix-proc 'license:)))

Use: #:prefix license: .

> +(define-public sane-backends
> +  (package
> +    (name "sane-backends")
> +    (version "1.0.24")
> +    (source (origin
> +             (method url-fetch)
> +             (uri (string-append=20
> +                   "http://fossies.org/linux/misc/" name "-" version ".t=
ar.gz"))
> +             ;; This is a private mirror.  The canonical download site is
> +             ;; "https://alioth.debian.org/frs/download.php/file/3958/"
> +             ;; but it seems not to work with gnutls atm

Indeed, I get 406 "Not Acceptable".  I=E2=80=99m not sure if this relates to
<http://bugs.gnu.org/18526>; could you open a bug?

In the meantime, can you put the two URLs, as in:

  (uri (list (string-append ...)
             (string-append ...)))

> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:tests? #f)) ; It would seem that tests are not maintained

What exactly is failing?  In the comment, please put facts on what=E2=80=99s
failing rather than guesses.  ;-)

> +    (home-page "http://www.sane-project.org")
> +    (synopsis "Raster image scanner hardware API")

Maybe =E2=80=9CSANE hardware drivers=E2=80=9D?

> +    (description "SANE stands for \"Scanner Access Now Easy\" and is an =
API
> +proving access to any raster image scanner hardware (flatbed scanner,
> +hand-held scanner, video- and still-cameras, frame-grabbers, etc.)..")=
=20=20

Likewise, maybe state that this package provides the drivers.

Thanks,
Ludo=E2=80=99.