From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 01/13] gnu: subversion: Propagate env variables to hooks.
Date: Sat, 22 Nov 2014 12:02:59 +0100
Message-ID: <87k32njy58.fsf@gnu.org>
References: <1416548468-28421-1-git-send-email-bavier@member.fsf.org>
	<1416548468-28421-2-git-send-email-bavier@member.fsf.org>
	<871towp5ze.fsf@gnu.org> <87ppcgtcoj.fsf@gmail.com>
	<CADwNbn_+Md_5RKQoCZnCzxzhBazD20+wYbM-2-7dMsNy2riZ1A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58722)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Xs8T9-0005sU-38
	for guix-devel@gnu.org; Sat, 22 Nov 2014 06:03:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Xs8T3-0000sR-U1
	for guix-devel@gnu.org; Sat, 22 Nov 2014 06:03:11 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:36432)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1Xs8T3-0000sN-NK
	for guix-devel@gnu.org; Sat, 22 Nov 2014 06:03:05 -0500
In-Reply-To: <CADwNbn_+Md_5RKQoCZnCzxzhBazD20+wYbM-2-7dMsNy2riZ1A@mail.gmail.com>
	(Eric Bavier's message of "Fri, 21 Nov 2014 23:15:24 -0600")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Eric Bavier <ericbavier@gmail.com>
Cc: Guix-devel <guix-devel@gnu.org>, Eric Bavier <bavier@member.fsf.org>

Eric Bavier <ericbavier@gmail.com> skribis:

> On Fri, Nov 21, 2014 at 4:24 PM, Eric Bavier <ericbavier@gmail.com> wrote:
>
>>
>> Ludovic Court=C3=A8s writes:
>>
>> > Eric Bavier <ericbavier@gmail.com> skribis:
>> >
>> >> * gnu/packages/patches/subversion-propagate-env-to-hooks.patch: New
>> patch.
>> >> * gnu-system.am (dist_patch_DATA): Add it.
>> >> * gnu/packages/version-control.scm (subversion): Use it.
>> >
>> > [...]
>> >
>> >> +++ b/gnu/packages/patches/subversion-propagate-env-to-hooks.patch
>> >> @@ -0,0 +1,14 @@
>> >> +* Hooks need to inherit environment variables such as PATH, otherwise
>> simple
>> >> +  things like `ls` might fail in a hook.
>> >
>> > That looks good, but I want to make sure we=E2=80=99re not changing so=
mething
>> > that was purposefully made this way.
>>
>> If the behavior is similar in 1.8.10, I'll get in contact with the
>> developers.
>>
>
> According to the subversion documentation, the desired behavior is to
> execute hooks in an empty environment for security reasons (see
> http://svnbook.red-bean.com/en/1.7/svn.reposadmin.create.html#svn.reposad=
min.create.hooks
> ).

OK, so I think it=E2=80=99s important to stick to this behavior.

> So it looks like this is a small bug in libtool.  The wrapper scripts
> libtool generates for programs use `ls' to resolve symbolic links and is
> the only utility program invoked without an absolute file name (the only
> other utility being sed).  If such a wrapper script is executed with no
> PATH set, then we get "ls: command not found" errors.  I don't think it's
> unreasonable to expect libtool's wrappers to be able to execute in an emp=
ty
> environment.

I see.  So the patch is there =E2=80=9Cjust=E2=80=9D to allow tests to run,=
 right?

Second, the problem should affect everyone, including FHS systems, no?
How do people work around it?

Thanks,
Ludo=E2=80=99.