From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add Threading Building Blocks
Date: Mon, 26 Jan 2015 22:24:23 +0100 [thread overview]
Message-ID: <87k309grqw.fsf@gnu.org> (raw)
In-Reply-To: <idjbnllr2ln.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's message of "Mon, 26 Jan 2015 16:19:48 +0100")
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
> There are a couple of things I'm not sure about:
>
> - should the examples be included per default or should they go into a
> separate "doc" output together with the /doc directory? Together they
> take up about 10MB.
I would put them in “doc”.
> - the version number is only given as "4.3 Update 2 Current version" on
> the download page. I turned this into "4.3.2", but I'm not sure if
> this is really equivalent or if we should rather use the datestamp on
> the tarball (= "43_20141204")
“4.3.2” looks good. If need be, the numbering scheme can always be
adjusted later.
> From 3e5e1e49893c73f8b9a565edcae5388f548dd13a Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Mon, 26 Jan 2015 16:12:31 +0100
> Subject: [PATCH] gnu: Add Threading Building Blocks.
>
> * gnu/packages/tbb.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
[...]
> + (alist-cons-before
> + 'build 'set-build-path
> + (lambda _
> + (substitute* "build/common.inc"
> + (("export tbb_build_prefix.+$")
> + "export tbb_build_prefix?=guix\n")))
Rather put this in ‘snippet’ (I think Mark made this comment on IRC.)
> + (synopsis "The Threading Building Blocks library abstracts low-level
> +threading details")
What about “C++ library for parallel programming” instead?
> + (description
> + "Threading Building Blocks (TBB) is a C++ runtime library that abstracts
> +the low-level threading details necessary for optimal multi-core performance.
> +It uses common C++ templates and coding style to eliminate tedious threading
> +implementation work.
> +
> +TBB requires fewer lines of code to achieve parallelism than other threading
> +models. The applications you write are portable across platforms. Since the
> +library is also inherently scalable, no code maintenance is required as more
> +processor cores become available.")
I would indeed remove the 2nd paragraph, and perhaps add something like
“It provides parallel loop constructs, asynchronous tasks,
synchronization primitives, atomic operations, and more.”
> + ;; GPL2 with exceptions
Rather: “GPLv2 with run-time exception:
<https://www.threadingbuildingblocks.org/licensing#runtime-exception>”.
Thanks,
Ludo’.
next prev parent reply other threads:[~2015-01-26 21:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 15:19 [PATCH] gnu: Add Threading Building Blocks Ricardo Wurmus
2015-01-26 21:24 ` Ludovic Courtès [this message]
2015-01-27 16:58 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k309grqw.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).