From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add tig.
Date: Thu, 12 Mar 2015 21:32:43 +0100
Message-ID: <87k2ym0xec.fsf@gnu.org>
References: <1426107500-14709-1-git-send-email-sleep_walker@suse.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50192)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YW9ml-0008E9-15
	for guix-devel@gnu.org; Thu, 12 Mar 2015 16:32:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YW9mg-0002Lq-1H
	for guix-devel@gnu.org; Thu, 12 Mar 2015 16:32:50 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46702)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YW9mf-0002Lm-Un
	for guix-devel@gnu.org; Thu, 12 Mar 2015 16:32:45 -0400
In-Reply-To: <1426107500-14709-1-git-send-email-sleep_walker@suse.cz>
	(=?utf-8?B?IlRvbcOhxaEJxIxlY2giJ3M=?= message of "Wed,
	11 Mar 2015 21:58:20 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?utf-8?B?VG9tw6HFoSDEjGVjaA==?= <sleep_walker@suse.cz>
Cc: guix-devel@gnu.org

Tom=C3=A1=C5=A1 =C4=8Cech <sleep_walker@suse.cz> skribis:

> * gnu/packages/version-control.scm (tig): New variable.

[...]

> +    (arguments
> +     `(#:phases
> +       (alist-delete 'check %standard-phases)))

Rather =E2=80=9C#:tests? #f=E2=80=9D with a comment explaining why this is =
done (lack of
test suite?).

> +    (synopsis "ncurses-based text-mode for GIT")

=E2=80=9CNcurses-based text user interface for Git=E2=80=9D

> +    (description
> +     "Tig is ncurses TUI for GIT, primary intended as history browser bu=
t can
> +stage chunks for commit or colorize any GIT output.")

A few typos:  =E2=80=9CTig is an ncurses text user interface for Git, prima=
rily
intended as a history browser.  It can also stage hunks for commit, or
colorize the output of the 'git' command.=E2=80=9D

> +    (license gpl2)))

GPLv2-only?

Could you send an updated patch?

Thanks,
Ludo=E2=80=99.