Re: [PATCHES] Various

[ludo@gnu.org (Ludovic Courtès)]

taylanbayirli@gmail.com (Taylan Ulrich "Bayırlı/Kammer") skribis:

> So I patched the pkg-config files of Leptonica (to move zlib and
> openjpeg from Libs.private to Libs) and Tesseract (to enable the
> Requires field, since Leptonica provides lept.pc on the meanwhile).
>
> The relevant Tesseract bug report is at:
> https://code.google.com/p/tesseract-ocr/issues/detail?id=1436

OK.  Could you add a link to this as a comment?

> From 41e485e47749119afc039796e88fcf8f787eeabc Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
>  <taylanbayirli@gmail.com>
> Date: Sat, 21 Mar 2015 19:41:54 +0100
> Subject: [PATCH 4/8] gnu: Add leptonica.
>
> * gnu/packages/image.scm (leptonica): New variable.

[...]

> +       (uri (string-append "http://www.leptonica.com/source/leptonica-"
> +                           version ".tar.gz"))

Really, they didn’t use ‘make dist’?

> +       (sha256
> +        (base32 "0j5qgrff6im5n9waflbi7w643q1p6mahyf2z35gb4vj9h5p76pfc"))
> +       (modules '((guix build utils)))
> +       ;; zlib and openjpg should be under Libs, not Libs.private.

Link to the bug report.

OK to push changes.  I wonder if (gnu packages graphics) would be more
appropriate.  Your call.

> From d12b1999a228d34e76cb93cba1a75cf7d18176bd Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
>  <taylanbayirli@gmail.com>
> Date: Sat, 21 Mar 2015 20:11:56 +0100
> Subject: [PATCH 6/8] gnu: Add tesseract-ocr.
>
> * gnu/packages/ocr.scm (tesseract-ocr): New variable.

[...]

> +       ;; Leptonica provides a pkg-config file on the meanwhile.

s/provides/added/ s/on/in/

OK.

> From 4c8af1741208f2d65e8ca9f3a37df38eb93a4b2d Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
>  <taylanbayirli@gmail.com>
> Date: Sat, 21 Mar 2015 23:09:11 +0100
> Subject: [PATCH 7/8] gnu: Add vapoursynth.
>
> * gnu/packages/video.scm (vapoursynth): New variable.

LGTM!

Ludo’.