Re: [PATCH] Add Julia.

[Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>]

[-- Attachment #1: Type: text/plain, Size: 511 bytes --]


Mark H Weaver writes:

> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:
>
>> May I suggest adding passing the "DYNAMIC_ARCH=1" flag in openblas
>> instead of propagating non-substitutability to Julia?  When built with
>> "DYNAMIC_ARCH=1" the CPU type can be picked with the environment
>> variable OPENBLAS_CORETYPE=<type>.  If I'm not mistaken this makes
>> substitutions for openblas possible.
>>
>> What do you think?
>
> Yes, we should do this.

Attached is a patch to make openblas substitutable.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-openblas-build-for-all-supported-CPUs.patch --]
[-- Type: text/x-patch, Size: 1076 bytes --]

From 326fa66415fe8e9ed2b28a249b903f4a654b769e Mon Sep 17 00:00:00 2001
From: Ricardo Wurmus <rekado@elephly.net>
Date: Wed, 25 Mar 2015 19:20:11 +0100
Subject: [PATCH] gnu: openblas: build for all supported CPUs.

* gnu/packages/maths.scm (openblas)[arguments]: Pass make flag
  "DYNAMIC_ARCH=1" to build library for all CPUs, making it substitutable.
---
 gnu/packages/maths.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 49667cc..57c1e9f 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -1033,10 +1033,10 @@ constant parts of it.")
     (build-system gnu-build-system)
     (arguments
      '(#:tests? #f  ;no "check" target
-       #:substitutable? #f ;force local build because of CPU detection
        #:make-flags
        (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
              "SHELL=bash"
+             "DYNAMIC_ARCH=1"
              "NO_LAPACK=1")
        ;; no configure script
        #:phases (alist-delete 'configure %standard-phases)))
-- 
2.1.0