From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH] gnu: Add TuxGuitar.
Date: Tue, 21 Apr 2015 21:49:53 +0200
Message-ID: <87k2x51cta.fsf@mango.localdomain>
References: <874mob2zaf.fsf@mango.localdomain> <87383th3kn.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35505)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1YkeBJ-0004Lb-62
	for guix-devel@gnu.org; Tue, 21 Apr 2015 15:50:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1YkeBI-0007NT-EV
	for guix-devel@gnu.org; Tue, 21 Apr 2015 15:50:05 -0400
In-reply-to: <87383th3kn.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: Guix-devel <guix-devel@gnu.org>


Ludovic Courtès writes:

> Ricardo Wurmus <rekado@elephly.net> skribis:
>
>> From 717af487b3f0924b39c8a19e25453f20859b62bf Mon Sep 17 00:00:00 2001
>> From: Ricardo Wurmus <rekado@elephly.net>
>> Date: Sun, 19 Apr 2015 18:42:16 +0200
>> Subject: [PATCH 1/2] gnu: Add SWT.
>>
>> * gnu/packages/java.scm (swt): New variable.
>
> LGTM.  A common issue with Java packages is that they tend to bundle
> pre-built jars, possibly coming from elsewhere.  Please make sure this
> is not the case.

Yes, this is rather annoying and is true for many Java applications I
encountered (or maybe it's just common in bioinformatics circles?).  The
SWT tarball does include jars but these are binaries of the library.
The package recipe ignores them and only works on the sources in src.zip
(a zip inside a zip).  There are no binaries in the src.zip archive.

>> From 8893511249d828d443d1b215dbcd6669da216e63 Mon Sep 17 00:00:00 2001
>> From: Ricardo Wurmus <rekado@elephly.net>
>> Date: Sun, 19 Apr 2015 18:39:25 +0200
>> Subject: [PATCH 2/2] gnu: Add TuxGuitar.
>>
>> * gnu/packages/music.scm (tuxguitar): New variable.
>
> OK.
>
> Thanks!

Thanks for the review!

~~ Ricardo