From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] Various samtools patches. Date: Sun, 03 May 2015 21:37:27 +0200 Message-ID: <87k2wp311k.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yozhn-0008QH-ES for guix-devel@gnu.org; Sun, 03 May 2015 15:37:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yozhj-0004yc-Eh for guix-devel@gnu.org; Sun, 03 May 2015 15:37:35 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42967) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yozhj-0004yY-BG for guix-devel@gnu.org; Sun, 03 May 2015 15:37:31 -0400 In-Reply-To: (Ricardo Wurmus's message of "Tue, 28 Apr 2015 11:35:14 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel Ricardo Wurmus skribis: > The third patch adds the most recent version of the 0.1 line of > samtools. The input and output formats differ greatly from that used > and produced by samtools 1.x (which has already been packaged as > "samtools") and is still used in many bioinformatics pipelines. Could you write it as a comment just below (define samtools-0.1 ? That way people will know why it matters to keep both. Also, if both versions can be parallel-installed, it may be nice to give them a different =E2=80=98name=E2=80=99 field (say =E2=80=98sametools0=E2= =80=99 for the older one.) If they=E2=80=99re not, it=E2=80=99s fine this way. Otherwise all 3 patches LGTM! Thanks, Ludo=E2=80=99.