unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Lirzin <mthl@openmailbox.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: 'origin' indentation rule.
Date: Fri, 11 Sep 2015 21:35:19 +0200	[thread overview]
Message-ID: <87k2rwlpfs.fsf@openmailbox.org> (raw)
In-Reply-To: <87zj0sc29c.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Fri, 11 Sep 2015 19:08:31 +0200")

ludo@gnu.org (Ludovic Courtès) writes:

> Mathieu Lirzin <mthl@openmailbox.org> skribis:
>
>> I failed to retrieve the post where this rule has been suggested (if
>> there is one), so I don't know the rationale behind it.
>
> I don’t think it was discussed at the time.  It’s just that I like
> ‘package’ and ‘origin’ indented like ‘begin’, I think it’s more pleasant
> to the eye.  :-)

Ok, that makes sense. :)

> It’s a good idea to have the manual conform to the rule.
>
> Other than that, I think it’s no big deal if some packages don’t follow
> exactly this rule.  I encourage people to follow this rule, but I prefer
> a patch that violates it than no patch at all.  I guess it’s about
> finding the right balance between nitpicking and welcoming.  ;-)

"encourage" means that this is OK that those who use Emacs and/or know
this rule apply silently this indentation rule when for example updating
a package definition?

> Importers render code with (ice-9 pretty-print), which is quite
> primitive, so they cannot follow sophisticated rules.

OK, I didn't know about that.

> So apart from the manual, I wouldn’t change anything.

I will send a patch for this, if we agree on that.

--
Mathieu Lirzin

  parent reply	other threads:[~2015-09-11 19:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-10 21:26 'origin' indentation rule Mathieu Lirzin
2015-09-11 17:08 ` Ludovic Courtès
2015-09-11 17:09   ` Thompson, David
2015-09-11 19:12     ` Mathieu Lirzin
2015-09-11 19:35   ` Mathieu Lirzin [this message]
2015-09-11 20:57     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k2rwlpfs.fsf@openmailbox.org \
    --to=mthl@openmailbox.org \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).