From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH] Add Blender
Date: Wed, 23 Sep 2015 08:45:24 +0200
Message-ID: <87k2rhpraz.fsf@elephly.net>
References: <87a8sg6cpx.fsf@elephly.net>
	<20150921184539.2cddac04@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43330)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1Zedo8-0001ay-3F
	for guix-devel@gnu.org; Wed, 23 Sep 2015 02:45:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1Zedo3-0005Kz-Nm
	for guix-devel@gnu.org; Wed, 23 Sep 2015 02:45:35 -0400
Received: from sender163-mail.zoho.com ([74.201.84.163]:25677)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1Zedo3-0005KM-GH
	for guix-devel@gnu.org; Wed, 23 Sep 2015 02:45:31 -0400
In-reply-to: <20150921184539.2cddac04@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Eric Bavier <ericbavier@openmailbox.org>
Cc: guix-devel <guix-devel@gnu.org>


Eric Bavier <ericbavier@openmailbox.org> writes:

>> +(define-public openimageio
>> +  (package
> [...]
>> +    (description
>> +      "OpenImageIO is a library for reading and writing images, and a bunch of
>         ^
> Align the opening quote to the 'd'.

Ah, good catch!  I fixed this and pushed openimageio.

>> * gnu/packages/graphics.scm (blender): New variable.

[...]

>> +         (add-after 'set-paths 'add-ilmbase-include-path
>> +          (lambda* (#:key inputs #:allow-other-keys)
>> +            ;; OpenEXR propagates ilmbase, but its include files do not appear
>> +            ;; in the CPATH, so we need to add "$ilmbase/include/OpenEXR/" to
>> +            ;; the CPATH to satisfy the dependency on "half.h".
>> +            (setenv "CPATH"
>> +                    (string-append (assoc-ref inputs "ilmbase")
>> +                                   "/include/OpenEXR"
>> +                                   ":" (getenv "CPATH")))
>
> Is the "half.h" header in OpenEXR, or in blender?  If the latter, would
> it make more sense to instead patch the include directive to include
> the OpenEXR path?

“half.h” is provided by “ilmbase”.  The include is in Blender, in this
file:

    blender-2.75a/source/blender/imbuf/intern/openexr/openexr_api.cpp

I could patch this instead, replacing

    #include <half.h>

with

    #include <OpenEXR/half.h>

I’ll fix this, recompile and if there are no further objections push
upon success.

Thanks!

~~ Ricardo