From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 14/15] scripts: environment: Add --container option.
Date: Sun, 25 Oct 2015 22:38:12 +0100
Message-ID: <87k2qak4sb.fsf@gnu.org>
References: <1436188604-2813-1-git-send-email-dthompson2@worcester.edu>
	<1436188604-2813-14-git-send-email-dthompson2@worcester.edu>
	<87zj38f326.fsf@gnu.org>
	<CAJ=RwfZneE5REVTPULLKoh2V2yYNYnFa=gDSwiN=3CLN1eRLhw@mail.gmail.com>
	<87oah93zbk.fsf@gnu.org>
	<CAJ=RwfY8bs4hSXaN0SyTAZy89k4QFY=jG-vzLkarudkD9Q6Agg@mail.gmail.com>
	<87a8rpyzb9.fsf@gnu.org> <87d1wdn72e.fsf@gnu.org>
	<CAJ=RwfZwNSoxYDwPF1d2a23R5uLfpr-mzFuxEbWrH9J4br855Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47978)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZqSzb-000638-VJ
	for guix-devel@gnu.org; Sun, 25 Oct 2015 17:38:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZqSza-0003X3-Ol
	for guix-devel@gnu.org; Sun, 25 Oct 2015 17:38:19 -0400
In-Reply-To: <CAJ=RwfZwNSoxYDwPF1d2a23R5uLfpr-mzFuxEbWrH9J4br855Q@mail.gmail.com>
	(David Thompson's message of "Wed, 21 Oct 2015 21:23:11 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: "Thompson, David" <dthompson2@worcester.edu>
Cc: guix-devel <guix-devel@gnu.org>, David Thompson <davet@gnu.org>

"Thompson, David" <dthompson2@worcester.edu> skribis:

> From a61c65357174263790a55e8785fc625209e11324 Mon Sep 17 00:00:00 2001
> From: David Thompson <davet@gnu.org>
> Date: Fri, 19 Jun 2015 08:57:44 -0400
> Subject: [PATCH] scripts: environment: Add --container option.
>
> * guix/scripts/system.scm (specification->file-system-mapping): Move from
>   here...
> * guix/ui.scm (specification->file-system-mapping): ... to here.
> * guix/scripts/enviroment.scm (show-help): Show help for new options.
>   (%options): Add --container --network, --expose, and --share options.
>   (%network-configuration-files): New variable.
>   (launch-environment, launch-environment/container, requisites*,
>   inputs->requisites): New procedures.
>   (guix-environment): Spawn new process in a container when requested.
> * doc/guix.texi (Invoking guix environment): Document it.
> * tests/guix-environment-container.sh: New file.
> * Makefile.am (SH_TESTS): Add it.

[...]

> --- a/tests/guix-environment.sh
> +++ b/tests/guix-environment.sh
> @@ -55,6 +55,15 @@ else
>      test $? =3D 42
>  fi
>=20=20
> +# Make sure the exit value is preserved for containers, too.
> +if guix environment --container --ad-hoc --bootstrap guile-bootstrap \
> +        -- guile -c '(exit 42)'
> +then
> +    false
> +else
> +    test $? =3D 42
> +fi

I think this bit is a leftover from a previous attempt that can now be
removed (guix-environment-container.sh contains the same test.)

OK to push with this change!  Exciting stuff, thank you!

Ludo=E2=80=99.