Re: [PATCH 14/15] scripts: environment: Add --container option.

[ludo@gnu.org (Ludovic Courtès)]

"Thompson, David" <dthompson2@worcester.edu> skribis:

> From a61c65357174263790a55e8785fc625209e11324 Mon Sep 17 00:00:00 2001
> From: David Thompson <davet@gnu.org>
> Date: Fri, 19 Jun 2015 08:57:44 -0400
> Subject: [PATCH] scripts: environment: Add --container option.
>
> * guix/scripts/system.scm (specification->file-system-mapping): Move from
>   here...
> * guix/ui.scm (specification->file-system-mapping): ... to here.
> * guix/scripts/enviroment.scm (show-help): Show help for new options.
>   (%options): Add --container --network, --expose, and --share options.
>   (%network-configuration-files): New variable.
>   (launch-environment, launch-environment/container, requisites*,
>   inputs->requisites): New procedures.
>   (guix-environment): Spawn new process in a container when requested.
> * doc/guix.texi (Invoking guix environment): Document it.
> * tests/guix-environment-container.sh: New file.
> * Makefile.am (SH_TESTS): Add it.

[...]

> --- a/tests/guix-environment.sh
> +++ b/tests/guix-environment.sh
> @@ -55,6 +55,15 @@ else
>      test $? = 42
>  fi
>  
> +# Make sure the exit value is preserved for containers, too.
> +if guix environment --container --ad-hoc --bootstrap guile-bootstrap \
> +        -- guile -c '(exit 42)'
> +then
> +    false
> +else
> +    test $? = 42
> +fi

I think this bit is a leftover from a previous attempt that can now be
removed (guix-environment-container.sh contains the same test.)

OK to push with this change!  Exciting stuff, thank you!

Ludo’.