Re: [PATCH] build: Add a scheme custom test driver using SRFI-64.

[ludo@gnu.org (Ludovic Courtès)]

Mathieu Lirzin <mthl@gnu.org> skribis:

> ludo@gnu.org (Ludovic Courtès) writes:

[...]

>>> One caveat is that ‘tests/cpio.scm‘ is now failing.
>>
>> Why is that?  Does it relate to this change?
>
> I didn't try to debug the problem but it has appeared when I started
> messing with redirection of the output/error ports.  Here is the failure
> output.
>
> test-name: bit-identical to GNU cpio's output
> location: /home/mthl/src/gnu/guix/tests/cpio.scm:49

Is GNU cpio available in $PATH?  Which version is that?  Could you run
this test in ‘master’ to see if the problem shows up?

>>> Since this script is not intented to be exclusively used by Guix, I have
>>> used a generic copyright notice.  I guess Guix is the best place to
>>> challenge and improve it, but IMO it will be better hosted elsewhere
>>> like in Gnulib.  Opinions?
>>
>> I think we could start using it and testing it for a while in Guix, and
>> eventually submit it for inclusion in Gnulib once we are more confident.
>
> So you recommend to add ”this file is part of GNU Guix” and use “GNU
> Guix” instead of “this program” for now?

I think you can leave “this program” so nothing will need to be changed
when you move it elsewhere.

>> However, I’m unsure if we should push it now, or after the release.  On
>> one hand, I’d rather avoid potentially disrupting changes like this
>> now.  On the other hand, since it makes it easier (and different) to
>> report test failures, it’s nice.
>>
>> How confident are you?  :-)
>
> IMHO we should wait after the next release in order to make this test
> driver more bullet proof.

Sounds reasonable.

Thanks!

Ludo’.