[PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl)

[PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl)

[Nils Gillmann]

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

Sorry for squeezing it all into one commit that's all I know
right now, tested and everything works. open bug preceeding this
is to get input from people to fix twm integration.


[-- Attachment #2: 0001-gnu-gnunet-Various-Changes.patch --]
[-- Type: text/x-patch, Size: 9299 bytes --]

From 867bf5c7418d2caaf51414afe46df4b3e3b8b058 Mon Sep 17 00:00:00 2001
From: Nils Gillmann <niasterisk@grrlz.net>
Date: Fri, 11 Mar 2016 17:08:26 +0100
Subject: [PATCH] gnu: gnunet (Various Changes)

* gnu/packages/gnunet.scm:
  Add gnunet-svn (New Variable)
  Add gnunet-gtk-svn (Likewise)
  gnunet-gtk: (#configure-flags: add --with-gnunet)
  gnurl: (#configure-flags: add --with-ca-path)
above co-authored by Jookia

  gnunet: Update and make description more accessible
  gnunet-gtk-svn: track bug #22985
---
 gnu/packages/gnunet.scm | 167 ++++++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 154 insertions(+), 13 deletions(-)

diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
index eb0c4cb..e2919e4 100644
--- a/gnu/packages/gnunet.scm
+++ b/gnu/packages/gnunet.scm
@@ -3,8 +3,9 @@
 ;;; Copyright © 2014 Sree Harsha Totakura <sreeharsha@totakura.in>
 ;;; Copyright © 2015 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2015 Efraim Flashner <efraim@flashner.co.il>
-;;; Copyright © 2016 Ni* Gillmann <ng@niasterisk.space>
+;;; Copyright © 2016 Nils Gillmann <niasterisk@grrlz.net>
 ;;; Copyright © 2016 Ricardo Wurmus <rekado@elephly.net>
+;;; Copyright © 2016 Jookia <166291@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -53,6 +54,7 @@
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix git-download)
+  #:use-module (guix svn-download)
   #:use-module (guix build-system gnu))
 
 (define-public libextractor
@@ -178,7 +180,7 @@ and support for SSL3 and TLS.")
                           "--disable-ldap" "--disable-rtsp" "--disable-dict"
                           "--disable-telnet" "--disable-tftp" "--disable-pop3"
                           "--disable-imap" "--disable-smtp" "--disable-gopher"
-                          "--disable-file" "--disable-ftp")
+                          "--disable-file" "--disable-ftp" "--with-ca-path=/etc/ssl/certs/")
      #:test-target "test"
      #:parallel-tests? #f
      ;; We have to patch runtests.pl in tests/ directory
@@ -251,15 +253,17 @@ supports HTTPS, HTTPS and GnuTLS.")
            'check
            %standard-phases)))))
    (synopsis "Secure, decentralized, peer-to-peer networking framework")
-   (description
-    "GNUnet is a framework for secure peer-to-peer networking that does not
-use any centralized or otherwise trusted services.  Our high-level goal is to
-provide a strong free software foundation for a global network that provides
-security and privacy.  GNUnet started with an idea for anonymous
-censorship-resistant file-sharing, but has grown to incorporate other
-applications as well as many generic building blocks for secure networking
-applications.  In particular, GNUnet now includes the GNU Name System, a
-privacy-preserving, decentralized public key infrastructure.")
+   (description "GNUnet is a framework for secure, distributed, peer-to-peer
+networking.  The high-level goal is to provide a strong foundation of free
+software for a global, distributed network which provides security and
+privacy.  GNUnet in that sense aims to replace the current internet protocol
+stack.  Along with an application for secure publication of files, it has
+grown to include all kinds of basic applications for the foundation of a GNU
+internet.
+
+gnunet-0.10.1 is the last stable release candidate, however for
+development purposes and keeping up with latest changes, the SVN version
+might be preferable until a new version is released.")
    (license license:gpl3+)
    (home-page "https://gnunet.org/")))
 
@@ -313,7 +317,9 @@ services.")
     (arguments
      `(#:configure-flags
        (list "--without-libunique"
-             "--with-qrencode")))
+             "--with-qrencode"
+             (string-append "--with-gnunet="
+                            (assoc-ref %build-inputs "gnunet")))))
     (inputs
      `(("gnunet" ,gnunet)
        ("libgcrypt" ,libgcrypt)
@@ -324,4 +330,139 @@ services.")
     (native-inputs
      `(("pkg-config" ,pkg-config)
        ("libglade" ,libglade)))
-    (synopsis "Graphical front-end tools for GNUnet")))
+    (synopsis "Graphical front-end tools for GNUnet")
+    (home-page "https://gnunet.org")))
+
+;; We provide SVN in addition to the older 0.10.1 version,
+;; protocol and API compatibility will be broken when GNUnet bug #4165
+;; is fixed.
+(define-public gnunet-svn
+  (package
+    (name "gnunet-svn")
+    (version "0.10.1.svn36926")
+    (source
+     (origin
+       (method svn-fetch)
+       (uri (svn-reference
+             (url "https://gnunet.org/svn/gnunet/")
+             (revision 36926)))
+       (file-name (string-append name "-" version "-checkout"))
+       (sha256 (base32
+                "0wgmvxcazcws38zpky566rgssqbbmr72z96xdwia73vsy7ysy6h4"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("glpk" ,glpk)
+       ("gnurl" ,gnurl)
+       ("gstreamer" ,gstreamer)
+       ("gst-plugins-base" ,gst-plugins-base)
+       ("gnutls" ,gnutls)
+       ("libextractor" ,libextractor)
+       ("libgcrypt" ,libgcrypt)
+       ("libidn" ,libidn)
+       ("libmicrohttpd" ,libmicrohttpd)
+       ("libltdl" ,libltdl)
+       ("libunistring" ,libunistring)
+       ("openssl" ,openssl)
+       ("opus" ,opus)
+       ("pulseaudio" ,pulseaudio)
+       ("sqlite" ,sqlite)
+       ("zlib" ,zlib)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("autoconf" ,autoconf)
+       ("automake" ,automake)
+       ("gettext" ,gnu-gettext)
+       ("libtool" ,libtool)
+       ("python" ,python-2)))
+    (arguments
+     '(#:configure-flags
+       (list (string-append "--with-nssdir=" %output "/lib"))
+       #:parallel-tests? #f
+       ;; test_gnunet_service_arm fails; reported upstream
+       #:tests? #f
+       #:phases
+       ;; swap check and install phases and set paths to installed binaries
+       (alist-cons-after
+        'patch-bin-sh 'bootstrap
+        (lambda _ (zero? (system* (which "sh") "./bootstrap")))
+        (alist-cons-after
+         'unpack 'patch-bin-sh
+         (lambda _
+           (and
+            (substitute*
+                '("bootstrap")
+              (("contrib/pogen.sh") "sh contrib/pogen.sh"))
+            (for-each (lambda (f) (chmod f #o755))
+                      (find-files "po" ""))))
+         (alist-cons-before
+          'check 'set-path-for-check
+          (lambda* (#:key outputs #:allow-other-keys)
+            (let ((out (assoc-ref outputs "out")))
+              (setenv "GNUNET_PREFIX" (string-append out "/lib"))
+              (setenv "PATH" (string-append (getenv "PATH") ":" out "/bin"))))
+          (alist-cons-after
+           'install 'check
+           (assoc-ref %standard-phases 'check)
+           (alist-delete
+            'check
+            %standard-phases)))))))
+    (synopsis "Secure, decentralized, peer-to-peer networking framework")
+    (description "GNUnet is a framework for secure, distributed, peer-to-peer
+networking.  The high-level goal is to provide a strong foundation of free
+software for a global, distributed network which provides security and
+privacy.  GNUnet in that sense aims to replace the current internet protocol
+stack.  Along with an application for secure publication of files, it has
+grown to include all kinds of basic applications for the foundation of a GNU
+internet.
+
+gnunet-0.10.1 is the last stable release candidate, however for
+development purposes and keeping up with latest changes, the SVN version
+might be preferable until a new version is released.")
+    (license license:gpl3+)
+    (home-page "https://gnunet.org/")))
+
+;; current WM related bug being traced:
+;; #22985: using gnune-gtk with ratpoison (gnunet-fs in -gtk
+;; nonfunctional) -> needs participation and input)
+(define-public gnunet-gtk-svn
+  (package
+    (inherit gnunet-svn)
+    (name "gnunet-gtk-svn")
+    (version (package-version gnunet-svn))
+    (source
+     (origin
+       (method svn-fetch)
+       (uri (svn-reference
+             (url "https://gnunet.org/svn/gnunet-gtk/")
+             (revision 36926)))
+       (file-name (string-append name "-" version "-checkout"))
+       (sha256 (base32
+                "0kbxgfv08kh69vcrkvm23d2vggyww48h9cvgw4gdfs3i146zkfqb"))))
+    (arguments
+     `(#:configure-flags
+       (list "--without-libunique"
+             "--with-qrencode"
+             (string-append "--with-gnunet="
+                            (assoc-ref %build-inputs "gnunet-svn")))
+       #:phases (modify-phases %standard-phases
+                  (add-before 'configure 'bootstrap
+                    (lambda _
+                      (zero? (system* "autoreconf" "-vfi")))))))
+    (inputs
+     `(("gnunet-svn" ,gnunet-svn)
+       ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
+       ("gnutls" ,gnutls)
+       ("libgcrypt" ,libgcrypt)
+       ("gtk+" ,gtk+)
+       ("libextractor" ,libextractor)
+       ("glade3" ,glade3)
+       ("qrencode" ,qrencode)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("libglade" ,libglade)
+       ("autoconf" ,autoconf)
+       ("gettext" ,gnu-gettext)
+       ("automake" ,automake)
+       ("libtool" ,libtool)))
+    (synopsis "Graphical front-end tools for GNUnet")
+    (home-page "https://gnunet.org")))
-- 
2.6.3


[-- Attachment #3: Type: text/plain, Size: 137 bytes --]


thanks for your patience and reading,
-- 
ng
personal contact: http://krosos.sdf.org
EDN: https://wiki.c3d2.de/Echt_Dezentrales_Netz/en

Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl)

[Ludovic Courtès]

Nils Gillmann <niasterisk@grrlz.net> skribis:

> +gnunet-0.10.1 is the last stable release candidate, however for
> +development purposes and keeping up with latest changes, the SVN version
> +might be preferable until a new version is released.")

[...]

> +;; We provide SVN in addition to the older 0.10.1 version,
> +;; protocol and API compatibility will be broken when GNUnet bug #4165
> +;; is fixed.
> +(define-public gnunet-svn
> +  (package
> +    (name "gnunet-svn")
> +    (version "0.10.1.svn36926")

We avoid packaging unreleased software.  Could you instead lobby for a
new GNUnet release?  :-)  I think it’s long overdue, especially given
API changes and networking incompatibilities.

Thanks,
Ludo’.

Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl)

[Nils Gillmann]

ludo@gnu.org (Ludovic Courtès) writes:

> Nils Gillmann <niasterisk@grrlz.net> skribis:
>
>> +gnunet-0.10.1 is the last stable release candidate, however for
>> +development purposes and keeping up with latest changes, the SVN version
>> +might be preferable until a new version is released.")
>
> [...]
>
>> +;; We provide SVN in addition to the older 0.10.1 version,
>> +;; protocol and API compatibility will be broken when GNUnet bug #4165
>> +;; is fixed.
>> +(define-public gnunet-svn
>> +  (package
>> +    (name "gnunet-svn")
>> +    (version "0.10.1.svn36926")
>
> We avoid packaging unreleased software.  Could you instead lobby for a
> new GNUnet release?  :-)  I think it’s long overdue, especially given
> API changes and networking incompatibilities.
>
> Thanks,
> Ludo’.
>
>

In this case I have to disagree.
I would if I could, but I had a conversation with Christian about
it*. The most useable GNUnet right now for us is the SVN
checkout.
See this thread for more, iirc I explained it there:
6.6k│O  │=> gmane.comp.gnu.guix.║  ●  addresses: works around gnunet-gtk, gnunet, attention push for powwow, un-font, general question

You can of course use gnunet-0.10.1 but this includes all the
bad, outdated parts. It's an in-development network and I see no
reason why we should not package a more recent version when
there's also the 0.10.1 version still around.
I named it -svn for a reason to not force svn on people. If you
yourself decide to use the svn version, then you can do it. There
are significant differences and it is stable enough.
Jookia, another person Jookia knows, and myself tested this
specific checkout, and I will do so for updated numbers of
checkouts when/if I should change the package.

From my perspective I want people to have a good experience of
trying out (that's the way you should put it at this stage with
this gnunet-setup and no applications like SecuShare being ready)
the GNUnet. You experience will be outdated with 0.10.1, and
every distro which packages GNUnet has version numbered releases
and svn checkouts.
Once the next release number is out, I will package it.


*This is most of his reply:

I'm glad to hear that SVN HEAD fixes the issue(s), and yes 0.10.1 had a
number of rather annoying bugs, which didn't quite increase my fancy to
make another premature release, as you can imagine.

In terms of a "stable" SVN version, as you probably know the CADET
issues have been around for a while, and I'm not aware of one that
totally had no known CADET issue in it -- one of the main reasons for
there not being a release for a while.

The other issue may be protocol compatibility, and here a major sticking
point is:
https://gnunet.org/bugs/view.php?id=4165

which, when we fix it, will break protocol *and* API compatibility. I
could probably address this one in 1 day, but I want to see the CADET
bugs fixed before possibly introducing new ones ;-).

Other than #4165 and the known 'crash' issues, most recent SVN revision
numbers are reasonable for a "SVN package".





-- 
ng
personal contact: http://krosos.sdf.org
EDN: https://wiki.c3d2.de/Echt_Dezentrales_Netz/en

Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl)

[Ludovic Courtès]

Nils Gillmann <niasterisk@grrlz.net> skribis:

> In this case I have to disagree.
> I would if I could, but I had a conversation with Christian about
> it*. The most useable GNUnet right now for us is the SVN

[...]

> From my perspective I want people to have a good experience of
> trying out (that's the way you should put it at this stage with
> this gnunet-setup and no applications like SecuShare being ready)
> the GNUnet. You experience will be outdated with 0.10.1,

Right, but my point is that it is up to GNUnet as a project to send
users the right message.  As a user, I expect to use releases rather
than pick an arbitrary commit.

As a distro, our job is not to choose the commit that will give users “a
good experience”; this is upstream’s job.

IOW, we must tweak Christian et al. into making a new release.  :-)


Now, it’s not the end of the world if we provide a development snapshot
of GNUnet, and it’s a win if people find it useful.  But we must keep in
mind that this is an exception.

Does that make sense?

Ludo’.

Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl)

[Nils Gillmann]

ludo@gnu.org (Ludovic Courtès) writes:

> Nils Gillmann <niasterisk@grrlz.net> skribis:
>
>> In this case I have to disagree.
>> I would if I could, but I had a conversation with Christian about
>> it*. The most useable GNUnet right now for us is the SVN
>
> [...]
>
>> From my perspective I want people to have a good experience of
>> trying out (that's the way you should put it at this stage with
>> this gnunet-setup and no applications like SecuShare being ready)
>> the GNUnet. You experience will be outdated with 0.10.1,
>
> Right, but my point is that it is up to GNUnet as a project to send
> users the right message.  As a user, I expect to use releases rather
> than pick an arbitrary commit.

I see nothing arbitrary in tested SVN commit numbers, but I get
your point.

> As a distro, our job is not to choose the commit that will give users “a
> good experience”; this is upstream’s job.

I am more involved with talking, providing ideas to subprojects
and changing public appearance etc and not with coding so much,
so I leave that to people more involved in GNUnet coding.

> IOW, we must tweak Christian et al. into making a new release.  :-)

Which should be clear from the threads I mentioned which contain
the longer explanations, that it is a matter of some
bugfixes. Anyone reading this thread and feeling comfortable with
hacking on GNUnet and fixing the bug would be very welcome.

> Now, it’s not the end of the world if we provide a development snapshot
> of GNUnet, and it’s a win if people find it useful.  But we must keep in
> mind that this is an exception.

Of course, I don't see this as a regular way of working around
issues, but it's an issue I want to work around this way.

> Does that make sense?
>
> Ludo’.

thanks,
-- 
ng
personal contact: http://krosos.sdf.org
EDN: https://wiki.c3d2.de/EDN

Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl)

[Nils Gillmann]

This is a post to bump this thread into attention again.

If it is on anyones test list or if anyone new wants to test and
report, please contribute to this thread.

Jookia had test results, so I CC you and hope you can contribute
the results.
-- 
ng
personal contact: http://krosos.sdf.org
EDN: https://wiki.c3d2.de/EDN

Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl)

[Nils Gillmann]

Forwarded because nntp+email in my Gnus apparently splits
threads. Seems like I have to switch back to email for guix-devel
if I CC people.


From: Jookia <166291@gmail.com>
Subject: Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl)
To: Nils Gillmann <niasterisk@grrlz.net>
Date: Wed, 23 Mar 2016 20:10:46 +0100

On Tue, Mar 22, 2016 at 12:31:37PM +0100, Nils Gillmann wrote:
> Jookia had test results, so I CC you and hope you can contribute
> the results.

Hey,

On Xfce I have no black dialogs and it works fine. The only thing that really
bothers me is that gnunet-gtk doesn't have a desktop icon (this may be an
upstream issue), and as others have shown in errors, gnunet-vpn isn't suid so it
needs a wrapper, or instructions on how to add a wrapper. Not sure which is more
secure. Overall, looks good to me!

Cheers,
Jookia.

-- 
ng
personal contact: http://krosos.sdf.org
EDN: https://wiki.c3d2.de/EDN

Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl)

[Nils Gillmann]

Could someone either:
- test this patchset,
- tell me they are on their watchlist,
- or tell me that I should resubmit all of them individually
  because that's easier / quicker to test?


-- 
ng
personal contact: http://krosos.sdf.org
EDN: https://wiki.c3d2.de/EDN

[PATCH 1] gnurl (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Nils Gillmann]

[-- Attachment #1: Type: text/plain, Size: 126 bytes --]

As mentioned on irc:

To splitup this patch set, I'll send in various smaller patches
now which are based on current master.


[-- Attachment #2: 0001-gnu-gnurl-Build-with-ca-path.patch --]
[-- Type: text/x-patch, Size: 1581 bytes --]

From 3c86172695714d84f27886a9a34c4a13d1b9c06d Mon Sep 17 00:00:00 2001
From: Nils Gillmann <niasterisk@grrlz.net>
Date: Mon, 28 Mar 2016 17:11:46 +0200
Subject: [PATCH] gnu: gnurl: Build with ca path.

* gnu/packages/gnunet.scm (gnurl)[configure-flags]: Add --with-ca-path.

coauthored by Jookia.
---
 gnu/packages/gnunet.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
index eb0c4cb..5e5a609 100644
--- a/gnu/packages/gnunet.scm
+++ b/gnu/packages/gnunet.scm
@@ -3,8 +3,9 @@
 ;;; Copyright © 2014 Sree Harsha Totakura <sreeharsha@totakura.in>
 ;;; Copyright © 2015 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2015 Efraim Flashner <efraim@flashner.co.il>
-;;; Copyright © 2016 Ni* Gillmann <ng@niasterisk.space>
+;;; Copyright © 2016 Nils Gillmann <ng@niasterisk.space>
 ;;; Copyright © 2016 Ricardo Wurmus <rekado@elephly.net>
+;;; Copyright © 2016 Jookia <166291@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -178,7 +179,7 @@ and support for SSL3 and TLS.")
                           "--disable-ldap" "--disable-rtsp" "--disable-dict"
                           "--disable-telnet" "--disable-tftp" "--disable-pop3"
                           "--disable-imap" "--disable-smtp" "--disable-gopher"
-                          "--disable-file" "--disable-ftp")
+                          "--disable-file" "--disable-ftp" "--with-ca-path=/etc/ssl/certs/")
      #:test-target "test"
      #:parallel-tests? #f
      ;; We have to patch runtests.pl in tests/ directory
-- 
2.7.3


[-- Attachment #3: Type: text/plain, Size: 79 bytes --]



-- 
ng
personal contact: http://krosos.sdf.org
EDN: https://wiki.c3d2.de/EDN

[PATCH 2] gnunet: description (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Nils Gillmann]

[-- Attachment #1: Type: text/plain, Size: 62 bytes --]

rewrite of description, will soon be reflected on gnunet.org


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-gnunet-rewrite-description.patch --]
[-- Type: text/x-patch, Size: 2064 bytes --]

From 651d137ff4efff1a57fa23a4de524fabc3f6c911 Mon Sep 17 00:00:00 2001
From: Nils Gillmann <niasterisk@grrlz.net>
Date: Mon, 28 Mar 2016 17:34:34 +0200
Subject: [PATCH] gnu: gnunet: rewrite description

* gnu/packages/gnunet.scm (description): Rewrite to reflect changes.
---
 gnu/packages/gnunet.scm | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
index 5e5a609..9fe09a2 100644
--- a/gnu/packages/gnunet.scm
+++ b/gnu/packages/gnunet.scm
@@ -252,15 +252,17 @@ supports HTTPS, HTTPS and GnuTLS.")
            'check
            %standard-phases)))))
    (synopsis "Secure, decentralized, peer-to-peer networking framework")
-   (description
-    "GNUnet is a framework for secure peer-to-peer networking that does not
-use any centralized or otherwise trusted services.  Our high-level goal is to
-provide a strong free software foundation for a global network that provides
-security and privacy.  GNUnet started with an idea for anonymous
-censorship-resistant file-sharing, but has grown to incorporate other
-applications as well as many generic building blocks for secure networking
-applications.  In particular, GNUnet now includes the GNU Name System, a
-privacy-preserving, decentralized public key infrastructure.")
+   (description "GNUnet is a framework for secure, distributed, peer-to-peer
+networking.  The high-level goal is to provide a strong foundation of free
+software for a global, distributed network which provides security and
+privacy.  GNUnet in that sense aims to replace the current internet protocol
+stack.  Along with an application for secure publication of files, it has
+grown to include all kinds of basic applications for the foundation of a GNU
+internet.
+
+gnunet-0.10.1 is the last stable release candidate, however for
+development purposes and keeping up with latest changes, the SVN version
+might be preferable until a new version is released.")
    (license license:gpl3+)
    (home-page "https://gnunet.org/")))
 
-- 
2.7.3


[-- Attachment #3: Type: text/plain, Size: 78 bytes --]


-- 
ng
personal contact: http://krosos.sdf.org
EDN: https://wiki.c3d2.de/EDN

[PATCH 3] gnunet-gtk build-input, homepage (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Nils Gillmann]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-gnu-gnunet-gtk-Add-build-input-and-home-page.patch --]
[-- Type: text/x-patch, Size: 1214 bytes --]

From ee326257b613449ca5c0834f7e8f6b8d0840d486 Mon Sep 17 00:00:00 2001
From: Nils Gillmann <niasterisk@grrlz.net>
Date: Mon, 28 Mar 2016 17:49:27 +0200
Subject: [PATCH] gnu: gnunet-gtk: Add build-input and home-page.

* gnu/packages/gnunet.scm (gnunet-gtk)[configure-flags]: Add build-input gnunet.
[home-page]: New value.
---
 gnu/packages/gnunet.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
index 9fe09a2..9fa2773 100644
--- a/gnu/packages/gnunet.scm
+++ b/gnu/packages/gnunet.scm
@@ -316,7 +316,9 @@ services.")
     (arguments
      `(#:configure-flags
        (list "--without-libunique"
-             "--with-qrencode")))
+             "--with-qrencode"
+             (string-append "--with-gnunet="
+                            (assoc-ref %build-inputs "gnunet")))))
     (inputs
      `(("gnunet" ,gnunet)
        ("libgcrypt" ,libgcrypt)
@@ -327,4 +329,5 @@ services.")
     (native-inputs
      `(("pkg-config" ,pkg-config)
        ("libglade" ,libglade)))
-    (synopsis "Graphical front-end tools for GNUnet")))
+    (synopsis "Graphical front-end tools for GNUnet")
+    (home-page "https://gnunet.org")))
-- 
2.7.3


[-- Attachment #2: Type: text/plain, Size: 78 bytes --]


-- 
ng
personal contact: http://krosos.sdf.org
EDN: https://wiki.c3d2.de/EDN

[PATCH 3] gnunet-svn (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Nils Gillmann]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-gnu-gnunet-Add-gnunet-svn.patch --]
[-- Type: text/x-patch, Size: 4126 bytes --]

From 27eb23709f79a5383c66526e25f5cdf26b645793 Mon Sep 17 00:00:00 2001
From: Nils Gillmann <niasterisk@grrlz.net>
Date: Mon, 28 Mar 2016 18:00:27 +0200
Subject: [PATCH] gnu: gnunet: Add gnunet-svn.

* gnu/packages/gnunet.scm (gnunet-svn): New variable.
Coauthored by Jookia.
---
 gnu/packages/gnunet.scm | 88 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 88 insertions(+)

diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
index 9fa2773..fe6ca14 100644
--- a/gnu/packages/gnunet.scm
+++ b/gnu/packages/gnunet.scm
@@ -331,3 +331,91 @@ services.")
        ("libglade" ,libglade)))
     (synopsis "Graphical front-end tools for GNUnet")
     (home-page "https://gnunet.org")))
+
+;; We provide SVN in addition to the older 0.10.1 version,
+;; protocol and API compatibility will be broken when GNUnet bug #4165
+;; is fixed.
+(define-public gnunet-svn
+  (package
+    (name "gnunet-svn")
+    (version "0.10.1.svn36926")
+    (source
+     (origin
+       (method svn-fetch)
+       (uri (svn-reference
+             (url "https://gnunet.org/svn/gnunet/")
+             (revision 36926)))
+       (file-name (string-append name "-" version "-checkout"))
+       (sha256 (base32
+                "0wgmvxcazcws38zpky566rgssqbbmr72z96xdwia73vsy7ysy6h4"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("glpk" ,glpk)
+       ("gnurl" ,gnurl)
+       ("gstreamer" ,gstreamer)
+       ("gst-plugins-base" ,gst-plugins-base)
+       ("gnutls" ,gnutls)
+       ("libextractor" ,libextractor)
+       ("libgcrypt" ,libgcrypt)
+       ("libidn" ,libidn)
+       ("libmicrohttpd" ,libmicrohttpd)
+       ("libltdl" ,libltdl)
+       ("libunistring" ,libunistring)
+       ("openssl" ,openssl)
+       ("opus" ,opus)
+       ("pulseaudio" ,pulseaudio)
+       ("sqlite" ,sqlite)
+       ("zlib" ,zlib)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("autoconf" ,autoconf)
+       ("automake" ,automake)
+       ("gettext" ,gnu-gettext)
+       ("libtool" ,libtool)
+       ("python" ,python-2)))
+    (arguments
+     '(#:configure-flags
+       (list (string-append "--with-nssdir=" %output "/lib"))
+       #:parallel-tests? #f
+       ;; test_gnunet_service_arm fails; reported upstream
+       #:tests? #f
+       #:phases
+       ;; swap check and install phases and set paths to installed binaries
+       (alist-cons-after
+        'patch-bin-sh 'bootstrap
+        (lambda _ (zero? (system* (which "sh") "./bootstrap")))
+        (alist-cons-after
+         'unpack 'patch-bin-sh
+         (lambda _
+           (and
+            (substitute*
+                '("bootstrap")
+              (("contrib/pogen.sh") "sh contrib/pogen.sh"))
+            (for-each (lambda (f) (chmod f #o755))
+                      (find-files "po" ""))))
+         (alist-cons-before
+          'check 'set-path-for-check
+          (lambda* (#:key outputs #:allow-other-keys)
+            (let ((out (assoc-ref outputs "out")))
+              (setenv "GNUNET_PREFIX" (string-append out "/lib"))
+              (setenv "PATH" (string-append (getenv "PATH") ":" out "/bin"))))
+          (alist-cons-after
+           'install 'check
+           (assoc-ref %standard-phases 'check)
+           (alist-delete
+            'check
+            %standard-phases)))))))
+    (synopsis "Secure, decentralized, peer-to-peer networking framework")
+    (description "GNUnet is a framework for secure, distributed, peer-to-peer
+networking.  The high-level goal is to provide a strong foundation of free
+software for a global, distributed network which provides security and
+privacy.  GNUnet in that sense aims to replace the current internet protocol
+stack.  Along with an application for secure publication of files, it has
+grown to include all kinds of basic applications for the foundation of a GNU
+internet.
+
+gnunet-0.10.1 is the last stable release candidate, however for
+development purposes and keeping up with latest changes, the SVN version
+might be preferable until a new version is released.")
+    (license license:gpl3+)
+    (home-page "https://gnunet.org/")))
-- 
2.7.3


[-- Attachment #2: Type: text/plain, Size: 77 bytes --]


--
ng
personal contact: http://krosos.sdf.org
EDN: https://wiki.c3d2.de/EDN

[PATCH 4] gnunet-gtk-svn (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Nils Gillmann]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-gnu-Add-gnunet-gtk-svn.patch --]
[-- Type: text/x-patch, Size: 2439 bytes --]

From 4633dc3484390fa6e399084336e73879066b1760 Mon Sep 17 00:00:00 2001
From: Nils Gillmann <niasterisk@grrlz.net>
Date: Mon, 28 Mar 2016 18:10:12 +0200
Subject: [PATCH] gnu: Add gnunet-gtk-svn.

* gnu/packages/gnunet.scm (gnunet-gtk-svn): New variable.
Coauthored by Jookia.
---
 gnu/packages/gnunet.scm | 46 ++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
index fe6ca14..fa55179 100644
--- a/gnu/packages/gnunet.scm
+++ b/gnu/packages/gnunet.scm
@@ -419,3 +419,49 @@ development purposes and keeping up with latest changes, the SVN version
 might be preferable until a new version is released.")
     (license license:gpl3+)
     (home-page "https://gnunet.org/")))
+
+;; current WM related bug being traced:
+;; #22985: using gnune-gtk with ratpoison (gnunet-fs in -gtk
+;; nonfunctional) -> needs participation and input)
+(define-public gnunet-gtk-svn
+  (package
+    (inherit gnunet-svn)
+    (name "gnunet-gtk-svn")
+    (version (package-version gnunet-svn))
+    (source
+     (origin
+       (method svn-fetch)
+       (uri (svn-reference
+             (url "https://gnunet.org/svn/gnunet-gtk/")
+             (revision 36926)))
+       (file-name (string-append name "-" version "-checkout"))
+       (sha256 (base32
+                "0kbxgfv08kh69vcrkvm23d2vggyww48h9cvgw4gdfs3i146zkfqb"))))
+    (arguments
+     `(#:configure-flags
+       (list "--without-libunique"
+             "--with-qrencode"
+             (string-append "--with-gnunet="
+                            (assoc-ref %build-inputs "gnunet-svn")))
+       #:phases (modify-phases %standard-phases
+                  (add-before 'configure 'bootstrap
+                    (lambda _
+                      (zero? (system* "autoreconf" "-vfi")))))))
+    (inputs
+     `(("gnunet-svn" ,gnunet-svn)
+       ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
+       ("gnutls" ,gnutls)
+       ("libgcrypt" ,libgcrypt)
+       ("gtk+" ,gtk+)
+       ("libextractor" ,libextractor)
+       ("glade3" ,glade3)
+       ("qrencode" ,qrencode)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("libglade" ,libglade)
+       ("autoconf" ,autoconf)
+       ("gettext" ,gnu-gettext)
+       ("automake" ,automake)
+       ("libtool" ,libtool)))
+    (synopsis "Graphical front-end tools for GNUnet")
+    (home-page "https://gnunet.org")))
-- 
2.7.3


[-- Attachment #2: Type: text/plain, Size: 78 bytes --]


-- 
ng
personal contact: http://krosos.sdf.org
EDN: https://wiki.c3d2.de/EDN

Re: [PATCH 1] gnurl (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Leo Famulari]

On Mon, Mar 28, 2016 at 05:23:45PM +0200, Nils Gillmann wrote:
> As mentioned on irc:
> 
> To splitup this patch set, I'll send in various smaller patches
> now which are based on current master.

Thank you! This is much easier to read.

> From 3c86172695714d84f27886a9a34c4a13d1b9c06d Mon Sep 17 00:00:00 2001
> From: Nils Gillmann <niasterisk@grrlz.net>
> Date: Mon, 28 Mar 2016 17:11:46 +0200
> Subject: [PATCH] gnu: gnurl: Build with ca path.
> 
> * gnu/packages/gnunet.scm (gnurl)[configure-flags]: Add --with-ca-path.
> 
> coauthored by Jookia.

This looks okay to me, assuming you tested it works, and the changed
line is less than 80 characters :)

Re: [PATCH 3] gnunet-gtk build-input, homepage (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Leo Famulari]

On Mon, Mar 28, 2016 at 05:57:50PM +0200, Nils Gillmann wrote:
> From ee326257b613449ca5c0834f7e8f6b8d0840d486 Mon Sep 17 00:00:00 2001
> From: Nils Gillmann <niasterisk@grrlz.net>
> Date: Mon, 28 Mar 2016 17:49:27 +0200
> Subject: [PATCH] gnu: gnunet-gtk: Add build-input and home-page.

Can you split this into two patches?

> 
> * gnu/packages/gnunet.scm (gnunet-gtk)[configure-flags]: Add build-input gnunet.
> [home-page]: New value.
> ---
>  gnu/packages/gnunet.scm | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
> index 9fe09a2..9fa2773 100644
> --- a/gnu/packages/gnunet.scm
> +++ b/gnu/packages/gnunet.scm
> @@ -316,7 +316,9 @@ services.")
>      (arguments
>       `(#:configure-flags
>         (list "--without-libunique"
> -             "--with-qrencode")))
> +             "--with-qrencode"
> +             (string-append "--with-gnunet="
> +                            (assoc-ref %build-inputs "gnunet")))))
>      (inputs
>       `(("gnunet" ,gnunet)
>         ("libgcrypt" ,libgcrypt)
> @@ -327,4 +329,5 @@ services.")
>      (native-inputs
>       `(("pkg-config" ,pkg-config)
>         ("libglade" ,libglade)))
> -    (synopsis "Graphical front-end tools for GNUnet")))
> +    (synopsis "Graphical front-end tools for GNUnet")
> +    (home-page "https://gnunet.org")))
> -- 
> 2.7.3
> 

> 
> -- 
> ng
> personal contact: http://krosos.sdf.org
> EDN: https://wiki.c3d2.de/EDN

Re: [PATCH 3] gnunet-svn (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Leo Famulari]

On Mon, Mar 28, 2016 at 06:07:24PM +0200, Nils Gillmann wrote:
> From 27eb23709f79a5383c66526e25f5cdf26b645793 Mon Sep 17 00:00:00 2001
> From: Nils Gillmann <niasterisk@grrlz.net>
> Date: Mon, 28 Mar 2016 18:00:27 +0200
> Subject: [PATCH] gnu: gnunet: Add gnunet-svn.
> 
> * gnu/packages/gnunet.scm (gnunet-svn): New variable.
> Coauthored by Jookia.
> ---
>  gnu/packages/gnunet.scm | 88 +++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 88 insertions(+)
> 
> diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
> index 9fa2773..fe6ca14 100644
> --- a/gnu/packages/gnunet.scm
> +++ b/gnu/packages/gnunet.scm
> @@ -331,3 +331,91 @@ services.")
>         ("libglade" ,libglade)))
>      (synopsis "Graphical front-end tools for GNUnet")
>      (home-page "https://gnunet.org")))
> +
> +;; We provide SVN in addition to the older 0.10.1 version,
> +;; protocol and API compatibility will be broken when GNUnet bug #4165
> +;; is fixed.
> +(define-public gnunet-svn
> +  (package
> +    (name "gnunet-svn")
> +    (version "0.10.1.svn36926")
> +    (source
> +     (origin
> +       (method svn-fetch)
> +       (uri (svn-reference
> +             (url "https://gnunet.org/svn/gnunet/")
> +             (revision 36926)))

Are SVN identifiers really that short, or is there a longer version that
we should use, as for Git?

> +       (file-name (string-append name "-" version "-checkout"))
> +       (sha256 (base32
> +                "0wgmvxcazcws38zpky566rgssqbbmr72z96xdwia73vsy7ysy6h4"))))
> +    (build-system gnu-build-system)
> +    (inputs
> +     `(("glpk" ,glpk)
> +       ("gnurl" ,gnurl)
> +       ("gstreamer" ,gstreamer)
> +       ("gst-plugins-base" ,gst-plugins-base)
> +       ("gnutls" ,gnutls)
> +       ("libextractor" ,libextractor)
> +       ("libgcrypt" ,libgcrypt)
> +       ("libidn" ,libidn)
> +       ("libmicrohttpd" ,libmicrohttpd)
> +       ("libltdl" ,libltdl)
> +       ("libunistring" ,libunistring)
> +       ("openssl" ,openssl)
> +       ("opus" ,opus)
> +       ("pulseaudio" ,pulseaudio)
> +       ("sqlite" ,sqlite)
> +       ("zlib" ,zlib)))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ("gettext" ,gnu-gettext)
> +       ("libtool" ,libtool)
> +       ("python" ,python-2)))

It only needs python while building?

> +    (arguments
> +     '(#:configure-flags
> +       (list (string-append "--with-nssdir=" %output "/lib"))

It needs help referring to its own output?

> +       #:parallel-tests? #f
> +       ;; test_gnunet_service_arm fails; reported upstream
> +       #:tests? #f

Okay, is it easy to disable just the failing test? Also, can you include
a link to the upstream bug report in this comment?

> +       #:phases

Can you rewrite using the modify-phases syntax?

> +       ;; swap check and install phases and set paths to installed binaries
> +       (alist-cons-after
> +        'patch-bin-sh 'bootstrap
> +        (lambda _ (zero? (system* (which "sh") "./bootstrap")))
> +        (alist-cons-after
> +         'unpack 'patch-bin-sh
> +         (lambda _
> +           (and
> +            (substitute*
> +                '("bootstrap")
> +              (("contrib/pogen.sh") "sh contrib/pogen.sh"))
> +            (for-each (lambda (f) (chmod f #o755))
> +                      (find-files "po" ""))))

Unfortunately, I don't know very much about the translations system.
Hopefully somebody will weigh in on this.

> +         (alist-cons-before
> +          'check 'set-path-for-check
> +          (lambda* (#:key outputs #:allow-other-keys)
> +            (let ((out (assoc-ref outputs "out")))
> +              (setenv "GNUNET_PREFIX" (string-append out "/lib"))
> +              (setenv "PATH" (string-append (getenv "PATH") ":" out "/bin"))))
> +          (alist-cons-after
> +           'install 'check
> +           (assoc-ref %standard-phases 'check)
> +           (alist-delete
> +            'check
> +            %standard-phases)))))))
> +    (synopsis "Secure, decentralized, peer-to-peer networking framework")
> +    (description "GNUnet is a framework for secure, distributed, peer-to-peer
> +networking.  The high-level goal is to provide a strong foundation of free
> +software for a global, distributed network which provides security and
> +privacy.  GNUnet in that sense aims to replace the current internet protocol
> +stack.  Along with an application for secure publication of files, it has
> +grown to include all kinds of basic applications for the foundation of a GNU
> +internet.
> +
> +gnunet-0.10.1 is the last stable release candidate, however for
> +development purposes and keeping up with latest changes, the SVN version
> +might be preferable until a new version is released.")

I don't know whether it's better to put this sort of information in the
description or a code comment, as above. But I think it should only be
in one place.

> +    (license license:gpl3+)
> +    (home-page "https://gnunet.org/")))

Re: [PATCH 4] gnunet-gtk-svn (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Leo Famulari]

On Mon, Mar 28, 2016 at 06:17:05PM +0200, Nils Gillmann wrote:
> From 4633dc3484390fa6e399084336e73879066b1760 Mon Sep 17 00:00:00 2001
> From: Nils Gillmann <niasterisk@grrlz.net>
> Date: Mon, 28 Mar 2016 18:10:12 +0200
> Subject: [PATCH] gnu: Add gnunet-gtk-svn.
> 
> * gnu/packages/gnunet.scm (gnunet-gtk-svn): New variable.
> Coauthored by Jookia.
> ---
>  gnu/packages/gnunet.scm | 46 ++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 46 insertions(+)
> 
> diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
> index fe6ca14..fa55179 100644
> --- a/gnu/packages/gnunet.scm
> +++ b/gnu/packages/gnunet.scm
> @@ -419,3 +419,49 @@ development purposes and keeping up with latest changes, the SVN version
>  might be preferable until a new version is released.")
>      (license license:gpl3+)
>      (home-page "https://gnunet.org/")))
> +
> +;; current WM related bug being traced:

s/traced/tracked

> +;; #22985: using gnune-gtk with ratpoison (gnunet-fs in -gtk
> +;; nonfunctional) -> needs participation and input)
> +(define-public gnunet-gtk-svn
> +  (package
> +    (inherit gnunet-svn)
> +    (name "gnunet-gtk-svn")
> +    (version (package-version gnunet-svn))
> +    (source
> +     (origin
> +       (method svn-fetch)
> +       (uri (svn-reference
> +             (url "https://gnunet.org/svn/gnunet-gtk/")
> +             (revision 36926)))

Same question as before about the length of the SVN identifier.

> +       (file-name (string-append name "-" version "-checkout"))
> +       (sha256 (base32
> +                "0kbxgfv08kh69vcrkvm23d2vggyww48h9cvgw4gdfs3i146zkfqb"))))
> +    (arguments
> +     `(#:configure-flags
> +       (list "--without-libunique"

Can you say why this is disabled?

> +             "--with-qrencode"
> +             (string-append "--with-gnunet="
> +                            (assoc-ref %build-inputs "gnunet-svn")))
> +       #:phases (modify-phases %standard-phases
> +                  (add-before 'configure 'bootstrap
> +                    (lambda _
> +                      (zero? (system* "autoreconf" "-vfi")))))))
> +    (inputs
> +     `(("gnunet-svn" ,gnunet-svn)
> +       ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
> +       ("gnutls" ,gnutls)
> +       ("libgcrypt" ,libgcrypt)
> +       ("gtk+" ,gtk+)
> +       ("libextractor" ,libextractor)
> +       ("glade3" ,glade3)
> +       ("qrencode" ,qrencode)))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("libglade" ,libglade)
> +       ("autoconf" ,autoconf)
> +       ("gettext" ,gnu-gettext)
> +       ("automake" ,automake)
> +       ("libtool" ,libtool)))
> +    (synopsis "Graphical front-end tools for GNUnet")
> +    (home-page "https://gnunet.org")))
> -- 
> 2.7.3
> 

> 
> -- 
> ng
> personal contact: http://krosos.sdf.org
> EDN: https://wiki.c3d2.de/EDN

Re: [PATCH 2] gnunet: description (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Leo Famulari]

On Mon, Mar 28, 2016 at 05:43:52PM +0200, Nils Gillmann wrote:
> rewrite of description, will soon be reflected on gnunet.org
> 

> From 651d137ff4efff1a57fa23a4de524fabc3f6c911 Mon Sep 17 00:00:00 2001
> From: Nils Gillmann <niasterisk@grrlz.net>
> Date: Mon, 28 Mar 2016 17:34:34 +0200
> Subject: [PATCH] gnu: gnunet: rewrite description

"rewrite description" should be a complete sentence (capitalization and
punctuation). I can fix that when I commit the patch, but I wanted to
let you know :)

> 
> * gnu/packages/gnunet.scm (description): Rewrite to reflect changes.
> ---
>  gnu/packages/gnunet.scm | 20 +++++++++++---------
>  1 file changed, 11 insertions(+), 9 deletions(-)
> 
> diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
> index 5e5a609..9fe09a2 100644
> --- a/gnu/packages/gnunet.scm
> +++ b/gnu/packages/gnunet.scm
> @@ -252,15 +252,17 @@ supports HTTPS, HTTPS and GnuTLS.")
>             'check
>             %standard-phases)))))
>     (synopsis "Secure, decentralized, peer-to-peer networking framework")
> -   (description
> -    "GNUnet is a framework for secure peer-to-peer networking that does not
> -use any centralized or otherwise trusted services.  Our high-level goal is to
> -provide a strong free software foundation for a global network that provides
> -security and privacy.  GNUnet started with an idea for anonymous
> -censorship-resistant file-sharing, but has grown to incorporate other
> -applications as well as many generic building blocks for secure networking
> -applications.  In particular, GNUnet now includes the GNU Name System, a
> -privacy-preserving, decentralized public key infrastructure.")
> +   (description "GNUnet is a framework for secure, distributed, peer-to-peer
> +networking.  The high-level goal is to provide a strong foundation of free
> +software for a global, distributed network which provides security and
> +privacy.  GNUnet in that sense aims to replace the current internet protocol
> +stack.  Along with an application for secure publication of files, it has
> +grown to include all kinds of basic applications for the foundation of a GNU
> +internet.
> +
> +gnunet-0.10.1 is the last stable release candidate, however for
> +development purposes and keeping up with latest changes, the SVN version
> +might be preferable until a new version is released.")

Do we have a consensus on how to handle this sort of "Guix metadata"?



>     (license license:gpl3+)
>     (home-page "https://gnunet.org/")))
>  
> -- 
> 2.7.3
> 

> 
> -- 
> ng
> personal contact: http://krosos.sdf.org
> EDN: https://wiki.c3d2.de/EDN

Re: [PATCH 1] gnurl (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Nils Gillmann]

Leo Famulari <leo@famulari.name> writes:

> On Mon, Mar 28, 2016 at 05:23:45PM +0200, Nils Gillmann wrote:
>> As mentioned on irc:
>> 
>> To splitup this patch set, I'll send in various smaller patches
>> now which are based on current master.
>
> Thank you! This is much easier to read.
>
>> From 3c86172695714d84f27886a9a34c4a13d1b9c06d Mon Sep 17 00:00:00 2001
>> From: Nils Gillmann <niasterisk@grrlz.net>
>> Date: Mon, 28 Mar 2016 17:11:46 +0200
>> Subject: [PATCH] gnu: gnurl: Build with ca path.
>> 
>> * gnu/packages/gnunet.scm (gnurl)[configure-flags]: Add --with-ca-path.
>> 
>> coauthored by Jookia.
>
> This looks okay to me, assuming you tested it works, and the changed
> line is less than 80 characters :)

There has been no change in the patches since I first submitted
this, so it should work.

However it should be something like
+                          "--disable-file" "--disable-ftp")
;;the above is the last line of the origina, below is what I
added.
                           ("--with-ca-path=/etc/ssl/certs/")

then, I did not watch the line length.



-- 
ng
personal contact: http://krosos.sdf.org
EDN: https://wiki.c3d2.de/EDN

Re: [PATCH 2] gnunet: description (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Nils Gillmann]

Leo Famulari <leo@famulari.name> writes:

> On Mon, Mar 28, 2016 at 05:43:52PM +0200, Nils Gillmann wrote:
>> rewrite of description, will soon be reflected on gnunet.org
>> 
>
>> From 651d137ff4efff1a57fa23a4de524fabc3f6c911 Mon Sep 17 00:00:00 2001
>> From: Nils Gillmann <niasterisk@grrlz.net>
>> Date: Mon, 28 Mar 2016 17:34:34 +0200
>> Subject: [PATCH] gnu: gnunet: rewrite description
>
> "rewrite description" should be a complete sentence (capitalization and
> punctuation). I can fix that when I commit the patch, but I wanted to
> let you know :)
>
>> 
>> * gnu/packages/gnunet.scm (description): Rewrite to reflect changes.
>> ---
>>  gnu/packages/gnunet.scm | 20 +++++++++++---------
>>  1 file changed, 11 insertions(+), 9 deletions(-)
>> 
>> diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
>> index 5e5a609..9fe09a2 100644
>> --- a/gnu/packages/gnunet.scm
>> +++ b/gnu/packages/gnunet.scm
>> @@ -252,15 +252,17 @@ supports HTTPS, HTTPS and GnuTLS.")
>>             'check
>>             %standard-phases)))))
>>     (synopsis "Secure, decentralized, peer-to-peer networking framework")
>> -   (description
>> -    "GNUnet is a framework for secure peer-to-peer networking that does not
>> -use any centralized or otherwise trusted services.  Our high-level goal is to
>> -provide a strong free software foundation for a global network that provides
>> -security and privacy.  GNUnet started with an idea for anonymous
>> -censorship-resistant file-sharing, but has grown to incorporate other
>> -applications as well as many generic building blocks for secure networking
>> -applications.  In particular, GNUnet now includes the GNU Name System, a
>> -privacy-preserving, decentralized public key infrastructure.")
>> +   (description "GNUnet is a framework for secure, distributed, peer-to-peer
>> +networking.  The high-level goal is to provide a strong foundation of free
>> +software for a global, distributed network which provides security and
>> +privacy.  GNUnet in that sense aims to replace the current internet protocol
>> +stack.  Along with an application for secure publication of files, it has
>> +grown to include all kinds of basic applications for the foundation of a GNU
>> +internet.
>> +
>> +gnunet-0.10.1 is the last stable release candidate, however for
>> +development purposes and keeping up with latest changes, the SVN version
>> +might be preferable until a new version is released.")
>
> Do we have a consensus on how to handle this sort of "Guix metadata"?

Which metadata do you refer to here?

The description is good with the GNUnet project, talked about it
with others involved in GNUnet.

>
>
>>     (license license:gpl3+)
>>     (home-page "https://gnunet.org/")))
>>  
>> -- 
>> 2.7.3
>> 
>
>> 
>> -- 
>> ng
>> personal contact: http://krosos.sdf.org
>> EDN: https://wiki.c3d2.de/EDN
>
>
>

-- 
ng
personal contact: http://krosos.sdf.org
EDN: https://wiki.c3d2.de/EDN

Re: [PATCH 3] gnunet-gtk build-input, homepage (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Nils Gillmann]

Leo Famulari <leo@famulari.name> writes:

> On Mon, Mar 28, 2016 at 05:57:50PM +0200, Nils Gillmann wrote:
>> From ee326257b613449ca5c0834f7e8f6b8d0840d486 Mon Sep 17 00:00:00 2001
>> From: Nils Gillmann <niasterisk@grrlz.net>
>> Date: Mon, 28 Mar 2016 17:49:27 +0200
>> Subject: [PATCH] gnu: gnunet-gtk: Add build-input and home-page.
>
> Can you split this into two patches?

I can, but why should I? Because it's two kinds of changes? I see
different grouped changes everywhere in the commit logs.

>> 
>> * gnu/packages/gnunet.scm (gnunet-gtk)[configure-flags]: Add build-input gnunet.
>> [home-page]: New value.
>> ---
>>  gnu/packages/gnunet.scm | 7 +++++--
>>  1 file changed, 5 insertions(+), 2 deletions(-)
>> 
>> diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
>> index 9fe09a2..9fa2773 100644
>> --- a/gnu/packages/gnunet.scm
>> +++ b/gnu/packages/gnunet.scm
>> @@ -316,7 +316,9 @@ services.")
>>      (arguments
>>       `(#:configure-flags
>>         (list "--without-libunique"
>> -             "--with-qrencode")))
>> +             "--with-qrencode"
>> +             (string-append "--with-gnunet="
>> +                            (assoc-ref %build-inputs "gnunet")))))
>>      (inputs
>>       `(("gnunet" ,gnunet)
>>         ("libgcrypt" ,libgcrypt)
>> @@ -327,4 +329,5 @@ services.")
>>      (native-inputs
>>       `(("pkg-config" ,pkg-config)
>>         ("libglade" ,libglade)))
>> -    (synopsis "Graphical front-end tools for GNUnet")))
>> +    (synopsis "Graphical front-end tools for GNUnet")
>> +    (home-page "https://gnunet.org")))
>> -- 
>> 2.7.3
>> 
>
>> 
>> -- 
>> ng
>> personal contact: http://krosos.sdf.org
>> EDN: https://wiki.c3d2.de/EDN
>
>
>

-- 
ng
personal contact: http://krosos.sdf.org
EDN: https://wiki.c3d2.de/EDN

Re: [PATCH 3] gnunet-svn (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Nils Gillmann]

Leo Famulari <leo@famulari.name> writes:

> On Mon, Mar 28, 2016 at 06:07:24PM +0200, Nils Gillmann wrote:
>> From 27eb23709f79a5383c66526e25f5cdf26b645793 Mon Sep 17 00:00:00 2001
>> From: Nils Gillmann <niasterisk@grrlz.net>
>> Date: Mon, 28 Mar 2016 18:00:27 +0200
>> Subject: [PATCH] gnu: gnunet: Add gnunet-svn.
>> 
>> * gnu/packages/gnunet.scm (gnunet-svn): New variable.
>> Coauthored by Jookia.
>> ---
>>  gnu/packages/gnunet.scm | 88 +++++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 88 insertions(+)
>> 
>> diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
>> index 9fa2773..fe6ca14 100644
>> --- a/gnu/packages/gnunet.scm
>> +++ b/gnu/packages/gnunet.scm
>> @@ -331,3 +331,91 @@ services.")
>>         ("libglade" ,libglade)))
>>      (synopsis "Graphical front-end tools for GNUnet")
>>      (home-page "https://gnunet.org")))
>> +
>> +;; We provide SVN in addition to the older 0.10.1 version,
>> +;; protocol and API compatibility will be broken when GNUnet bug #4165
>> +;; is fixed.
>> +(define-public gnunet-svn
>> +  (package
>> +    (name "gnunet-svn")
>> +    (version "0.10.1.svn36926")
>> +    (source
>> +     (origin
>> +       (method svn-fetch)
>> +       (uri (svn-reference
>> +             (url "https://gnunet.org/svn/gnunet/")
>> +             (revision 36926)))
>
> Are SVN identifiers really that short, or is there a longer version that
> we should use, as for Git?

I have no idea, I thought this was what we used for svn.
Most of the -svn is done by Jookia, i just fixed the way they
were arranged, named, described and some other fixes.

>
>> +       (file-name (string-append name "-" version "-checkout"))
>> +       (sha256 (base32
>> +                "0wgmvxcazcws38zpky566rgssqbbmr72z96xdwia73vsy7ysy6h4"))))
>> +    (build-system gnu-build-system)
>> +    (inputs
>> +     `(("glpk" ,glpk)
>> +       ("gnurl" ,gnurl)
>> +       ("gstreamer" ,gstreamer)
>> +       ("gst-plugins-base" ,gst-plugins-base)
>> +       ("gnutls" ,gnutls)
>> +       ("libextractor" ,libextractor)
>> +       ("libgcrypt" ,libgcrypt)
>> +       ("libidn" ,libidn)
>> +       ("libmicrohttpd" ,libmicrohttpd)
>> +       ("libltdl" ,libltdl)
>> +       ("libunistring" ,libunistring)
>> +       ("openssl" ,openssl)
>> +       ("opus" ,opus)
>> +       ("pulseaudio" ,pulseaudio)
>> +       ("sqlite" ,sqlite)
>> +       ("zlib" ,zlib)))
>> +    (native-inputs
>> +     `(("pkg-config" ,pkg-config)
>> +       ("autoconf" ,autoconf)
>> +       ("automake" ,automake)
>> +       ("gettext" ,gnu-gettext)
>> +       ("libtool" ,libtool)
>> +       ("python" ,python-2)))
>
> It only needs python while building?

Can you be more precise? I don't understand if this is a rhetoric
or actual question.

>> +    (arguments
>> +     '(#:configure-flags
>> +       (list (string-append "--with-nssdir=" %output "/lib"))
>
> It needs help referring to its own output?

Refer to Jookia, will ping Jookia later about this thread.

>> +       #:parallel-tests? #f
>> +       ;; test_gnunet_service_arm fails; reported upstream
>> +       #:tests? #f
>
> Okay, is it easy to disable just the failing test? Also, can you include
> a link to the upstream bug report in this comment?

I don't know which bugreport this refers to, waiting for comment
by Jookia.

>> +       #:phases
>
> Can you rewrite using the modify-phases syntax?

Okay.

>> +       ;; swap check and install phases and set paths to installed binaries
>> +       (alist-cons-after
>> +        'patch-bin-sh 'bootstrap
>> +        (lambda _ (zero? (system* (which "sh") "./bootstrap")))
>> +        (alist-cons-after
>> +         'unpack 'patch-bin-sh
>> +         (lambda _
>> +           (and
>> +            (substitute*
>> +                '("bootstrap")
>> +              (("contrib/pogen.sh") "sh contrib/pogen.sh"))
>> +            (for-each (lambda (f) (chmod f #o755))
>> +                      (find-files "po" ""))))
>
> Unfortunately, I don't know very much about the translations system.
> Hopefully somebody will weigh in on this.
>
>> +         (alist-cons-before
>> +          'check 'set-path-for-check
>> +          (lambda* (#:key outputs #:allow-other-keys)
>> +            (let ((out (assoc-ref outputs "out")))
>> +              (setenv "GNUNET_PREFIX" (string-append out "/lib"))
>> +              (setenv "PATH" (string-append (getenv "PATH") ":" out "/bin"))))
>> +          (alist-cons-after
>> +           'install 'check
>> +           (assoc-ref %standard-phases 'check)
>> +           (alist-delete
>> +            'check
>> +            %standard-phases)))))))
>> +    (synopsis "Secure, decentralized, peer-to-peer networking framework")
>> +    (description "GNUnet is a framework for secure, distributed, peer-to-peer
>> +networking.  The high-level goal is to provide a strong foundation of free
>> +software for a global, distributed network which provides security and
>> +privacy.  GNUnet in that sense aims to replace the current internet protocol
>> +stack.  Along with an application for secure publication of files, it has
>> +grown to include all kinds of basic applications for the foundation of a GNU
>> +internet.
>> +
>> +gnunet-0.10.1 is the last stable release candidate, however for
>> +development purposes and keeping up with latest changes, the SVN version
>> +might be preferable until a new version is released.")
>
> I don't know whether it's better to put this sort of information in the
> description or a code comment, as above. But I think it should only be
> in one place.

Why? gnunet-$version is the stable release, gnunet-svn is the svn
release. Both should carry information visible to users on why
there are different packages.

>> +    (license license:gpl3+)
>> +    (home-page "https://gnunet.org/")))
>
>

-- 
ng
personal contact: http://krosos.sdf.org
EDN: https://wiki.c3d2.de/EDN

Re: [PATCH 3] gnunet-svn (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Nils Gillmann]

Leo Famulari <leo@famulari.name> writes:

> On Mon, Mar 28, 2016 at 06:07:24PM +0200, Nils Gillmann wrote:
>> From 27eb23709f79a5383c66526e25f5cdf26b645793 Mon Sep 17 00:00:00 2001
>> From: Nils Gillmann <niasterisk@grrlz.net>
>> Date: Mon, 28 Mar 2016 18:00:27 +0200
>> Subject: [PATCH] gnu: gnunet: Add gnunet-svn.
>> 
>> * gnu/packages/gnunet.scm (gnunet-svn): New variable.
>> Coauthored by Jookia.
>> ---
>>  gnu/packages/gnunet.scm | 88 +++++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 88 insertions(+)
>> 
>> diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
>> index 9fa2773..fe6ca14 100644
>> --- a/gnu/packages/gnunet.scm
>> +++ b/gnu/packages/gnunet.scm
>> @@ -331,3 +331,91 @@ services.")
>>         ("libglade" ,libglade)))
>>      (synopsis "Graphical front-end tools for GNUnet")
>>      (home-page "https://gnunet.org")))
>> +
>> +;; We provide SVN in addition to the older 0.10.1 version,
>> +;; protocol and API compatibility will be broken when GNUnet bug #4165
>> +;; is fixed.
>> +(define-public gnunet-svn
>> +  (package
>> +    (name "gnunet-svn")
>> +    (version "0.10.1.svn36926")
>> +    (source
>> +     (origin
>> +       (method svn-fetch)
>> +       (uri (svn-reference
>> +             (url "https://gnunet.org/svn/gnunet/")
>> +             (revision 36926)))
>
> Are SVN identifiers really that short, or is there a longer version that
> we should use, as for Git?

If you refer to 
+             (revision 36926)))
then it is true, svn checkouts are only this long.

>> +       (file-name (string-append name "-" version "-checkout"))
>> +       (sha256 (base32
>> +                "0wgmvxcazcws38zpky566rgssqbbmr72z96xdwia73vsy7ysy6h4"))))
>> +    (build-system gnu-build-system)
>> +    (inputs
>> +     `(("glpk" ,glpk)
>> +       ("gnurl" ,gnurl)
>> +       ("gstreamer" ,gstreamer)
>> +       ("gst-plugins-base" ,gst-plugins-base)
>> +       ("gnutls" ,gnutls)
>> +       ("libextractor" ,libextractor)
>> +       ("libgcrypt" ,libgcrypt)
>> +       ("libidn" ,libidn)
>> +       ("libmicrohttpd" ,libmicrohttpd)
>> +       ("libltdl" ,libltdl)
>> +       ("libunistring" ,libunistring)
>> +       ("openssl" ,openssl)
>> +       ("opus" ,opus)
>> +       ("pulseaudio" ,pulseaudio)
>> +       ("sqlite" ,sqlite)
>> +       ("zlib" ,zlib)))
>> +    (native-inputs
>> +     `(("pkg-config" ,pkg-config)
>> +       ("autoconf" ,autoconf)
>> +       ("automake" ,automake)
>> +       ("gettext" ,gnu-gettext)
>> +       ("libtool" ,libtool)
>> +       ("python" ,python-2)))
>
> It only needs python while building?
>
>> +    (arguments
>> +     '(#:configure-flags
>> +       (list (string-append "--with-nssdir=" %output "/lib"))
>
> It needs help referring to its own output?
>
>> +       #:parallel-tests? #f
>> +       ;; test_gnunet_service_arm fails; reported upstream
>> +       #:tests? #f
>
> Okay, is it easy to disable just the failing test? Also, can you include
> a link to the upstream bug report in this comment?
>
>> +       #:phases
>
> Can you rewrite using the modify-phases syntax?
>
>> +       ;; swap check and install phases and set paths to installed binaries
>> +       (alist-cons-after
>> +        'patch-bin-sh 'bootstrap
>> +        (lambda _ (zero? (system* (which "sh") "./bootstrap")))
>> +        (alist-cons-after
>> +         'unpack 'patch-bin-sh
>> +         (lambda _
>> +           (and
>> +            (substitute*
>> +                '("bootstrap")
>> +              (("contrib/pogen.sh") "sh contrib/pogen.sh"))
>> +            (for-each (lambda (f) (chmod f #o755))
>> +                      (find-files "po" ""))))
>
> Unfortunately, I don't know very much about the translations system.
> Hopefully somebody will weigh in on this.
>
>> +         (alist-cons-before
>> +          'check 'set-path-for-check
>> +          (lambda* (#:key outputs #:allow-other-keys)
>> +            (let ((out (assoc-ref outputs "out")))
>> +              (setenv "GNUNET_PREFIX" (string-append out "/lib"))
>> +              (setenv "PATH" (string-append (getenv "PATH") ":" out "/bin"))))
>> +          (alist-cons-after
>> +           'install 'check
>> +           (assoc-ref %standard-phases 'check)
>> +           (alist-delete
>> +            'check
>> +            %standard-phases)))))))
>> +    (synopsis "Secure, decentralized, peer-to-peer networking framework")
>> +    (description "GNUnet is a framework for secure, distributed, peer-to-peer
>> +networking.  The high-level goal is to provide a strong foundation of free
>> +software for a global, distributed network which provides security and
>> +privacy.  GNUnet in that sense aims to replace the current internet protocol
>> +stack.  Along with an application for secure publication of files, it has
>> +grown to include all kinds of basic applications for the foundation of a GNU
>> +internet.
>> +
>> +gnunet-0.10.1 is the last stable release candidate, however for
>> +development purposes and keeping up with latest changes, the SVN version
>> +might be preferable until a new version is released.")
>
> I don't know whether it's better to put this sort of information in the
> description or a code comment, as above. But I think it should only be
> in one place.
>
>> +    (license license:gpl3+)
>> +    (home-page "https://gnunet.org/")))
>
>

-- 
ng
personal contact: http://krosos.sdf.org
EDN: https://wiki.c3d2.de/EDN

Re: [PATCH 3] gnunet-svn (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Jookia]

On Mon, Mar 28, 2016 at 07:49:48PM +0200, Nils Gillmann wrote:
> >> +;; We provide SVN in addition to the older 0.10.1 version,
> >> +;; protocol and API compatibility will be broken when GNUnet bug #4165
> >> +;; is fixed.
> >> +(define-public gnunet-svn
> >> +  (package
> >> +    (name "gnunet-svn")
> >> +    (version "0.10.1.svn36926")
> >> +    (source
> >> +     (origin
> >> +       (method svn-fetch)
> >> +       (uri (svn-reference
> >> +             (url "https://gnunet.org/svn/gnunet/")
> >> +             (revision 36926)))
> >
> > Are SVN identifiers really that short, or is there a longer version that
> > we should use, as for Git?
>
> I have no idea, I thought this was what we used for svn.
> Most of the -svn is done by Jookia, i just fixed the way they
> were arranged, named, described and some other fixes.

Apologies for not being on IRC, I'm currently away from my main machine so I"m
left with a decaying Arch Linux install that doesn't have an OpenVPN container.

Yes, SVN identifiers are really that short- they're the count of commits done to
the centralized repository. The reason this isn't a thing in Git is because of
decentralization, there'd be no way to keep a monotonic revision number with the
amount of branches and private repositories.

> >> +    (arguments
> >> +     '(#:configure-flags
> >> +       (list (string-append "--with-nssdir=" %output "/lib"))
> >
> > It needs help referring to its own output?
>
> Refer to Jookia, will ping Jookia later about this thread.
>
> >> +       #:parallel-tests? #f
> >> +       ;; test_gnunet_service_arm fails; reported upstream
> >> +       #:tests? #f
> >
> > Okay, is it easy to disable just the failing test? Also, can you include
> > a link to the upstream bug report in this comment?
>
> I don't know which bugreport this refers to, waiting for comment
> by Jookia.

So both of these flags are present in the original gnunet package. Perhaps it'd
be worth seeing if we can remove them in the case they're fied upstream.

> Why? gnunet-$version is the stable release, gnunet-svn is the svn
> release. Both should carry information visible to users on why
> there are different packages.

I'd have to agree with keeping this information, especially since the response
to many GNUnet problems is to "use the SVN version.", which is exactly what
people will find here. It's also useful Guix runs on foreign distributions so
people won't have to spend headaches getting it compiled.

Overall good patches, I'm glad there's a lot of interest and discussion here.
Nothing seems off to me, but those are famous last words and I haven't reviewed
the split patches yet, I'll put it on my 'I'll review it this week' list and
come back next month sometime with replies if it's not merged.

> -- 
> ng
> personal contact: http://krosos.sdf.org
> EDN: https://wiki.c3d2.de/EDN

Jookia.

Re: [PATCH 3] gnunet-svn (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Nils Gillmann]

Jookia <166291@gmail.com> writes:

> On Mon, Mar 28, 2016 at 07:49:48PM +0200, Nils Gillmann wrote:
>> >> +;; We provide SVN in addition to the older 0.10.1 version,
>> >> +;; protocol and API compatibility will be broken when GNUnet bug #4165
>> >> +;; is fixed.
>> >> +(define-public gnunet-svn
>> >> +  (package
>> >> +    (name "gnunet-svn")
>> >> +    (version "0.10.1.svn36926")
>> >> +    (source
>> >> +     (origin
>> >> +       (method svn-fetch)
>> >> +       (uri (svn-reference
>> >> +             (url "https://gnunet.org/svn/gnunet/")
>> >> +             (revision 36926)))
>> >
>> > Are SVN identifiers really that short, or is there a longer version that
>> > we should use, as for Git?
>>
>> I have no idea, I thought this was what we used for svn.
>> Most of the -svn is done by Jookia, i just fixed the way they
>> were arranged, named, described and some other fixes.
>
> Apologies for not being on IRC, I'm currently away from my main machine so I"m
> left with a decaying Arch Linux install that doesn't have an OpenVPN container.
>
> Yes, SVN identifiers are really that short- they're the count of commits done to
> the centralized repository. The reason this isn't a thing in Git is because of
> decentralization, there'd be no way to keep a monotonic revision number with the
> amount of branches and private repositories.
>
>> >> +    (arguments
>> >> +     '(#:configure-flags
>> >> +       (list (string-append "--with-nssdir=" %output "/lib"))
>> >
>> > It needs help referring to its own output?
>>
>> Refer to Jookia, will ping Jookia later about this thread.

I try a build without this, compare it to my own svn build on
gentoo and see if it's necessary.

>>
>> >> +       #:parallel-tests? #f
>> >> +       ;; test_gnunet_service_arm fails; reported upstream
>> >> +       #:tests? #f
>> >
>> > Okay, is it easy to disable just the failing test? Also, can you include
>> > a link to the upstream bug report in this comment?
>>
>> I don't know which bugreport this refers to, waiting for comment
>> by Jookia.
>
> So both of these flags are present in the original gnunet package. Perhaps it'd
> be worth seeing if we can remove them in the case they're fied upstream.

Thanks. I do appropriate changes later today and test build and
run the packages.

>> Why? gnunet-$version is the stable release, gnunet-svn is the svn
>> release. Both should carry information visible to users on why
>> there are different packages.
>
> I'd have to agree with keeping this information, especially since the response
> to many GNUnet problems is to "use the SVN version.", which is exactly what
> people will find here. It's also useful Guix runs on foreign distributions so
> people won't have to spend headaches getting it compiled.
>
> Overall good patches, I'm glad there's a lot of interest and discussion here.
> Nothing seems off to me, but those are famous last words and I haven't reviewed
> the split patches yet, I'll put it on my 'I'll review it this week' list and
> come back next month sometime with replies if it's not merged.
>
>> -- 
>> ng
>> personal contact: http://krosos.sdf.org
>> EDN: https://wiki.c3d2.de/EDN
>
> Jookia.
>
>

-- 
ng
personal contact: http://krosos.sdf.org
EDN: https://wiki.c3d2.de/EDN

Re: [PATCH 3] gnunet-gtk build-input, homepage (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1809 bytes --]

On Mon, 28 Mar 2016 17:57:50 +0200
Nils Gillmann <niasterisk@grrlz.net> wrote:

> From ee326257b613449ca5c0834f7e8f6b8d0840d486 Mon Sep 17 00:00:00 2001
> From: Nils Gillmann <niasterisk@grrlz.net>
> Date: Mon, 28 Mar 2016 17:49:27 +0200
> Subject: [PATCH] gnu: gnunet-gtk: Add build-input and home-page.
> 
> * gnu/packages/gnunet.scm (gnunet-gtk)[configure-flags]: Add build-input gnunet.
> [home-page]: New value.

configure-flags is part of arguments, so I'd put it as [arguments]: Fix
configure flags.

> ---
>  gnu/packages/gnunet.scm | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
> index 9fe09a2..9fa2773 100644
> --- a/gnu/packages/gnunet.scm
> +++ b/gnu/packages/gnunet.scm
> @@ -316,7 +316,9 @@ services.")
>      (arguments
>       `(#:configure-flags
>         (list "--without-libunique"
> -             "--with-qrencode")))
> +             "--with-qrencode"
> +             (string-append "--with-gnunet="
> +                            (assoc-ref %build-inputs "gnunet")))))
>      (inputs
>       `(("gnunet" ,gnunet)
>         ("libgcrypt" ,libgcrypt)
> @@ -327,4 +329,5 @@ services.")
>      (native-inputs
>       `(("pkg-config" ,pkg-config)
>         ("libglade" ,libglade)))
> -    (synopsis "Graphical front-end tools for GNUnet")))
> +    (synopsis "Graphical front-end tools for GNUnet")
> +    (home-page "https://gnunet.org")))

The home-page field is inherited from gnunet, so unless it's different it
doesn't need to be explicitly stated.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 4] gnunet-gtk-svn (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 848 bytes --]

On Mon, 28 Mar 2016 12:45:35 -0400
Leo Famulari <leo@famulari.name> wrote:

> On Mon, Mar 28, 2016 at 06:17:05PM +0200, Nils Gillmann wrote:
>  [...]  
> 
> s/traced/tracked
> 
>  [...]  
> 
> Same question as before about the length of the SVN identifier.
> 
> > +       (file-name (string-append name "-" version "-checkout"))
> > +       (sha256 (base32
> > +                "0kbxgfv08kh69vcrkvm23d2vggyww48h9cvgw4gdfs3i146zkfqb"))))
> > +    (arguments
> > +     `(#:configure-flags
> > +       (list "--without-libunique"  
> 
> Can you say why this is disabled?

we don't actually have libunique packaged


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 4] gnunet-gtk-svn (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Nils Gillmann]

Efraim Flashner <efraim@flashner.co.il> writes:

> On Mon, 28 Mar 2016 12:45:35 -0400
> Leo Famulari <leo@famulari.name> wrote:
>
>> On Mon, Mar 28, 2016 at 06:17:05PM +0200, Nils Gillmann wrote:
>>  [...]  
>> 
>> s/traced/tracked
>> 
>>  [...]  
>> 
>> Same question as before about the length of the SVN identifier.
>> 
>> > +       (file-name (string-append name "-" version "-checkout"))
>> > +       (sha256 (base32
>> > +                "0kbxgfv08kh69vcrkvm23d2vggyww48h9cvgw4gdfs3i146zkfqb"))))
>> > +    (arguments
>> > +     `(#:configure-flags
>> > +       (list "--without-libunique"  
>> 
>> Can you say why this is disabled?
>
> we don't actually have libunique packaged

Thanks for the clarification, I put a comment in the updated
patch as a note to package it.

-- 
ng
personal contact: http://krosos.sdf.org
EDN: https://wiki.c3d2.de/EDN

Re: [PATCH 3] gnunet-svn (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Leo Famulari]

On Mon, Mar 28, 2016 at 07:49:48PM +0200, Nils Gillmann wrote:
> Leo Famulari <leo@famulari.name> writes:

[...]

> >> +    (native-inputs
> >> +     `(("pkg-config" ,pkg-config)
> >> +       ("autoconf" ,autoconf)
> >> +       ("automake" ,automake)
> >> +       ("gettext" ,gnu-gettext)
> >> +       ("libtool" ,libtool)
> >> +       ("python" ,python-2)))
> >
> > It only needs python while building?
> 
> Can you be more precise? I don't understand if this is a rhetoric
> or actual question.

I'm asking if gnunet-svn needs python-2 at run-time, or only at
build-time.

Re: [PATCH 3] gnunet-gtk build-input, homepage (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Leo Famulari]

On Mon, Mar 28, 2016 at 07:42:16PM +0200, Nils Gillmann wrote:
> Leo Famulari <leo@famulari.name> writes:
> 
> > On Mon, Mar 28, 2016 at 05:57:50PM +0200, Nils Gillmann wrote:
> >> From ee326257b613449ca5c0834f7e8f6b8d0840d486 Mon Sep 17 00:00:00 2001
> >> From: Nils Gillmann <niasterisk@grrlz.net>
> >> Date: Mon, 28 Mar 2016 17:49:27 +0200
> >> Subject: [PATCH] gnu: gnunet-gtk: Add build-input and home-page.
> >
> > Can you split this into two patches?
> 
> I can, but why should I? Because it's two kinds of changes? I see
> different grouped changes everywhere in the commit logs.

In general I think it's best for unrelated changes to be committed
separately.

Re: [PATCH 2] gnunet: description (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Ludovic Courtès]

Nils Gillmann <niasterisk@grrlz.net> skribis:

> Leo Famulari <leo@famulari.name> writes:

[...]

>>> +   (description "GNUnet is a framework for secure, distributed, peer-to-peer
>>> +networking.  The high-level goal is to provide a strong foundation of free
>>> +software for a global, distributed network which provides security and
>>> +privacy.  GNUnet in that sense aims to replace the current internet protocol
>>> +stack.  Along with an application for secure publication of files, it has
>>> +grown to include all kinds of basic applications for the foundation of a GNU
>>> +internet.
>>> +
>>> +gnunet-0.10.1 is the last stable release candidate, however for
>>> +development purposes and keeping up with latest changes, the SVN version
>>> +might be preferable until a new version is released.")
>>
>> Do we have a consensus on how to handle this sort of "Guix metadata"?
>
> Which metadata do you refer to here?
>
> The description is good with the GNUnet project, talked about it
> with others involved in GNUnet.

It’s not that simple.  ;-)

Descriptions for GNU packages are maintained in a canonical place
outside of Guix (they’re also use for other purposes, such as gnu.org),
and we synchronize from them.  ‘guix lint -c gnu-description’ reports
differences with said database.

Thus, in general, we should keep the canonical synopsis/description for
GNU packages, and email bug-womb@gnu.org if we think a
synopsis/description must be changed.

Another comment: should we call this package “gnunet-next”, like we did
for “guile-next”?  This would make it clear that it’s a development
snapshot.  (Sorry for not coming up with that idea earlier.)

WDYT?

Thanks,
Ludo’.

Re: [PATCH 4] gnunet-gtk-svn (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Nils Gillmann]

Leo Famulari <leo@famulari.name> writes:

> On Mon, Mar 28, 2016 at 06:17:05PM +0200, Nils Gillmann wrote:
>> From 4633dc3484390fa6e399084336e73879066b1760 Mon Sep 17 00:00:00 2001
>> From: Nils Gillmann <niasterisk@grrlz.net>
>> Date: Mon, 28 Mar 2016 18:10:12 +0200
>> Subject: [PATCH] gnu: Add gnunet-gtk-svn.
>> 
>> * gnu/packages/gnunet.scm (gnunet-gtk-svn): New variable.
>> Coauthored by Jookia.
>> ---
>>  gnu/packages/gnunet.scm | 46 ++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 46 insertions(+)
>> 
>> diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
>> index fe6ca14..fa55179 100644
>> --- a/gnu/packages/gnunet.scm
>> +++ b/gnu/packages/gnunet.scm
>> @@ -419,3 +419,49 @@ development purposes and keeping up with latest changes, the SVN version
>>  might be preferable until a new version is released.")
>>      (license license:gpl3+)
>>      (home-page "https://gnunet.org/")))
>> +
>> +;; current WM related bug being traced:
>
> s/traced/tracked

I have a problem reorganizing all the commits due to them being
in one file, next time I do this separately.
Is it possible to just correct this one typo in the patch without
re-submitting?
The libunique problem will be solved when it is packaged.

>> +;; #22985: using gnune-gtk with ratpoison (gnunet-fs in -gtk
>> +;; nonfunctional) -> needs participation and input)
>> +(define-public gnunet-gtk-svn
>> +  (package
>> +    (inherit gnunet-svn)
>> +    (name "gnunet-gtk-svn")
>> +    (version (package-version gnunet-svn))
>> +    (source
>> +     (origin
>> +       (method svn-fetch)
>> +       (uri (svn-reference
>> +             (url "https://gnunet.org/svn/gnunet-gtk/")
>> +             (revision 36926)))
>
> Same question as before about the length of the SVN identifier.
>
>> +       (file-name (string-append name "-" version "-checkout"))
>> +       (sha256 (base32
>> +                "0kbxgfv08kh69vcrkvm23d2vggyww48h9cvgw4gdfs3i146zkfqb"))))
>> +    (arguments
>> +     `(#:configure-flags
>> +       (list "--without-libunique"
>
> Can you say why this is disabled?
>
>> +             "--with-qrencode"
>> +             (string-append "--with-gnunet="
>> +                            (assoc-ref %build-inputs "gnunet-svn")))
>> +       #:phases (modify-phases %standard-phases
>> +                  (add-before 'configure 'bootstrap
>> +                    (lambda _
>> +                      (zero? (system* "autoreconf" "-vfi")))))))
>> +    (inputs
>> +     `(("gnunet-svn" ,gnunet-svn)
>> +       ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
>> +       ("gnutls" ,gnutls)
>> +       ("libgcrypt" ,libgcrypt)
>> +       ("gtk+" ,gtk+)
>> +       ("libextractor" ,libextractor)
>> +       ("glade3" ,glade3)
>> +       ("qrencode" ,qrencode)))
>> +    (native-inputs
>> +     `(("pkg-config" ,pkg-config)
>> +       ("libglade" ,libglade)
>> +       ("autoconf" ,autoconf)
>> +       ("gettext" ,gnu-gettext)
>> +       ("automake" ,automake)
>> +       ("libtool" ,libtool)))
>> +    (synopsis "Graphical front-end tools for GNUnet")
>> +    (home-page "https://gnunet.org")))
>> -- 
>> 2.7.3
>> 

-- 
ng
personal contact: http://krosos.sdf.org
EDN: https://wiki.c3d2.de/EDN

Re: [PATCH 3] gnunet-svn (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Nils Gillmann]

Leo Famulari <leo@famulari.name> writes:

> On Mon, Mar 28, 2016 at 07:49:48PM +0200, Nils Gillmann wrote:
>> Leo Famulari <leo@famulari.name> writes:
>
> [...]
>
>> >> +    (native-inputs
>> >> +     `(("pkg-config" ,pkg-config)
>> >> +       ("autoconf" ,autoconf)
>> >> +       ("automake" ,automake)
>> >> +       ("gettext" ,gnu-gettext)
>> >> +       ("libtool" ,libtool)
>> >> +       ("python" ,python-2)))
>> >
>> > It only needs python while building?
>> 
>> Can you be more precise? I don't understand if this is a rhetoric
>> or actual question.
>
> I'm asking if gnunet-svn needs python-2 at run-time, or only at
> build-time.

I think I have to check this again.

- python-zbar   >= 0.10 (optional for gnunet-qr)

is the only appearance of python in "dependencies for running
GNUnet" in https://gnunet.org/svn/gnunet/README

and also the one in my prior work on gnunet states
		 qr? ( >=media-gfx/zbar-0.10[python] )
so I don't think why Jookia listed python.
I will testbuild this again without python as we currently don't
have zbar packaged.

-- 
ng
personal contact: http://krosos.sdf.org
EDN: https://wiki.c3d2.de/EDN

Re: [PATCH 2] gnunet: description (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Nils Gillmann]

ludo@gnu.org (Ludovic Courtès) writes:

> Nils Gillmann <niasterisk@grrlz.net> skribis:
>
>> Leo Famulari <leo@famulari.name> writes:
>
> [...]
>
>>>> +   (description "GNUnet is a framework for secure, distributed, peer-to-peer
>>>> +networking.  The high-level goal is to provide a strong foundation of free
>>>> +software for a global, distributed network which provides security and
>>>> +privacy.  GNUnet in that sense aims to replace the current internet protocol
>>>> +stack.  Along with an application for secure publication of files, it has
>>>> +grown to include all kinds of basic applications for the foundation of a GNU
>>>> +internet.
>>>> +
>>>> +gnunet-0.10.1 is the last stable release candidate, however for
>>>> +development purposes and keeping up with latest changes, the SVN version
>>>> +might be preferable until a new version is released.")
>>>
>>> Do we have a consensus on how to handle this sort of "Guix metadata"?
>>
>> Which metadata do you refer to here?
>>
>> The description is good with the GNUnet project, talked about it
>> with others involved in GNUnet.
>
> It’s not that simple.  ;-)
>
> Descriptions for GNU packages are maintained in a canonical place
> outside of Guix (they’re also use for other purposes, such as gnu.org),
> and we synchronize from them.  ‘guix lint -c gnu-description’ reports
> differences with said database.

I have write access in gnunet.org and only need to find some
minutes of focus and concentration to change the description on
the frontpage. But I guess again that is is not that simple
either for Guix?

>
> Thus, in general, we should keep the canonical synopsis/description for
> GNU packages, and email bug-womb@gnu.org if we think a
> synopsis/description must be changed.

As far as I understand Christian, he's good with any better
description which does not do total damage to the project.
I got input on the description I added here from most of the
people involved in SecuShare, another project I am involved in
which is part of GNUnet, and it was okay for them.

> Another comment: should we call this package “gnunet-next”, like we did
> for “guile-next”?  This would make it clear that it’s a development
> snapshot.  (Sorry for not coming up with that idea earlier.)

I am used to -git, -svn, -vcs naming but I am not fixed to it. I
can rename the two packages to -next, but it might give the
impression of a different software if the added description is
not included.

Compare the opinion of someone who has never touched gnunet about
"gnunet and gnunet-svn" vs "gnunet and gnunet-next".

On the other hand it can just as well mark the next version... So
I guess it is okay to name it gnunet-next, gnunet-gtk-next

> WDYT?
>
> Thanks,
> Ludo’.
>
>

-- 
ng
personal contact: http://krosos.sdf.org
EDN: https://wiki.c3d2.de/EDN

Re: [PATCH 1] gnurl (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Nils Gillmann]

[-- Attachment #1: Type: text/plain, Size: 69 bytes --]

This patch: tested, builds without errors, line length issue
fixed.


[-- Attachment #2: 0001-gnu-gnurl-Build-with-ca-path.patch --]
[-- Type: text/x-patch, Size: 1609 bytes --]

From 17c55d2d896d7aaca810a9f41c58694a6adadb9d Mon Sep 17 00:00:00 2001
From: Nils Gillmann <niasterisk@grrlz.net>
Date: Thu, 31 Mar 2016 01:30:19 +0200
Subject: [PATCH] gnu: gnurl: Build with ca path.

* gnu/packages/gnunet.scm (gnurl)[configure-flags]: Add --with-ca-path.

Coauthored by Jookia.
---
 gnu/packages/gnunet.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
index eb0c4cb..d60a633 100644
--- a/gnu/packages/gnunet.scm
+++ b/gnu/packages/gnunet.scm
@@ -3,8 +3,9 @@
 ;;; Copyright © 2014 Sree Harsha Totakura <sreeharsha@totakura.in>
 ;;; Copyright © 2015 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2015 Efraim Flashner <efraim@flashner.co.il>
-;;; Copyright © 2016 Ni* Gillmann <ng@niasterisk.space>
+;;; Copyright © 2016 Nils Gillmann <niasterisk@grrlz.net>
 ;;; Copyright © 2016 Ricardo Wurmus <rekado@elephly.net>
+;;; Copyright © 2016 Jookia <166291@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -178,7 +179,8 @@ and support for SSL3 and TLS.")
                           "--disable-ldap" "--disable-rtsp" "--disable-dict"
                           "--disable-telnet" "--disable-tftp" "--disable-pop3"
                           "--disable-imap" "--disable-smtp" "--disable-gopher"
-                          "--disable-file" "--disable-ftp")
+                          "--disable-file" "--disable-ftp"
+                          "--with-ca-path=/etc/ssl/certs")
      #:test-target "test"
      #:parallel-tests? #f
      ;; We have to patch runtests.pl in tests/ directory
-- 
2.7.3


[-- Attachment #3: Type: text/plain, Size: 78 bytes --]


-- 
ng
personal contact: http://krosos.sdf.org
EDN: https://wiki.c3d2.de/EDN

Re: [PATCH 3] gnunet-gtk build-input, homepage (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Nils Gillmann]

[-- Attachment #1: Type: text/plain, Size: 98 bytes --]

Addressed comments I got so far, fixed by excluding home-page
again and changing commit message.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-gnunet-gtk-Add-build-input.patch --]
[-- Type: text/x-patch, Size: 891 bytes --]

From dbf39289e906076a69465a9ff30cd0b18691dc50 Mon Sep 17 00:00:00 2001
From: Nils Gillmann <niasterisk@grrlz.net>
Date: Thu, 31 Mar 2016 01:58:33 +0200
Subject: [PATCH] gnu: gnunet-gtk: Add build-input.

* gnu/packages/gnunet.scm (gnunet-gtk)[arguments]: Fix configure flags.
---
 gnu/packages/gnunet.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
index d60a633..4250125 100644
--- a/gnu/packages/gnunet.scm
+++ b/gnu/packages/gnunet.scm
@@ -315,7 +315,9 @@ services.")
     (arguments
      `(#:configure-flags
        (list "--without-libunique"
-             "--with-qrencode")))
+             "--with-qrencode"
+             (string-append "--with-gnunet="
+                            (assoc-ref %build-inputs "gnunet")))))
     (inputs
      `(("gnunet" ,gnunet)
        ("libgcrypt" ,libgcrypt)
-- 
2.7.3


[-- Attachment #3: Type: text/plain, Size: 78 bytes --]


-- 
ng
personal contact: http://krosos.sdf.org
EDN: https://wiki.c3d2.de/EDN

Re: [PATCH 2] gnunet: description (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 3508 bytes --]

On Thu, Mar 31, 2016 at 01:02:51AM +0200, Nils Gillmann wrote:
> ludo@gnu.org (Ludovic Courtès) writes:
> 
> > Nils Gillmann <niasterisk@grrlz.net> skribis:
> >
> >> Leo Famulari <leo@famulari.name> writes:
> >
> > [...]
> >
> >>>> +   (description "GNUnet is a framework for secure, distributed, peer-to-peer
> >>>> +networking.  The high-level goal is to provide a strong foundation of free
> >>>> +software for a global, distributed network which provides security and
> >>>> +privacy.  GNUnet in that sense aims to replace the current internet protocol
> >>>> +stack.  Along with an application for secure publication of files, it has
> >>>> +grown to include all kinds of basic applications for the foundation of a GNU
> >>>> +internet.
> >>>> +
> >>>> +gnunet-0.10.1 is the last stable release candidate, however for
> >>>> +development purposes and keeping up with latest changes, the SVN version
> >>>> +might be preferable until a new version is released.")
> >>>
> >>> Do we have a consensus on how to handle this sort of "Guix metadata"?
> >>
> >> Which metadata do you refer to here?
> >>
> >> The description is good with the GNUnet project, talked about it
> >> with others involved in GNUnet.
> >
> > It’s not that simple.  ;-)
> >
> > Descriptions for GNU packages are maintained in a canonical place
> > outside of Guix (they’re also use for other purposes, such as gnu.org),
> > and we synchronize from them.  ‘guix lint -c gnu-description’ reports
> > differences with said database.
> 
> I have write access in gnunet.org and only need to find some
> minutes of focus and concentration to change the description on
> the frontpage. But I guess again that is is not that simple
> either for Guix?
> 
> >
> > Thus, in general, we should keep the canonical synopsis/description for
> > GNU packages, and email bug-womb@gnu.org if we think a
> > synopsis/description must be changed.
> 
> As far as I understand Christian, he's good with any better
> description which does not do total damage to the project.
> I got input on the description I added here from most of the
> people involved in SecuShare, another project I am involved in
> which is part of GNUnet, and it was okay for them.
> 
> > Another comment: should we call this package “gnunet-next”, like we did
> > for “guile-next”?  This would make it clear that it’s a development
> > snapshot.  (Sorry for not coming up with that idea earlier.)
> 
> I am used to -git, -svn, -vcs naming but I am not fixed to it. I
> can rename the two packages to -next, but it might give the
> impression of a different software if the added description is
> not included.
> 
> Compare the opinion of someone who has never touched gnunet about
> "gnunet and gnunet-svn" vs "gnunet and gnunet-next".
> 

As someone who has never gotten past installing and uninstalling gnunet,
gnunet-svn sounds like a development branch and gnunet-next sounds like
it's almost ready. Other than having read this thread I would choose
gnunet-next > gnunet > gnunet-svn

> On the other hand it can just as well mark the next version... So
> I guess it is okay to name it gnunet-next, gnunet-gtk-next
> 
> > WDYT?
> >
> > Thanks,
> > Ludo’.
> >
> >
> 

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 3] gnunet-svn (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1608 bytes --]

On Thu, Mar 31, 2016 at 12:48:54AM +0200, Nils Gillmann wrote:
> Leo Famulari <leo@famulari.name> writes:
> 
> > On Mon, Mar 28, 2016 at 07:49:48PM +0200, Nils Gillmann wrote:
> >> Leo Famulari <leo@famulari.name> writes:
> >
> > [...]
> >
> >> >> +    (native-inputs
> >> >> +     `(("pkg-config" ,pkg-config)
> >> >> +       ("autoconf" ,autoconf)
> >> >> +       ("automake" ,automake)
> >> >> +       ("gettext" ,gnu-gettext)
> >> >> +       ("libtool" ,libtool)
> >> >> +       ("python" ,python-2)))
> >> >
> >> > It only needs python while building?
> >> 
> >> Can you be more precise? I don't understand if this is a rhetoric
> >> or actual question.
> >
> > I'm asking if gnunet-svn needs python-2 at run-time, or only at
> > build-time.
> 
> I think I have to check this again.
> 
> - python-zbar   >= 0.10 (optional for gnunet-qr)
> 
> is the only appearance of python in "dependencies for running
> GNUnet" in https://gnunet.org/svn/gnunet/README
> 
> and also the one in my prior work on gnunet states
> 		 qr? ( >=media-gfx/zbar-0.10[python] )
> so I don't think why Jookia listed python.
> I will testbuild this again without python as we currently don't
> have zbar packaged.
> 

zbar is used for barcodes and qrcodes. We do have qrencode, so I suppose
a good test would be if you didn't include python-2 if the qr-code part
still works.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 2] gnunet: description (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Ludovic Courtès]

Nils Gillmann <niasterisk@grrlz.net> skribis:

> ludo@gnu.org (Ludovic Courtès) writes:
>
>> Nils Gillmann <niasterisk@grrlz.net> skribis:
>>
>>> Leo Famulari <leo@famulari.name> writes:
>>
>> [...]
>>
>>>>> +   (description "GNUnet is a framework for secure, distributed, peer-to-peer
>>>>> +networking.  The high-level goal is to provide a strong foundation of free
>>>>> +software for a global, distributed network which provides security and
>>>>> +privacy.  GNUnet in that sense aims to replace the current internet protocol
>>>>> +stack.  Along with an application for secure publication of files, it has
>>>>> +grown to include all kinds of basic applications for the foundation of a GNU
>>>>> +internet.
>>>>> +
>>>>> +gnunet-0.10.1 is the last stable release candidate, however for
>>>>> +development purposes and keeping up with latest changes, the SVN version
>>>>> +might be preferable until a new version is released.")
>>>>
>>>> Do we have a consensus on how to handle this sort of "Guix metadata"?
>>>
>>> Which metadata do you refer to here?
>>>
>>> The description is good with the GNUnet project, talked about it
>>> with others involved in GNUnet.
>>
>> It’s not that simple.  ;-)
>>
>> Descriptions for GNU packages are maintained in a canonical place
>> outside of Guix (they’re also use for other purposes, such as gnu.org),
>> and we synchronize from them.  ‘guix lint -c gnu-description’ reports
>> differences with said database.
>
> I have write access in gnunet.org and only need to find some
> minutes of focus and concentration to change the description on
> the frontpage. But I guess again that is is not that simple
> either for Guix?
>
>>
>> Thus, in general, we should keep the canonical synopsis/description for
>> GNU packages, and email bug-womb@gnu.org if we think a
>> synopsis/description must be changed.
>
> As far as I understand Christian, he's good with any better
> description which does not do total damage to the project.
> I got input on the description I added here from most of the
> people involved in SecuShare, another project I am involved in
> which is part of GNUnet, and it was okay for them.

Do what you want. ;-)  My point is just that the description that appears
in Guix must be the canonical GNU description, i.e., the one returned by
‘guix lint’.

>> Another comment: should we call this package “gnunet-next”, like we did
>> for “guile-next”?  This would make it clear that it’s a development
>> snapshot.  (Sorry for not coming up with that idea earlier.)
>
> I am used to -git, -svn

Sorry, I had overlooked that “-svn” is already there.  Perfect!

Thank you,
Ludo’, who must be tired.

Re: [PATCH 2] gnunet: description (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Nils Gillmann]

ludo@gnu.org (Ludovic Courtès) writes:

> Nils Gillmann <niasterisk@grrlz.net> skribis:
>
>> ludo@gnu.org (Ludovic Courtès) writes:
>>
>>> Nils Gillmann <niasterisk@grrlz.net> skribis:
>>>
>>>> Leo Famulari <leo@famulari.name> writes:
>>>
>>> [...]
>>>
>>>>>> +   (description "GNUnet is a framework for secure, distributed, peer-to-peer
>>>>>> +networking.  The high-level goal is to provide a strong foundation of free
>>>>>> +software for a global, distributed network which provides security and
>>>>>> +privacy.  GNUnet in that sense aims to replace the current internet protocol
>>>>>> +stack.  Along with an application for secure publication of files, it has
>>>>>> +grown to include all kinds of basic applications for the foundation of a GNU
>>>>>> +internet.
>>>>>> +
>>>>>> +gnunet-0.10.1 is the last stable release candidate, however for
>>>>>> +development purposes and keeping up with latest changes, the SVN version
>>>>>> +might be preferable until a new version is released.")
>>>>>
>>>>> Do we have a consensus on how to handle this sort of "Guix metadata"?
>>>>
>>>> Which metadata do you refer to here?
>>>>
>>>> The description is good with the GNUnet project, talked about it
>>>> with others involved in GNUnet.
>>>
>>> It’s not that simple.  ;-)
>>>
>>> Descriptions for GNU packages are maintained in a canonical place
>>> outside of Guix (they’re also use for other purposes, such as gnu.org),
>>> and we synchronize from them.  ‘guix lint -c gnu-description’ reports
>>> differences with said database.
>>
>> I have write access in gnunet.org and only need to find some
>> minutes of focus and concentration to change the description on
>> the frontpage. But I guess again that is is not that simple
>> either for Guix?
>>
>>>
>>> Thus, in general, we should keep the canonical synopsis/description for
>>> GNU packages, and email bug-womb@gnu.org if we think a
>>> synopsis/description must be changed.
>>
>> As far as I understand Christian, he's good with any better
>> description which does not do total damage to the project.
>> I got input on the description I added here from most of the
>> people involved in SecuShare, another project I am involved in
>> which is part of GNUnet, and it was okay for them.
>
> Do what you want. ;-)  My point is just that the description that appears
> in Guix must be the canonical GNU description, i.e., the one returned by
> ‘guix lint’.

Okay, and this description is set outside of gnunet.org I assume.
If I propose this new description to Christian (currently it was
a number of people but I only talked to cg at the conference
where we met that I feel it needs some change etc), is that
weightful enough to change the description on gnu.org whereever
it sits?

>>> Another comment: should we call this package “gnunet-next”, like we did
>>> for “guile-next”?  This would make it clear that it’s a development
>>> snapshot.  (Sorry for not coming up with that idea earlier.)
>>
>> I am used to -git, -svn
>
> Sorry, I had overlooked that “-svn” is already there.  Perfect!
>
> Thank you,
> Ludo’, who must be tired.
>
>

-- 
ng
personal contact: http://krosos.sdf.org
EDN: https://wiki.c3d2.de/EDN

Re: [PATCH 2] gnunet: description (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Ludovic Courtès]

Nils Gillmann <niasterisk@grrlz.net> skribis:

> ludo@gnu.org (Ludovic Courtès) writes:
>
>> Nils Gillmann <niasterisk@grrlz.net> skribis:
>>
>>> ludo@gnu.org (Ludovic Courtès) writes:
>>>
>>>> Nils Gillmann <niasterisk@grrlz.net> skribis:
>>>>
>>>>> Leo Famulari <leo@famulari.name> writes:
>>>>
>>>> [...]
>>>>
>>>>>>> +   (description "GNUnet is a framework for secure, distributed, peer-to-peer
>>>>>>> +networking.  The high-level goal is to provide a strong foundation of free
>>>>>>> +software for a global, distributed network which provides security and
>>>>>>> +privacy.  GNUnet in that sense aims to replace the current internet protocol
>>>>>>> +stack.  Along with an application for secure publication of files, it has
>>>>>>> +grown to include all kinds of basic applications for the foundation of a GNU
>>>>>>> +internet.
>>>>>>> +
>>>>>>> +gnunet-0.10.1 is the last stable release candidate, however for
>>>>>>> +development purposes and keeping up with latest changes, the SVN version
>>>>>>> +might be preferable until a new version is released.")
>>>>>>
>>>>>> Do we have a consensus on how to handle this sort of "Guix metadata"?
>>>>>
>>>>> Which metadata do you refer to here?
>>>>>
>>>>> The description is good with the GNUnet project, talked about it
>>>>> with others involved in GNUnet.
>>>>
>>>> It’s not that simple.  ;-)
>>>>
>>>> Descriptions for GNU packages are maintained in a canonical place
>>>> outside of Guix (they’re also use for other purposes, such as gnu.org),
>>>> and we synchronize from them.  ‘guix lint -c gnu-description’ reports
>>>> differences with said database.
>>>
>>> I have write access in gnunet.org and only need to find some
>>> minutes of focus and concentration to change the description on
>>> the frontpage. But I guess again that is is not that simple
>>> either for Guix?
>>>
>>>>
>>>> Thus, in general, we should keep the canonical synopsis/description for
>>>> GNU packages, and email bug-womb@gnu.org if we think a
>>>> synopsis/description must be changed.
>>>
>>> As far as I understand Christian, he's good with any better
>>> description which does not do total damage to the project.
>>> I got input on the description I added here from most of the
>>> people involved in SecuShare, another project I am involved in
>>> which is part of GNUnet, and it was okay for them.
>>
>> Do what you want. ;-)  My point is just that the description that appears
>> in Guix must be the canonical GNU description, i.e., the one returned by
>> ‘guix lint’.
>
> Okay, and this description is set outside of gnunet.org I assume.
> If I propose this new description to Christian (currently it was
> a number of people but I only talked to cg at the conference
> where we met that I feel it needs some change etc), is that
> weightful enough to change the description on gnu.org whereever
> it sits?

As I wrote above, you can email a new description to bug-womb@gnu.org if
you want.  The source is at
<http://cvs.savannah.gnu.org/viewvc/*checkout*/gnumaint/pkgblurbs.txt?root=womb>.

HTH,
Ludo’.

Re: [PATCH 2] gnunet: description (was Re: [PATCH] gnunet.scm -> various changes (description update, adds gnunet-svn, gnunet-gtk-svn, gnurl))

[Nils Gillmann]

ludo@gnu.org (Ludovic Courtès) writes:

> Nils Gillmann <niasterisk@grrlz.net> skribis:
>
>> ludo@gnu.org (Ludovic Courtès) writes:
>>
>>> Nils Gillmann <niasterisk@grrlz.net> skribis:
>>>
>>>> ludo@gnu.org (Ludovic Courtès) writes:
>>>>
>>>>> Nils Gillmann <niasterisk@grrlz.net> skribis:
>>>>>
>>>>>> Leo Famulari <leo@famulari.name> writes:
>>>>>
>>>>> [...]
>>>>>
>>>>>>>> +   (description "GNUnet is a framework for secure, distributed, peer-to-peer
>>>>>>>> +networking.  The high-level goal is to provide a strong foundation of free
>>>>>>>> +software for a global, distributed network which provides security and
>>>>>>>> +privacy.  GNUnet in that sense aims to replace the current internet protocol
>>>>>>>> +stack.  Along with an application for secure publication of files, it has
>>>>>>>> +grown to include all kinds of basic applications for the foundation of a GNU
>>>>>>>> +internet.
>>>>>>>> +
>>>>>>>> +gnunet-0.10.1 is the last stable release candidate, however for
>>>>>>>> +development purposes and keeping up with latest changes, the SVN version
>>>>>>>> +might be preferable until a new version is released.")
>>>>>>>
>>>>>>> Do we have a consensus on how to handle this sort of "Guix metadata"?
>>>>>>
>>>>>> Which metadata do you refer to here?
>>>>>>
>>>>>> The description is good with the GNUnet project, talked about it
>>>>>> with others involved in GNUnet.
>>>>>
>>>>> It’s not that simple.  ;-)
>>>>>
>>>>> Descriptions for GNU packages are maintained in a canonical place
>>>>> outside of Guix (they’re also use for other purposes, such as gnu.org),
>>>>> and we synchronize from them.  ‘guix lint -c gnu-description’ reports
>>>>> differences with said database.
>>>>
>>>> I have write access in gnunet.org and only need to find some
>>>> minutes of focus and concentration to change the description on
>>>> the frontpage. But I guess again that is is not that simple
>>>> either for Guix?
>>>>
>>>>>
>>>>> Thus, in general, we should keep the canonical synopsis/description for
>>>>> GNU packages, and email bug-womb@gnu.org if we think a
>>>>> synopsis/description must be changed.
>>>>
>>>> As far as I understand Christian, he's good with any better
>>>> description which does not do total damage to the project.
>>>> I got input on the description I added here from most of the
>>>> people involved in SecuShare, another project I am involved in
>>>> which is part of GNUnet, and it was okay for them.
>>>
>>> Do what you want. ;-)  My point is just that the description that appears
>>> in Guix must be the canonical GNU description, i.e., the one returned by
>>> ‘guix lint’.
>>
>> Okay, and this description is set outside of gnunet.org I assume.
>> If I propose this new description to Christian (currently it was
>> a number of people but I only talked to cg at the conference
>> where we met that I feel it needs some change etc), is that
>> weightful enough to change the description on gnu.org whereever
>> it sits?
>
> As I wrote above, you can email a new description to bug-womb@gnu.org if
> you want.  The source is at
> <http://cvs.savannah.gnu.org/viewvc/*checkout*/gnumaint/pkgblurbs.txt?root=womb>.
>
> HTH,
> Ludo’.

Oh, thanks.
Added to my todo list.

-- 
ng
personal contact: http://krosos.sdf.org
EDN: https://wiki.c3d2.de/EDN