From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH 3/6] gnu: Add emacs-avy. Date: Mon, 20 Jun 2016 06:40:05 +0200 Message-ID: <87k2hkeamy.fsf@elephly.net> References: <20160618161544.3643-1-rekado@elephly.net> <20160618161544.3643-3-rekado@elephly.net> <87vb1585ld.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50915) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEr0V-0000MC-8t for guix-devel@gnu.org; Mon, 20 Jun 2016 00:40:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bEr0S-0003YZ-6c for guix-devel@gnu.org; Mon, 20 Jun 2016 00:40:19 -0400 Received: from sender163-mail.zoho.com ([74.201.84.163]:24270) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEr0R-0003YT-TB for guix-devel@gnu.org; Mon, 20 Jun 2016 00:40:16 -0400 In-reply-to: <87vb1585ld.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Alex Kost Cc: guix-devel@gnu.org Alex Kost writes: > Ricardo Wurmus (2016-06-18 19:15 +0300) wrote: > >> * gnu/packages/emacs.scm (emacs-avy): New variable. >> --- >> gnu/packages/emacs.scm | 36 ++++++++++++++++++++++++++++++++++++ >> 1 file changed, 36 insertions(+) >> >> >> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm >> index 6741f58..5158059 100644 >> --- a/gnu/packages/emacs.scm >> +++ b/gnu/packages/emacs.scm >> @@ -1768,6 +1768,42 @@ his orignal purpose, calling his proper command. This makes the Hydra very >> seamless, it's like a minor mode that disables itself automatically.") >> (license license:gpl3+))) >> >> +(define-public emacs-avy >> + (package >> + (name "emacs-avy") >> + (version "0.4.0") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (string-append "https://github.com/abo-abo/avy/archive/" >> + version ".tar.gz")) >> + (file-name (string-append name "-" version ".tar.gz")) >> + (sha256 >> + (base32 >> + "1wdrq512h25ymzjbf2kbsdymvd2ryfwzb6bh5bc3yv7q203im796")))) >> + (build-system emacs-build-system) >> + (home-page "https://github.com/abo-abo/avy") >> + (synopsis "Tree-based completion") > > I would write "Tree-based completion for Emacs", but I'm not sure if we > have a convention to mention "Emacs" in synopsis or description of emacs > packages. Okay. >> + (description >> + "This package provides a generic completion method based on building a >> +balanced decision tree with each candidate being a leaf. To traverse the tree >> +from the root to a desired leaf, typically a sequence of @code{read-key} can >> +be used. >> + >> +In order for @code{read-key} to make sense, the tree needs to be visualized >> +appropriately, with a character at each branch node. So this completion >> +method works only for things that you can see on your screen, all at once, >> +such as >> + >> +@enumerate >> +@item character positions >> +@item word or subword start positions >> +@item line beginning positions >> +@item link positions >> +@item window positions >> +@end enumerate\n") > > I think this description is a bit too long, but I'm fine with it except > the last "\n", I would remove it :-) I have inlined the enumeration and shortened the items. ~~ Ricardo