From: ludo@gnu.org (Ludovic Courtès)
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 11/17] gnu: Add make-linux-libre-source.
Date: Sun, 11 Sep 2016 23:21:01 +0200 [thread overview]
Message-ID: <87k2eigmki.fsf@gnu.org> (raw)
In-Reply-To: <20160909123426.18499-11-david@craven.ch> (David Craven's message of "Fri, 9 Sep 2016 14:34:20 +0200")
David Craven <david@craven.ch> skribis:
> * gnu/packages/linux-libre.scm (make-linux-libre-source): New variable.
> (linux-libre, linux-libre-4.4, linux-libre-4.1): Use
> make-linux-libre-source.
> (linux-libre-urls): Remove.
[...]
> -(define (linux-libre-urls version)
> - "Return a list of URLs for Linux-Libre VERSION."
I would keep it…
> +(define-public (make-linux-libre-source version hash)
> + (origin
> + (method url-fetch)
> + (uri (list (string-append
> + "http://linux-libre.fsfla.org/pub/linux-libre/releases/"
> + version "-gnu/linux-libre-" version "-gnu.tar.xz")
> +
> + ;; XXX: Work around <http://bugs.gnu.org/14851>.
> + (string-append
> + "ftp://alpha.gnu.org/gnu/guix/mirror/linux-libre-"
> + version "-gnu.tar.xz")
> +
> + ;; Maybe this URL will become valid eventually.
> + (string-append
> + "mirror://gnu/linux-libre/" version "-gnu/linux-libre-"
> + version "-gnu.tar.xz")))
> + (sha256 (base32 hash))
> + (patches (origin-patches %boot-logo-patch))))
… and make it a macro instead (and drop ‘make-’):
(define-syntax-rule (linux-libre-source version hash)
(origin
;; …
(sha256 (base32 hash))))
Since it’s a macro, we’d still have the compile-time behavior of
‘base32’ that we discussed earlier.
WDYT?
Ludo’.
next prev parent reply other threads:[~2016-09-11 21:21 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 22:45 Linux kernel David Craven
2016-09-09 1:36 ` Leo Famulari
2016-09-09 12:34 ` [PATCH 01/17] gnu: module-init-tools: Prevent line wrapping David Craven
2016-09-09 12:34 ` [PATCH 02/17] gnu: linux-libre: Use modify-phases David Craven
2016-09-09 12:34 ` [PATCH 03/17] gnu: linux-libre: Use system->architecture David Craven
2016-09-09 12:34 ` [PATCH 04/17] gnu: linux-libre: Apply %boot-logo patch in origin David Craven
2016-09-11 20:57 ` Ludovic Courtès
2016-09-09 12:34 ` [PATCH 05/17] gnu: linux-libre: Move kernel configuration to configure phase David Craven
2016-09-11 20:57 ` Ludovic Courtès
2016-09-09 12:34 ` [PATCH 06/17] gnu: linux-libre: Add support for cross-compilation David Craven
2016-09-11 20:58 ` Ludovic Courtès
2016-09-09 12:34 ` [PATCH 07/17] gnu: linux-libre: Use make-linux-libre David Craven
2016-09-11 21:07 ` Ludovic Courtès
2016-09-09 12:34 ` [PATCH 08/17] gnu: make-linux-libre: Add additional-configuration parameter David Craven
2016-09-11 21:13 ` Ludovic Courtès
2016-09-09 12:34 ` [PATCH 09/17] gnu: dtc: Remove patch-paths phase David Craven
2016-09-11 21:14 ` Ludovic Courtès
2016-09-09 12:34 ` [PATCH 10/17] gnu: Add u-boot-beagle-bone-black David Craven
2016-09-11 21:16 ` Ludovic Courtès
2016-09-09 12:34 ` [PATCH 11/17] gnu: Add make-linux-libre-source David Craven
2016-09-11 21:21 ` Ludovic Courtès [this message]
2016-09-11 21:23 ` Ludovic Courtès
2016-09-09 12:34 ` [PATCH 12/17] gnu: make-linux-libre: Add extra-version parameter David Craven
2016-09-11 21:32 ` Ludovic Courtès
2016-09-09 12:34 ` [PATCH 13/17] gnu: make-linux-libre: Add zImage to output David Craven
2016-09-11 21:24 ` Ludovic Courtès
2016-09-12 6:59 ` Danny Milosavljevic
2016-09-12 7:46 ` David Craven
2016-09-09 12:34 ` [PATCH 14/17] gnu: linux-libre: Use kmod David Craven
2016-09-11 21:25 ` Ludovic Courtès
2016-09-09 12:34 ` [PATCH 15/17] gnu: make-linux-libre: Add supported-systems parameter David Craven
2016-09-11 21:28 ` Ludovic Courtès
2016-09-09 12:34 ` [PATCH 16/17] gnu: Add linux-libre-multi-v7 David Craven
2016-09-09 14:31 ` Vincent Legoll
2016-09-11 21:30 ` Ludovic Courtès
2016-09-09 12:34 ` [PATCH 17/17] gnu: Add linux-libre-beagle-bone-black David Craven
2016-09-11 21:33 ` Ludovic Courtès
2016-09-09 22:26 ` Linux kernel Ludovic Courtès
2016-09-09 22:48 ` David Craven
2016-09-10 12:57 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2eigmki.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=david@craven.ch \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).