From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 02/12] gnu: Add alexandria.
Date: Sat, 08 Oct 2016 14:43:02 +0200
Message-ID: <87k2djhuzt.fsf@gnu.org>
References: <20160927041532.27097-1-ajpatter@uwaterloo.ca>
	<20160927041532.27097-3-ajpatter@uwaterloo.ca>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56430)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bsqy8-0003F4-44
	for guix-devel@gnu.org; Sat, 08 Oct 2016 08:43:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bsqy2-0005dp-BV
	for guix-devel@gnu.org; Sat, 08 Oct 2016 08:43:11 -0400
In-Reply-To: <20160927041532.27097-3-ajpatter@uwaterloo.ca> (Andy Patterson's
	message of "Tue, 27 Sep 2016 00:15:22 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Andy Patterson <ajpatter@uwaterloo.ca>
Cc: guix-devel@gnu.org

Andy Patterson <ajpatter@uwaterloo.ca> skribis:

> * gnu/packages/lisp.scm (alexandria, alexandria-sbcl, alexandria-ecl):
>   New variables.

[...]

> +(define-public alexandria
> +  (let ((revision "1")
> +        (commit "926a066611b7b11cb71e26c827a271e500888c30"))
> +    (package
> +      (name "alexandria")
> +      (version (string-append "0.0.0-" revision "." (string-take commit =
7)))
> +      (source (origin
> +                (method git-fetch)
> +                (uri
> +                 (git-reference
> +                  (url "https://gitlab.common-lisp.net/alexandria/alexan=
dria.git")
> +                  (commit commit)))
> +                (sha256
> +                 (base32 "18yncicdkh294j05rhgm23gzi36y9qy6vrfba8vg69jrxj=
p1hx8l"))
> +                (file-name (string-append name "-" version "-checkout"))=
))
> +      (build-system asdf-build-system/source)
> +      (synopsis "Collection of portable utilities for Common Lisp")
> +      (description "Alexandria is a collection of portable utilities.  I=
t does
> +not contain conceptual extensions to Common Lisp.  It is conservative in
> +scope, and portable between implementations.")
> +      (home-page "https://common-lisp.net/project/alexandria/")
> +      (license license:public-domain))))
> +
> +(define-public alexandria-sbcl
> +  (package
> +    (inherit alexandria)
> +    (name "alexandria-sbcl")
> +    (build-system asdf-build-system/sbcl)
> +    (inputs `(("alexandria" ,alexandria)))))
> +
> +(define-public alexandria-ecl
> +  (package
> +    (inherit alexandria)
> +    (name "alexandria-ecl")
> +    (build-system asdf-build-system/ecl)
> +    (inputs `(("alexandria" ,alexandria)))))

It=E2=80=99s unusual that the =E2=80=9Calexandria=E2=80=9D package provides=
 the source and that
the others depend on it rather than have an =E2=80=98origin=E2=80=99 as the=
ir source.
But as you wrote in the build system code, the raw source can be
interpreted by CL implementations other than SBCL or ECL, right?

Otherwise LGTM.

Thanks,
Ludo=E2=80=99.