From: Marius Bakke <mbakke@fastmail.com>
To: Adonay Felipe Nogueira <adfeno@openmailbox.org>, guix-devel@gnu.org
Subject: Re: gnu: artanis: Remove implied $(DESTDIR) usage.
Date: Mon, 17 Oct 2016 03:13:20 +0100 [thread overview]
Message-ID: <87k2d7oh8f.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <1476582044.11070.21.camel@adfeno-VPCEG17FB>
Adonay Felipe Nogueira <adfeno@openmailbox.org> writes:
> My first patch to Guix project, I hope this helps. :)
Welcome and thanks for this patch! :)
The current artanis package has a bug where the install location is set
to "$out/$out/share/guile/site/2.0". This patch fixes that by installing
to "$out/share/guile/site/2.0". I can load it from the Guile REPL now.
However, the same files are still present in
/gnu/store/...-artanis-0.1.2/gnu/store/...-artanis-0.1.2 as before. It
seems to be installed to both $out and $out/$out. Do you think you can
prevent this from happening as well?
Other than that I only have one remark:
[...]
> diff --git a/gnu/packages/patches/artanis-fix-Makefile.in.patch b/gnu/packages/patches/artanis-fix-Makefile.in.patch
> new file mode 100644
> index 0000000..d2c19f1
> --- /dev/null
> +++ b/gnu/packages/patches/artanis-fix-Makefile.in.patch
> @@ -0,0 +1,69 @@
> +Applies until an Artanis release comes with patches #9130 and #9131
> +applied.
Please mention the upstream commit hash or bug report here, so that
the next person can easily tell whether this is still needed or not.
Can you send an updated patch?
Thanks!
next prev parent reply other threads:[~2016-10-17 2:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-16 1:40 gnu: artanis: Remove implied $(DESTDIR) usage Adonay Felipe Nogueira
2016-10-17 2:13 ` Marius Bakke [this message]
2016-10-17 12:54 ` Adonay Felipe Nogueira
2016-10-17 14:27 ` Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2d7oh8f.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me \
--to=mbakke@fastmail.com \
--cc=adfeno@openmailbox.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).