From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH 1/7] gnu: Add KDE frameworkintegration. Date: Mon, 21 Nov 2016 18:25:57 +0100 Message-ID: <87k2bw923e.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <1479744699-27226-1-git-send-email-h.goebel@crazy-compilers.com> <1479744699-27226-2-git-send-email-h.goebel@crazy-compilers.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59378) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c8sM1-0000BT-S6 for guix-devel@gnu.org; Mon, 21 Nov 2016 12:26:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c8sLx-0006ZW-PB for guix-devel@gnu.org; Mon, 21 Nov 2016 12:26:05 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:56118) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c8sLx-0006ZL-Lt for guix-devel@gnu.org; Mon, 21 Nov 2016 12:26:01 -0500 In-Reply-To: <1479744699-27226-2-git-send-email-h.goebel@crazy-compilers.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Hartmut Goebel , guix-devel@gnu.org --=-=-= Content-Type: text/plain Hartmut Goebel writes: > * gnu/packages/kde-frameworks.scm (frameworkintegration): New variable. > --- > gnu/packages/kde-frameworks.scm | 51 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 51 insertions(+) > > diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm > index 9df37ac..0e6b8fb 100644 > --- a/gnu/packages/kde-frameworks.scm > +++ b/gnu/packages/kde-frameworks.scm > @@ -2798,3 +2798,54 @@ setUrl, setUserAgent and call.") > script engines.") > ;; dual licensed > (license (list license:gpl2+ license:lgpl2.1+)))) > + > +;; Tier 4 > +;; > +;; Tier 4 frameworks can be mostly ignored by application programmers; this > +;; tier consists of plugins acting behind the scenes to provide additional > +;; functionality or platform integration to existing frameworks (including > +;; Qt). > + > +(define-public frameworkintegration > + (package > + (name "frameworkintegration") > + (version "5.27.0") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "mirror://kde/stable/frameworks/" > + (version-major+minor version) "/" > + name "-" version ".tar.xz")) > + (sha256 > + (base32 > + "0zpv7wj2006f039wr1gp5bc4md8yq9ig5g3v5mx46sdjip5423p1")))) > + (build-system cmake-build-system) > + (native-inputs > + `(("extra-cmake-modules" ,extra-cmake-modules) > + ("pkg-config" ,pkg-config))) > + (inputs > + `(("kconfig" ,kconfig) > + ("kconfigwidgets" ,kconfigwidgets) > + ("kcoreaddons" ,kcoreaddons) > + ("kiconthemes" ,kiconthemes) > + ("kitemviews" ,kitemviews) > + ("knotificantions" ,knotifications) > + ("kwidgetsaddons" ,kwidgetsaddons) > + ("qtbase" ,qtbase) > + ("qtx11extras" ,qtx11extras))) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (add-before 'check 'check-setup > + (lambda _ > + (setenv "HOME" (getcwd)) > + (setenv "CTEST_OUTPUT_ON_FAILURE" "1") ; Enable debug output > + (setenv "QT_QPA_PLATFORM" "offscreen") Could you add a comment explaining what this variable does? > + #t))))) > + (home-page "https://community.kde.org/Frameworks") > + (synopsis "KDE Frameworks 5 workspace and cross-framework integration plugins") > + (description "Framework Integration is a set of plugins responsible for > +better integration of Qt applications when running on a KDE Plasma > +workspace.") > + ;; triple licensed > + (license (list license:gpl2+ license:lgpl2.0 license:lgpl2.0+)))) Please clarify. Is it all of them, or either? Or is it mostly gpl2+, but some files are covered by the other two? Otherwise LGTM! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCgAGBQJYMy4mAAoJEKKgbfKjOlT6qhAIAI0xhGRiDVOPtL7J4JZl2Lrk S8UAi0qWL8UOMeuRproQMV8VuHrJxq9dsfUgGtPqfCiS4viKPD+sfus808tCYJgT IgHN1FE7Y25kPzPZsZUf1n44l65kHcV1GdF00Ed4tXeiqgHw0llj2fZ26TdpyMAP ubttAVi/j4KL9+QKiudOJLRm2xG285LPGadkjeS4W/1bJEj4Vnk3cqqbCT6cAe8G ahS87f+4+oHYDh2VqGPh6x36V49ig42sb3p/uESehhJqOOGlr4Os7uFDpojjZgPt Omz6xpm06BQrIPHHEfXZdbn0KWoCFfO7MpqSFXcp+jL72Dv++uuk+dEstxpassE= =mOwd -----END PGP SIGNATURE----- --=-=-=--