From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: pre-push signature hook error reporting Date: Mon, 06 Feb 2017 17:37:13 +0100 Message-ID: <87k293i8cm.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <20170105161431.9803-1-dannym@scratchpost.org> <878tqpjw93.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <8760lj5eb6.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <20170113152400.GA24322@jasmine> <20170117031414.GB23513@jasmine> <87o9z1aksp.fsf@gnu.org> <20170121013910.GC26714@jasmine> <20170206153922.GA10240@jasmine> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59608) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1camI9-000578-NS for guix-devel@gnu.org; Mon, 06 Feb 2017 11:37:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1camI5-0006yv-SE for guix-devel@gnu.org; Mon, 06 Feb 2017 11:37:25 -0500 In-Reply-To: <20170206153922.GA10240@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari , Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Leo Famulari writes: > On Fri, Jan 20, 2017 at 03:05:42PM +0100, Ludovic Court=C3=A8s wrote: >> For the pre-push hook, the overhead seems reasonable (perhaps we could >> limit the range to commits after the first signed commit to avoid >> looping for no reason?) and an improvement. > > Here is a patch for the hook that I've been using for the past couple wee= ks. > > For the common use case of pushing new commits to an existing branch, I > don't notice the hook at all, except when it catches my mistakes. Thanks a lot for this! I haven't tested it, but the code LGTM. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAliYpjkACgkQoqBt8qM6 VPog9QgAshxVY2aNJXLVsl897P5t419NdSOUbA1OXkTNRfkDH3NDhax3+CzNiTZe NYqKz0cjPl8zVvjiZWoE10NxLyHa4D3LQ2PQHKBSa41vprVtUCH659lEjxqPImiy kreSR2C/fk0hmD44zy+5xwt7Xf1HiRs7dT4W1SZUmvFZW9IdD0mn5gSunws4dXqz qsmCZvSzIQxq8o50sIRlMAf7YT7vGTIR0Ha6GKceHrDCOr6GGU7StRr5dCDwPVl3 wqMzs4esv0LRe3v4A1azKk4SVmm69+CSL8+Gyds81kaQ0HMwwmx//VPRUSjg0Nnh WaOUSE5rDiewPCN1vvz52XrPRLER1g== =jiHJ -----END PGP SIGNATURE----- --=-=-=--