From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kei Kebreau Subject: Re: 02/02: gnu: Add s. Date: Mon, 05 Jun 2017 11:44:32 -0400 Message-ID: <87k24ql9r3.fsf@openmailbox.org> References: <20170604144555.7655.18380@vcs0.savannah.gnu.org> <20170604144556.5AFA1206F7@vcs0.savannah.gnu.org> <878tl770ht.fsf@netris.org> <20170605084253.wnoucacjqv5hk6t7@abyayala> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35187) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHuBt-0008OB-1P for guix-devel@gnu.org; Mon, 05 Jun 2017 11:45:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dHuBp-0007j5-Vu for guix-devel@gnu.org; Mon, 05 Jun 2017 11:45:13 -0400 Received: from lb1.openmailbox.org ([5.79.108.160]:48769 helo=mail.openmailbox.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dHuBp-0007fX-J0 for guix-devel@gnu.org; Mon, 05 Jun 2017 11:45:09 -0400 In-Reply-To: <20170605084253.wnoucacjqv5hk6t7@abyayala> (ng0@pragmatique.xyz's message of "Mon, 5 Jun 2017 08:42:53 +0000") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Mark H Weaver Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable ng0 writes: > Mark H Weaver transcribed 1.2K bytes: >> kei@openmailbox.org (Kei Kebreau) writes: >>=20 >> > kkebreau pushed a commit to branch master >> > in repository guix. >> > >> > commit 0e4591bb696a36bc83f75869dd2711987b17b722 >> > Author: ng0 >> > Date: Tue May 16 22:28:58 2017 +0000 >> > >> > gnu: Add s. >> >=20=20=20=20=20 >> > * gnu/packages/shells.scm (s): New variable. >> >=20=20=20=20=20 >> > Signed-off-by: Kei Kebreau >> > --- >> > gnu/packages/shells.scm | 61 ++++++++++++++++++++++++++++++++++++++++= +++++++++ >> > 1 file changed, 61 insertions(+) >> > >> > diff --git a/gnu/packages/shells.scm b/gnu/packages/shells.scm >> > index 5eeb186..5e04e86 100644 >> > --- a/gnu/packages/shells.scm >> > +++ b/gnu/packages/shells.scm >> > @@ -503,6 +503,67 @@ Its features include: >> > @end enumerate\n") >> > (license bsd-2))) >> >=20=20 >> > +(define-public s >> > + (let ((commit "6604341edb3a775ff94415762af3ee9bd86bfb3c") >> > + (revision "1")) >> > + (package >> > + (name "s") >> > + (version (string-append "0.0.0-" revision "." (string-take comm= it 7))) >>=20 >> I think we should rename this package and variable name to 's-shell' or >> something along those lines. 's' is commonly used as a local variable >> name. Single character variable names are in short supply, and I don't >> think we should allocate them to packages. >>=20 >> Thoughts? >>=20 >> Mark > > I did not think of this use, renaming to s-shell is okay. I agree. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlk1fGAACgkQ5qXuPBlG eg3aUQ/8C1P/09joMepBxddmA2IaQK10jSMuf7NF5GebPwrgjPcTlFnS1wsjNLSr GeYLq1TSkiBQiRDi9CCLfDS7I2bZTTsQUHuiWmwBy/GEKnnMuLoYG+72IhM/B4Ps W9jIwdws0N9j8HODIa6MevWTCguB4q4ZLavzTLbGDbBuUr7lQnEjnq2oQ/YjKPf+ 3jqcjqxR6ga1nKzo3Tv8MfMyRF1LtdrphNQhNHMYe5MWUaezkTS36I5dB+naJCFI FPQ5afqXRHxuszHdMKV5VjiJVjpocDf8wR45WEamWuWD8GpUaoCOI6CuXjMYnYD/ m7Lx/E8coLDahbT/XBOjCIiGNUeh8aoNeOsp18p+xhF4A5D2GlhoHe4vugAC+FeD 5bh/MaSOftOjObe5mLCS3+srvpTuMbIl10fjmx39fcb56wLKkIvTpQYxpJeeBrpm 33r9JUqzWDsAbimqKUq4bV7AM87+bUZNnPt9PIGqsYYiWKEj1Xxn7KXr9yHGBYrz nrj1L3sXq0VJBqUiKnrTJ4m1Yp18m/uyM6zEIU/dMO7pP2oyFIqHsSU00DwVR5Af FXNMoxJdbbWWUpvpnIVMRohIlZBy6PKeIVS+O4EzZgpXMoX7fpzgqEHTm4eSadNo P41Nm5ihQwxdauyRLGEBpqmn9ZP3EGMDjYAT2gMFaPMqELs4iIs= =WquK -----END PGP SIGNATURE----- --=-=-=--