From mboxrd@z Thu Jan 1 00:00:00 1970 From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=) Subject: Re: [WIP][PATCH] profiles: info-dir-file: Don't consider unwanted manifest entries Date: Fri, 22 Dec 2017 19:21:23 +0800 Message-ID: <87k1xfhuto.fsf@member.fsf.org> References: <87ind8ja9h.fsf@member.fsf.org> <430063d5-8e7f-739a-74f4-5b9fddf01c7f@uni-bremen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48328) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eSLOU-0002ap-H0 for guix-devel@gnu.org; Fri, 22 Dec 2017 06:21:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eSLOP-00077V-IN for guix-devel@gnu.org; Fri, 22 Dec 2017 06:21:38 -0500 Received: from rezeros.cc ([2001:19f0:7001:2f3e:5400:ff:fe84:e55d]:35530) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eSLOP-0006uX-30 for guix-devel@gnu.org; Fri, 22 Dec 2017 06:21:33 -0500 In-Reply-To: <430063d5-8e7f-739a-74f4-5b9fddf01c7f@uni-bremen.de> (Martin Castillo's message of "Fri, 15 Dec 2017 16:40:33 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Martin Castillo Cc: guix-devel@gnu.org Martin Castillo writes: > Hi, > > in the second patch file: >> + ;; We only need to build the 'dir' file for inputs that does > containing info >> + ;; manuals. > s/containing/contain > Okay, thanks! > On 15.12.2017 16:12, =E5=AE=8B=E6=96=87=E6=AD=A6 wrote:> Hello! >> >> Currently we run profile hooks for all manifest inputs, so if you >> install a new package to your profile, all profile hooks will be run >> again, even if the new package doesn't provide info manuals, man pages, >> etc. Ideally only interested hooks need to be run, eg: if the new >> package has info manuals, then the 'info-dir-file' hook will run. > > One would need to filter man-pages too, right? Yes, that need be done in the 'manual-database' hook.