unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Alex Kost <alezost@gmail.com>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: Don't change "+" syntax in guix/.dir-locals.el
Date: Wed, 23 May 2018 14:33:04 +0200	[thread overview]
Message-ID: <87k1ruzh4v.fsf@gnu.org> (raw)
In-Reply-To: <87k1rwvp0x.fsf@gmail.com> (Alex Kost's message of "Mon, 21 May 2018 21:31:42 +0300")

Hello!

Alex Kost <alezost@gmail.com> skribis:

> Pierre Neidhardt (2018-05-20 21:57 +0200) wrote:
>
>> I recently noticed that guix-devel-mode misbehaved on packages ending
>> with a "+" (like my recent emacs-image+).
>>
>> See https://github.com/alezost/guix.el/issues/24 for more details.
>>
>> Alex Kost suggested we removed the syntax change in .dir-locals.el:
>>
>>    ;; This notably allows '(' in Paredit to not insert a space when the
>>    ;; preceding symbol is one of these.
>>    (eval . (modify-syntax-entry ?~ "'"))
>>    (eval . (modify-syntax-entry ?$ "'"))
>> -  (eval . (modify-syntax-entry ?+ "'"))
>
> Here is my point: I believe (re-search-forward "\\s_" nil t) should find
> "+" character in lisp/scheme modes because it may be part of symbol
> names there.  Even elisp manual mentions this fact:
>
> https://www.gnu.org/software/emacs/manual/html_node/elisp/Syntax-Class-Table.html#Syntax-Class-Table
>
> So I think that ".dir-locals.el" shouldn't break this default behavior.

So, IIUC, we may have to sacrifice highlighting of #+ so that
‘guix-guile-current-definition’ works well with symbols containing ‘+’,
right?

That’d be fine with me.  :-)

Thank you!

Ludo’.

  reply	other threads:[~2018-05-23 12:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-20 19:57 Don't change "+" syntax in guix/.dir-locals.el Pierre Neidhardt
2018-05-21 18:31 ` Alex Kost
2018-05-23 12:33   ` Ludovic Courtès [this message]
2018-05-23 17:21     ` Alex Kost
2018-05-28  9:34       ` Ludovic Courtès
2018-05-29  9:16         ` Alex Kost
2018-05-29  9:20           ` Pierre Neidhardt
2018-05-29 19:31           ` Ludovic Courtès
2018-05-30  8:36             ` Alex Kost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k1ruzh4v.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=alezost@gmail.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).