From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id sLUnMe7HX2CbbwEAgWs5BA (envelope-from ) for ; Sun, 28 Mar 2021 01:03:58 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id u0UOK+7HX2B+cAAA1q6Kng (envelope-from ) for ; Sun, 28 Mar 2021 00:03:58 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 17BAE2EF9F for ; Sun, 28 Mar 2021 01:03:58 +0100 (CET) Received: from localhost ([::1]:52642 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQIuL-0006J6-6q for larch@yhetil.org; Sat, 27 Mar 2021 20:03:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34444) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQIu7-0006Iw-PF for guix-devel@gnu.org; Sat, 27 Mar 2021 20:03:43 -0400 Received: from world.peace.net ([64.112.178.59]:60792) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQIu5-0006tf-SJ for guix-devel@gnu.org; Sat, 27 Mar 2021 20:03:43 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lQIu0-00085K-BN; Sat, 27 Mar 2021 20:03:36 -0400 From: Mark H Weaver To: Maxime Devos , guix-devel@gnu.org Subject: Re: [PATCHES] ImageMagick security updates without grafting In-Reply-To: <927d66ccc760afacdb88485c5158731458d52dd6.camel@telenet.be> References: <878s68zqsd.fsf@netris.org> <927d66ccc760afacdb88485c5158731458d52dd6.camel@telenet.be> Date: Sat, 27 Mar 2021 20:01:59 -0400 Message-ID: <87k0psdu25.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=64.112.178.59; envelope-from=mhw@netris.org; helo=world.peace.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616889838; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=xOPfY1lIKC2Z6d0kkPkn3m1VjGSrIcqWHfEzh7YAzxE=; b=rZjcZeJzap1uQsCCbeEQFojBK5xffoDxwiSJIoTHuWw0oY9maMSq/DRnJx8nEjB/+vj9ON 3KccMu177ZXMeb4JoEtNpJDWkPXCC19PpXYqvs0+rG47CVNZj2PJlTlYYCAkjwkl3RA2XM alwVgQDaF1ze/aNgV9afo0NGUOJbmRcw66eJfqxK6FZ+bR0lWI7q+dpqYuRg3yYPsB6M4L QwQF9SikL305TRimzpqpD78c46tly5MBm8sg1ngad+/n2rnbm8w8d2jxzmBnp+N+iyw5KU ZJLik+lO71FPmVW38Ldeqn6d7aohrtc+IDn6v+st814CO9YxteGMEFmbjf3vZQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616889838; a=rsa-sha256; cv=none; b=pgLhrJnQiqK4n1biRv5kJMmLsZYqCVaNbvgJOLT7ivy5N+TbgR1r/8cXKL3UV/ruKB0Czh upPnKeCaQArYQ5GrBnK4kI1fyQmsC3fa1nPQMJfFmdgxSgNOlmPx8cr6KvkEZmxb8IteLf HP88ZS2jD3pjwz6/sa2R8YfHxPMZQWWaIl7x8LMuLEeKLBZvoGikXeXDShqvbqOrWyz5es gMishIurSRicxPZ+Zq1zhBPI+Edr2FEUL6Ld+k65z8TtayVOOccf8JOoNzOp8JXvRbj/CR TX93jx55x6KSJIM2oMhB9SUmtQIVCQUBea/qjs/Aj4OeS+OKkO/7CpUS5C6MMw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -2.42 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 17BAE2EF9F X-Spam-Score: -2.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: +lqUtm4T8y0R Hi Maxime, Maxime Devos writes: > This approach (& patches) look good to me. Thanks for looking. > What does =E2=80=98guix refresh --list-dependent imagemagick@6.9.11-48=E2= =80=99 > output now? When I last checked, it reported on the order of 2400 dependent package rebuilds. > If it there are many dependent packages, could some > of them use imagemagick/stable, dblatex/stable or gtk-doc/stable > as well? Yes, that's exactly the purpose of this patch set. Although at present, the only user of 'imagemagick/stable' is 'dblatex/stable', and the only user of 'dblatex/stable' is 'gtk-doc/stable'. > Maybe add a comment to imagemagick/stable on why there is a=20 > /stable variant, for future reference. Good idea. I added comments similar to what you had suggested. Thanks for the review! I went ahead and pushed a revised version of these commits to 'master', starting with commit 7c2b840d6c586f80fe22a862ce4e362c997559a5, but if anyone has further input on this approach, it's still not too late to change things. Thanks, Mark