From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id uLHQM7ZHeWPjRAEAbAwnHQ (envelope-from ) for ; Sat, 19 Nov 2022 22:16:38 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id oBrbMrZHeWNtKQAAG6o9tA (envelope-from ) for ; Sat, 19 Nov 2022 22:16:38 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 676442A495 for ; Sat, 19 Nov 2022 22:16:37 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owVCD-0006P1-Cl; Sat, 19 Nov 2022 16:16:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owVBw-0006JY-Oe for guix-devel@gnu.org; Sat, 19 Nov 2022 16:16:04 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owVBw-0001Yy-2W; Sat, 19 Nov 2022 16:16:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=TcQQW/5cID+R6XFdE4R4xLqhcdlz5CbR8yrFbgKFWgI=; b=bRxQ46zymn3bwTwEt2la KZyylPkc8udHijvGjjevBnSgfnOcWWU0h5a4b4WyZkuETnvvXka6LZkxQt0ML9x1QNu7zLbLSBlGS J7xBx+NLVV2WneSzrYWx1zX2n/f8MU0NuJOz5H7XzI4HoNCAsmnVl/qTUKayvCyO0UzoGfA2/F+Ud QwmwSVnixS652KMZxJsF1lX7VS9u5A7tW9C4bxF95Kz8E2oqOsDqLlsckwieAfob0IbTxUaF8XKJK xQPAY/ImoVXaOOpwNQ7MZ48dZweTwX0+7Jn7XNRTW2tUkrTCjcf6/Ah4tWICRRnwAoLcqEHUc8mkn gfUu7mnfZHlRzQ==; Received: from [84.214.173.6] (helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owVBg-0006S1-8m; Sat, 19 Nov 2022 16:15:59 -0500 From: Marius Bakke To: Christopher Baines , guix-devel@gnu.org Cc: Maxim Cournoyer Subject: Re: 01/03: gnu: lld-as-ld-wrapper: Add version 15. In-Reply-To: <87y1s7b2l6.fsf@cbaines.net> References: <166870906351.8449.8741107130024395258@vcs2.savannah.gnu.org> <20221117181744.1E709C0E4B9@vcs2.savannah.gnu.org> <87y1s7b2l6.fsf@cbaines.net> Date: Sat, 19 Nov 2022 22:15:41 +0100 Message-ID: <87k03q1w8y.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1668892598; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=TcQQW/5cID+R6XFdE4R4xLqhcdlz5CbR8yrFbgKFWgI=; b=OxTGYsJvxCLMzQ9b9xPa/rJpWz1LH2OxtG9oCeWTxhmwdVompuYaRWWPlaCCJ3B1nEJOZ0 1RVupYbpZT+zulz9t/Ih9vYRMBbb5gLH+Dlhsj6YXvYl0ehwmwZtj4tVI7yiEPPvOSHDzj 0+H/PmF+8Chu8oUY+Yo4CNTVXF3wKIeczR5kCD7bl8JhJAJTNj8LxKKS38CzASsw4Lw9Vx GQTSSW/dahRmZfI3uZ1TEUeltqoM4cQxC+fyYVUcpWXzuKQL61cesPiOxbkp/KcF9t2Dz7 hmumNMpS7vUcxv7ITToWcZPhVYgT7ZeHlzTHnDbrIcbfF/+Z2mArWjBb34hNjg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1668892598; a=rsa-sha256; cv=none; b=VRoNCOMXHAJtg/c8lHzOJEuMYzkiYZndMN5mi/k7YyFNMoxLB3ModfMbPBdNyCcyeJbQ74 Y+XuTrMBojHuFuBOIB0igcqbPp6/f1XMNuUMkMw83GIlO4S68UnUcalGQP/ZAWZ9N277O1 DcXInf6gKCEySE2np0CF3pKISn2PS6KiPU3+q1i7GNTJKuRJ2bVRfm9km52dZYQ1Rh6Lwp 0LPCDO2zdO2g+4vOd4jqJd1gqP76kuf/W68zegh58vE1kKbw8+pZ2Lv3EC4nrDTomOrWez LeBe/R39/3gBJhhyldVD40MVe7MGPImhdO4+bpw/dk6WyoieVN0ASRQWmhLtHQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=bRxQ46zy; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -7.31 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=bRxQ46zy; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 676442A495 X-Spam-Score: -7.31 X-Migadu-Scanner: scn1.migadu.com X-TUID: 45asOgO7Jx3a --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Christopher Baines skriver: > guix-commits@gnu.org writes: > >> mbakke pushed a commit to branch master >> in repository guix. >> >> commit 65976a8382678cd983ceddde040b777cba1f1be9 >> Author: Marius Bakke >> AuthorDate: Thu Nov 17 07:22:41 2022 +0100 >> >> gnu: lld-as-ld-wrapper: Add version 15. >> >> * gnu/packages/llvm.scm (lld-as-ld-wrapper-15): New variable. >> --- >> gnu/packages/llvm.scm | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm >> index de19b40343..2b50b127c2 100644 >> --- a/gnu/packages/llvm.scm >> +++ b/gnu/packages/llvm.scm >> @@ -1625,6 +1625,9 @@ misuse of libraries outside of the store.") >> (make-lld-wrapper lld)) >> >> ;;; A LLD wrapper that can be used as a (near) drop-in replacement to G= NU ld. >> +(define-public lld-as-ld-wrapper-15 >> + (make-lld-wrapper lld-15 #:lld-as-ld? #t)) >> + >> (define-public lld-as-ld-wrapper >> (make-lld-wrapper lld #:lld-as-ld? #t)) > > I spotted this change when looking at [1] as the Guix Data Service is > failing at extracting a consistent derivation for lld-as-ld-wrapper@0. > > 1: https://qa.guix.gnu.org/issue/59367 > > Maybe that could be viewed as a bug in the Guix Data Service, as it > assumes/wants packages to be unique by name and version (at least the > public/visible packages). > > But this is something raised by the linter also: > > =E2=86=92 ./pre-inst-env guix lint lld-as-ld-wrapper > guix lint: warning: ambiguous package specification `lld-as-ld-wrapper' > guix lint: warning: choosing lld-as-ld-wrapper@0 from gnu/packages/llvm= .scm:1594:2 > > Is there something that can be done about this, perhaps by using the lld > package version in the name or version for this package, or by hiding > this package? I think using the LLD version is sensible. I made this change in cd9161372aa3ec9b8902385d5937d04e1868495c and also inherited the home-page and license fields. Maxim: please let me know if you this this was misguided! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCY3lHfQ8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHcqJgEA6533pU7GOhKhcAaHQCQDpbtqopmlPiKz0WhY M4ZmTSkA/A6Aa7Pt4BNQyIZsepB6zbUg46rgmi6epP1eF4HSou4B =Lc62 -----END PGP SIGNATURE----- --=-=-=--