unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <marius@gnu.org>
To: Christopher Baines <mail@cbaines.net>, guix-devel@gnu.org
Cc: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: Re: 01/03: gnu: lld-as-ld-wrapper: Add version 15.
Date: Sat, 19 Nov 2022 22:15:41 +0100	[thread overview]
Message-ID: <87k03q1w8y.fsf@gnu.org> (raw)
In-Reply-To: <87y1s7b2l6.fsf@cbaines.net>

[-- Attachment #1: Type: text/plain, Size: 2086 bytes --]

Christopher Baines <mail@cbaines.net> skriver:

> guix-commits@gnu.org writes:
>
>> mbakke pushed a commit to branch master
>> in repository guix.
>>
>> commit 65976a8382678cd983ceddde040b777cba1f1be9
>> Author: Marius Bakke <marius@gnu.org>
>> AuthorDate: Thu Nov 17 07:22:41 2022 +0100
>>
>>     gnu: lld-as-ld-wrapper: Add version 15.
>>
>>     * gnu/packages/llvm.scm (lld-as-ld-wrapper-15): New variable.
>> ---
>>  gnu/packages/llvm.scm | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm
>> index de19b40343..2b50b127c2 100644
>> --- a/gnu/packages/llvm.scm
>> +++ b/gnu/packages/llvm.scm
>> @@ -1625,6 +1625,9 @@ misuse of libraries outside of the store.")
>>    (make-lld-wrapper lld))
>>
>>  ;;; A LLD wrapper that can be used as a (near) drop-in replacement to GNU ld.
>> +(define-public lld-as-ld-wrapper-15
>> +  (make-lld-wrapper lld-15 #:lld-as-ld? #t))
>> +
>>  (define-public lld-as-ld-wrapper
>>    (make-lld-wrapper lld #:lld-as-ld? #t))
>
> I spotted this change when looking at [1] as the Guix Data Service is
> failing at extracting a consistent derivation for lld-as-ld-wrapper@0.
>
> 1: https://qa.guix.gnu.org/issue/59367
>
> Maybe that could be viewed as a bug in the Guix Data Service, as it
> assumes/wants packages to be unique by name and version (at least the
> public/visible packages).
>
> But this is something raised by the linter also:
>
>   → ./pre-inst-env guix lint lld-as-ld-wrapper
>   guix lint: warning: ambiguous package specification `lld-as-ld-wrapper'
>   guix lint: warning: choosing lld-as-ld-wrapper@0 from gnu/packages/llvm.scm:1594:2
>
> Is there something that can be done about this, perhaps by using the lld
> package version in the name or version for this package, or by hiding
> this package?

I think using the LLD version is sensible.  I made this change in
cd9161372aa3ec9b8902385d5937d04e1868495c and also inherited the
home-page and license fields.

Maxim: please let me know if you this this was misguided!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

  reply	other threads:[~2022-11-19 21:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <166870906351.8449.8741107130024395258@vcs2.savannah.gnu.org>
     [not found] ` <20221117181744.1E709C0E4B9@vcs2.savannah.gnu.org>
2022-11-19 11:30   ` 01/03: gnu: lld-as-ld-wrapper: Add version 15 Christopher Baines
2022-11-19 21:15     ` Marius Bakke [this message]
2022-11-20  1:30       ` Maxim Cournoyer
2022-11-21 11:08       ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k03q1w8y.fsf@gnu.org \
    --to=marius@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=mail@cbaines.net \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).