From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id wNV6Epzrx2OeQgAAbAwnHQ (envelope-from ) for ; Wed, 18 Jan 2023 13:52:44 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id KCmTEZzrx2OXNgAAG6o9tA (envelope-from ) for ; Wed, 18 Jan 2023 13:52:44 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 171892817A for ; Wed, 18 Jan 2023 13:52:43 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pI7vV-0003K7-7i; Wed, 18 Jan 2023 07:52:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pI7vT-0003Gq-8Y for guix-devel@gnu.org; Wed, 18 Jan 2023 07:52:23 -0500 Received: from mira.cbaines.net ([212.71.252.8]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pI7vR-0000oM-4o for guix-devel@gnu.org; Wed, 18 Jan 2023 07:52:22 -0500 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699]) by mira.cbaines.net (Postfix) with ESMTPSA id 5A4C127BBE9; Wed, 18 Jan 2023 12:52:17 +0000 (GMT) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id a0116c4c; Wed, 18 Jan 2023 12:52:16 +0000 (UTC) References: <87cz8no0a0.fsf@cbaines.net> <874jsq40cj.fsf@cbaines.net> User-agent: mu4e 1.8.11; emacs 28.2 From: Christopher Baines To: Andreas Enge Cc: guix-devel@gnu.org Subject: Re: Proposed changes to the commit policy (#59513) Date: Wed, 18 Jan 2023 11:45:20 +0000 In-reply-to: Message-ID: <87k01k2ef5.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674046364; a=rsa-sha256; cv=none; b=I9ELFb6vVZRBfa9Nsb5+qa/ALpA/YXf5LSD7SCTsJpT1tocOatLKSTxQyImii3dMxEU/ra AB4hM+Uc1NZ3ModTVFXobg2y3GBNRT/doJ6h0VZLpjXGqRzTCAmOfvbEiDq3m4/IyFgYRI FBu7DaThjAzjgvokTdPoHmcClu+EHkRgFO0X66o0gdumAIJJ3pIyTSqFpa6hklRzvctBQH jJdfx/jppEJs5Phgw21v3YlyVWps+4/hdiatP+N/BGFAFc2mNf3Nea9wFCTpCQSzF9kZND nykWgdDnbCLoqPdBetrhVIkmFhLWXQP+vPQVCLLE8cTLb1e9VoHjIhf0OzyWmQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674046364; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=ILDUKOUBbjLooPBrsHuS0ovc1qfS5eLDGnq317x6kXI=; b=g8xbPsbM7h28G3xYRNT53CqO4EszUKFDBehK9iX/yP2z2XMpD3e2iTHAn4g5JdYMD3mKV1 qMOS1cuv04tpog7efB0k1NGoePv+StCuuGKZY5w51+8koo4yion8H0/x9JKsxyia8wU2LZ 4Sph80Je1KDH5XIdOt1blc90nrcvXPEkNYt2BcFnu2mLVGTMIh47B4FvzPDtnlXablHTio ooGZvzqd650LjZAj+xEdsOj7/ccrG/Qlzc5f46/SItY+ypKgpD32K3Ubz9IFwb5HgFHYnA PrFgEajkvwq2a0qgW8MeGg4UspWM+27LcIEo6NzdBGaDJl87DtCCSD4vrxTzVA== X-Spam-Score: -4.83 X-Migadu-Queue-Id: 171892817A Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -4.83 X-TUID: DtAEQGzX98F6 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Andreas Enge writes: > Hello, > > Am Mon, Jan 16, 2023 at 09:47:06PM +0000 schrieb Christopher Baines: >> I merged the changes a few days ago, so this is just a quick message to >> say that the commit policy has changed. You can read the updated policy >> here: >> https://guix.gnu.org/en/manual/devel/en/html_node/Commit-Access.html#C= ommit-Policy > > as a quick concrete question: Do simple package updates still count as > trivial, or do they need to go through the patches mailing list? > I intended to update pari-gp from 2.15.1 to 2.15.2, as usual by checking > that all dependent packages still compile. Having to fiddle with debbugs > is somewhat deterring (although admittedly having qa compile all dependent > packages is also a service in a context where I do not expect problems). My feeling on this is that "simple" package updates are often not trivial, or at least doing rigorous testing for these updates isn't trivial. A definition of trivial might be "having little value or importance", and I don't think that's generally the case for version updates, they're often a valuable and important change. That's not to say that the policy doesn't allow for pushing the pari-gp update directly to the master branch. I think the wiggle room in the policy is given by the "should" instruction regarding posting to guix-patches@gnu.org and the "This is subject to being adjusted, allowing individuals to commit directly on non-controversial changes on parts they=E2=80=99re familiar with." bit. As you say, my hope is that having parts of the quality assurance testing automated, e.g. compiling the updated version of para-gp and affected packages on supported architectures will be something people want to use, rather than feeling forced to. > In case the answer is that submitting to the patch tracker is required, > I would suggest to shorten the waiting period from one week to zero > (meaning that it is okay to push when there are no problems detected by q= a, > without having to wait for human review that has no reason to occur). That seems reasonable to me, at least in the case of package updates. Given that's such a common change, maybe that needs handling specifically in the commit policy. > I would also like to update mpfr and mpc in core-updates. The documentati= on > mentions the different branches under Step 9: > https://guix.gnu.org/en/manual/devel/en/html_node/Submitting-Patches.h= tml > but how is this specified in the email to the patch tracker, > so that qa applies the patch to the correct branch? That's not something that's attempted yet, all patches are just applied to master. Maybe setting out the subject like this [1] could indicate the intended branch? I'm not sure what flags to pass to git format-patch/send-email to achieve that though. 1: https://issues.guix.gnu.org/55227 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmPH635fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XfgRg//SxMaEjmzE3ujr1SaCy9yragQCRE7OH2C HceCHW+hOnsoVEP0BzqHuZhfexpmKfCearo0rZtiAg3pGUkWMz/vXDYF2Kr6rW+P ClikEU14P/2CL/+8/yhqfb65ayYDewc4zPqEcg5MzVMb/LHiBfh38zMBJibroRjl 28aORJsZdlbphm1GB9a32VPppdHEfRxDgtHxktAzafELRzIUAbiX3X5BDRyt2jTq sRyeCGmT6qU06pgP9doiz6xozstmb6fN6/+srRopo1uEkt8R6NtXmgssJEflOu0D KoSmKs+S7qHEiZWY7Qg1Kwrk73bnpVY1sBs2F5qkpgiNgfZ1y5JYs6NzQwedbDKd vPJ9LrrPux+Qytiip/bPZadcXe1r4wFKtqypYpJ2ZpwXw5wnwWQjcGD92oDCMAQj 7b9/DZvvLEnnq3reWX8vJAIBHXKnVLxzcpif//wUsdbhqLBjigcliX/+ly9aMOqR +vIBJyPV0R0RiqBR8sQZsD7prAbd4AbUw4jGcTB4wssq860lWi18DVw+Hul4Ikao xfs3sNRCkUjHVfkYn8USx3JbBdcQbCdy35OZRKh+/tY/WSXpPLojHPYZiNo06eQt Wh60ONjWEgtLX0DkXiMtSnwRMLJvFbznB5iBLbMZq9zxqXMWSbEOpbwX4lSzOncN U/uoDOX/o7E= =4b5d -----END PGP SIGNATURE----- --=-=-=--