From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Andreas Enge <andreas@enge.fr>
Cc: Felix Lechner <felix.lechner@lease-up.com>,
Christopher Baines <mail@cbaines.net>,
guix-devel@gnu.org
Subject: Re: Rebasing or merging? [was: Re: 01/03: gnu: wxwidgets: Add libxtst to inputs.]
Date: Mon, 12 Jun 2023 09:47:32 -0400 [thread overview]
Message-ID: <87jzw87pxn.fsf@gmail.com> (raw)
In-Reply-To: <ZIcZ9tUidrWOfgyN@jurong> (Andreas Enge's message of "Mon, 12 Jun 2023 15:13:26 +0200")
Hi Andreas,
Andreas Enge <andreas@enge.fr> writes:
> Hello,
>
> Am Sun, Jun 11, 2023 at 06:10:37PM -0700 schrieb Felix Lechner:
>> That was probably a misunderstanding. I meant to suggest with some
>> trepidation that 'master' is merged into the feature branch, and then
>> the feature branch is merged back into 'master'. I thought the two
>> merge commits would be signed by the person performing the merges
>> while the "origin seal" of the accepted change is also preserved.
>
> indeed, that is what we had been doing with the very long lived staging
> and core-updates branches in the past. Well, we used to repeatedly merge
> the master branch to core-updates, which if I remember well makes the
> master commits end up first in "git log". So the core-updates specific
> commits gradually disappear below thousands of master commits. So this is
> a problem.
>
> But Maxim is right about signatures, sorry for forgetting them time and
> again!
>
> One policy would be to *not* merge master back to the feature branch
> (or maybe just before merging the feature branch to master). This would
> work well for short-lived branches.
Yes, I think we should document as policy that there should be no merge
to the feature branches unless really necessary. This will remove a lot
of noise from the commit history and keep things in the feature branch
focused.
--
Thanks,
Maxim
next prev parent reply other threads:[~2023-06-12 14:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <168610879676.2825.9044237296073582277@vcs2.savannah.gnu.org>
[not found] ` <20230607033317.826FCC23EDC@vcs2.savannah.gnu.org>
2023-06-07 10:59 ` 01/03: gnu: wxwidgets: Add libxtst to inputs Christopher Baines
2023-06-11 3:17 ` Maxim Cournoyer
2023-06-11 8:44 ` Rebasing or merging? [was: Re: 01/03: gnu: wxwidgets: Add libxtst to inputs.] Andreas Enge
2023-06-11 21:25 ` Maxim Cournoyer
2023-06-11 22:40 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2023-06-12 0:47 ` Maxim Cournoyer
2023-06-12 1:10 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2023-06-12 12:22 ` Maxim Cournoyer
2023-06-12 13:13 ` Andreas Enge
2023-06-12 13:47 ` Maxim Cournoyer [this message]
2023-06-13 2:07 ` Leo Famulari
2023-06-14 1:32 ` Maxim Cournoyer
2023-06-20 17:15 ` Giovanni Biscuolo
2023-06-20 20:39 ` Maxim Cournoyer
2023-06-21 7:36 ` Josselin Poiret
2023-06-26 13:26 ` Maxim Cournoyer
2023-06-20 16:32 ` Giovanni Biscuolo
2023-06-11 9:25 ` 01/03: gnu: wxwidgets: Add libxtst to inputs Christopher Baines
2023-06-11 21:20 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzw87pxn.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=andreas@enge.fr \
--cc=felix.lechner@lease-up.com \
--cc=guix-devel@gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).