From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id iPlOOWLt/mQ4CwEAauVa8A:P1 (envelope-from ) for ; Mon, 11 Sep 2023 12:35:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id iPlOOWLt/mQ4CwEAauVa8A (envelope-from ) for ; Mon, 11 Sep 2023 12:35:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 95D443211A for ; Mon, 11 Sep 2023 12:35:14 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694428514; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=LgpD4Qrj1fA01e5weMoCfdfiH/gxuDU/mOJqIldRhmo=; b=Lse+J33I+x82s0psbD8C28ZW4ftGXoyIaiG9tlSsVyye0+56gomaK1dQqtVf5PERbwLuuV kGZIfW1MO22k/OeOV4ebiNzKKW7oz5KAD6nHWVIVprVwv0NaiAe6Vnl5NVtgAm6k4UYOfO ELoqBypZoL9w1gKnjboVTmAgq2lqb9tMbJ9roQbSC/ZnMxa1zt63bFA+4saMBNc9zS+L0Q HYGfiRWRJSCQ272VbVp72VcupSZRc8i+R54oyhRa0wZrPE8uC0kq+CZojr1BpsAWOdnqTD dQPXQvpIP9+uGhLdN32HSYjsk83OnxEXKtESP3RS+Zoev08aH1S5HSIcdbBd1A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694428514; a=rsa-sha256; cv=none; b=MRVGS0OaJlyTMig601Ar8NKEo+bQMNYwsB9paUI9wg6QZJ7TF6vCB71Bhwid1I2HZKUlh6 Lxn1PqnVZHvJS5354pbH2a6FuVfQrokhyFS4ST3wvogPVDZXuZLlp+1Tztjt88jRaerzfE +SlR9Z9UDlIH6h9ZNEuzVZ53NuXjgGwoJyRfIJOji9TittoSeIB9LgoMy2+ZvgR5zuFmSr I6bNyUQdQOyKjWocRy4u6/r7A+Zcs/9fr1zuz5VEYYdOE1U4CJCdqBlCb5W32hQhZM13vt wb9sr/8UlClUq/cMxWJ6Ur2YfubQKBECef+qCPjL+BqfK+y3KKHC461EPvA83Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfeFO-0007hj-Su; Mon, 11 Sep 2023 06:34:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfeFM-0007hI-Be for guix-devel@gnu.org; Mon, 11 Sep 2023 06:34:24 -0400 Received: from ns13.heimat.it ([46.4.214.66]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfeFI-0005ID-LL for guix-devel@gnu.org; Mon, 11 Sep 2023 06:34:24 -0400 Received: from localhost (ip6-localhost [127.0.0.1]) by ns13.heimat.it (Postfix) with ESMTP id 9EFC83008E0; Mon, 11 Sep 2023 10:34:18 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at ns13.heimat.it Received: from ns13.heimat.it ([127.0.0.1]) by localhost (ns13.heimat.it [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jCUvKVR8ezpU; Mon, 11 Sep 2023 10:34:16 +0000 (UTC) Received: from bourrache.mug.xelera.it (unknown [93.56.171.217]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ns13.heimat.it (Postfix) with ESMTPSA id 4B7C83008B3; Mon, 11 Sep 2023 10:34:16 +0000 (UTC) Received: from roquette.mug.biscuolo.net (roquette [10.38.2.14]) by bourrache.mug.xelera.it (Postfix) with SMTP id 6EF7629ABE9F; Mon, 11 Sep 2023 12:34:15 +0200 (CEST) Received: (nullmailer pid 16647 invoked by uid 1000); Mon, 11 Sep 2023 10:34:15 -0000 From: Giovanni Biscuolo To: Efraim Flashner , Ricardo Wurmus Cc: Josselin Poiret , Liliana Marie Prikler , "(" , Katherine Cox-Buday , Simon Tournier , Maxim Cournoyer , Saku Laesvuori , Attila Lendvai , Andreas Enge , guix-devel@gnu.org Subject: Re: How can we decrease the cognitive overhead for contributors? In-Reply-To: Organization: Xelera.eu References: <20230827135726.y33t55w4cvq6zsvb@X-kone> <874jkift8v.fsf@gmail.com> <867cp4sj7k.fsf@gmail.com> <38242808-2f06-4674-3842-aea1a5378d05@gmail.com> <87a5u0o3z2.fsf@disroot.org> <3b274703acaf446ec678e96c9d875c5d6b1a3e17.camel@gmail.com> <87h6o7vdsz.fsf@jpoiret.xyz> <87wmx0684g.fsf@elephly.net> Date: Mon, 11 Sep 2023 12:34:07 +0200 Message-ID: <87jzsxc82o.fsf@xelera.eu> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=46.4.214.66; envelope-from=g@xelera.eu; helo=ns13.heimat.it X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx2.migadu.com X-Spam-Score: -5.32 X-Migadu-Queue-Id: 95D443211A X-Migadu-Spam-Score: -5.32 X-TUID: 851JApGpTJn5 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Efraim, Efraim Flashner writes: [...] > On the other hand, if we do manage to automate writing of commit > messages, it makes one less thing for committers to manually fix before > pushing the commit. It would be lovely! It could also be done by a client-side git hook, provided in the Guix repo and automatically installed when following the instructions on the Guix manual (sorry I miss the pointer now) so that not only committers can benefit using that script but also contributors. As usual: patches wellcome! :-) Sorry I can't contribute with this task, I really don't know ho to program such a script. All I can do is suggesting to add a git commit message template (see message id:87y1hhdnzj.fsf@xelera.eu point 4. for details) Anyway, automation does't mean that the contributor/committer can ignore the commit message content conforms to the Guix guidelines: IMO a human supervising activity is always needed, be it done by contributors before submiting a patch or by a reviewer before committing. > The last couple of contributions I pushed had green checks on > qa.guix.gnu.org and I felt at a bit of a loss what to do while > checking it over. Sorry feel I don't fully understand what do you mean. I'm guessing here... AFAIU having a green light on QA means one of the build farms succesfully built the package, I guess this is a "gree check" on a "Committer check list" before committing: actually I can't find such check list but probably it can be "extrapolated" from the checklist documented for patch submissions: https://guix.gnu.org/en/manual/devel/en/html_node/Submitting-Patches.html So, if all the items in the check list are OK, the package sould be committed to the appropriate branch. Lastly, IMO if you are committer you can go on, if you are not committer you should notify a suitable committer that all is ready for commitment. Maybe if QA would send an email notification to the bug owner (every bug related to a patch set should have an owner) about thay "green light" it could be of some help with keeping track of what can be actually merged. > After checking that it was in fact green I double-checked the > commit message and then also some of the layout of the commit and the > package itself, and made sure it passed `guix lint`. More resources for > qa.guix.gnu.org would let us build more patches more quickly. I agree, QA is a critical resource in this phase of Guix evolution. More resources IMO also means documentation... and maybe more features? I feel like we should find a way to sponsor the work on QA. Happy hacking! Gio' =2D-=20 Giovanni Biscuolo Xelera IT Infrastructures --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJABAEBCgAqFiEERcxjuFJYydVfNLI5030Op87MORIFAmT+7R8MHGdAeGVsZXJh LmV1AAoJENN9DqfOzDkS+7MQANC7PkC3ddcLSfEwyow7wkhlosVxGJBPjN3XB50D ldWwcWsdTMmcaqXlfDXPsd/ZRC20rhQ6VS5m3Yv6fn2hdMtD5ioAsVQDH2f8dWDf mkR1afB/sDACSpQkqdp/DIu9COzK3JYqq3fDZK0IB7VJBXiXfa87XWOcEK3AaaM/ EzRvYWsCXRDZSc7zTc83obeYBDNiCNoimuJeaxYbGty/uaSsRKdNgafmc4Nrrb0V GxUGxEtQmdyUz1yYB0QJ24EaRa6iWwPxSdD2rOf+gN+4KWJaDhx28Kl+sGNvFImR 6rHpywLvk6a6joQmA1JeTCYv5+Vt5Vb+4Qz0TO/dmANMURytLpgWSx4fPnuZLFwS oBGqjDHkgEHBAZQnhXO9Qtcg6NFhI3g2MDsGlXp4HYduXUR7Q8HJisfSiAFmAYoE egD3I+oqJnfaupnoEuiPiaryTKufoF1pmzkZTSeUHJaAW1C/5rX16+2F7NbaLDXb Nhiixk7HYfQwxI/zVrtFvORdF0y5qzrSbV9ZXLU9knama7mF7ECEH7b/UHGHTfoB BS6cXK+DOzRMlC55DbLbrO896eCs1VM5NmtltzSUOvmoPBrwR1/tftV4sgWTk0Z7 jGHCvNumstJkXQ2IOpJ1VbG98cP9Si34MO30Ofz7dstKO+0+lBwSvcLT11715w01 GJwr =8ejS -----END PGP SIGNATURE----- --=-=-=--