From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 5OYoEGshIGUOxAAA9RJhRA:P1 (envelope-from ) for ; Fri, 06 Oct 2023 17:02:03 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 5OYoEGshIGUOxAAA9RJhRA (envelope-from ) for ; Fri, 06 Oct 2023 17:02:03 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1508175E64 for ; Fri, 6 Oct 2023 17:02:01 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=bonfacemunyoki.com header.s=fm3 header.b=j9w6hxlp; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=lHtsiz38; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1696604523; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=HR3y/TzKUvv06y8o9rqIhftZbfGrYeB7EuuQVhsPxEs=; b=YpTQ8LtZR4AHVX8i/0gYmef7xn4tqH8SzX8WCIIagHx2zvyUeubOcNK3A3zRkI6/0BjPED JrbhiRZznVYJ4QuMov2H7BOagL6bitxPJCAUVyzPHOmlVgyMoBGvBmu/rr6t7P/6zlK+FO bc+eonBmbZ/h/jhyFqT9nFIE8RON73VYEvBUhbPzaKcMPvifG7GNhZlKxHFjaXD480kMiv iasObubksX1NJktg0PiJN+GqITMa/5iYkc5pAYq/1W//ArOtcSbnZRJYE3xXZ/4iog+F0N OovzzYTnhmJL2+KajmIFHcryUlRc6BVRu9vDBKDEa0ccMviT7N3YFxIIO2kadg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1696604523; a=rsa-sha256; cv=none; b=AUbSNoZH0HhZv8rC5FbemBqnn9qcg/8BOP5pRtLnxK5CV6kRvuXXwPvPxhtinbK6bJSBwT R96CSUPL7GkRnGqglisMQDB8gPLcZhGe43PV+QW67PrNe8MsJRZKzqEpxM1Joa4uGHgEFS qyc/FoKsngurLkkCQRE+OwVqFxhPvjNStY5fexh0RaC74p097zh+g0EzvQP+fkCBNNy6TC Dmr/ZfQPmpFnTmbI6kRncphpkWCk/0V4foEJrpKgVREtWIPgeoq3sz9y/BLpD83BuUZlNl MtLnnIFd+mnTULV3Lv4MWCF4m5QQ2T1XYQvG7rbH0lWm1AmNBac9Hm1JUT2XaQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=bonfacemunyoki.com header.s=fm3 header.b=j9w6hxlp; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=lHtsiz38; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qomKW-0002kh-Ss; Fri, 06 Oct 2023 11:01:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qomKT-0002UN-Ez for guix-devel@gnu.org; Fri, 06 Oct 2023 11:01:25 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qomK9-0002MB-PA for guix-devel@gnu.org; Fri, 06 Oct 2023 11:01:23 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id F2C463200B76; Fri, 6 Oct 2023 11:01:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Fri, 06 Oct 2023 11:01:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= bonfacemunyoki.com; h=cc:cc:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1696604463; x=1696690863; bh=HR3y/TzKUvv06y8o9rqIhftZbfGrYeB7Euu QVhsPxEs=; b=j9w6hxlpMq4T8ddm1PSHNLfrZicwzEbbbX+tGUXyixoP2Gw9j+V tw+ILw6082n02MYKzvhZjJdx2HbkbBrptZIZ3CO2rY9xKSxG8vwX/l7mwrjwoQOy TM7Uc3QyYcNAoyd0Eu6QslX9qz2wVAhv9TjC34mhMJGOwB2O8g4TjIgF+PGdAAA8 z9A8UZ/D+0uTWSz+M97aiigKEZAQZSNLdOSu4kUzaDKxIITg5fxPRm/5ohosvBkb AWVL59G4ErvGClv9+KeUkSlpzZLhOi+v6sCTFIFSWWgSnWTFxovohMhf7dzMrWRx ypVa9Dhhp+JiiA3noBSWjt5e0f7fKEoolsQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1696604463; x=1696690863; bh=HR3y/TzKUvv06 y8o9rqIhftZbfGrYeB7EuuQVhsPxEs=; b=lHtsiz380fvB6Ztj2VWSEMDuvqWNB m5ix6NqaBKN3d6/NypJ7wh0HrxbstSX2Va2C8Hr/49JcaPnQe7lN8JgJ+52f9m6A BFptPK9MzDTHqdExvYIHiBLV/vBZ7fXN5HxpTj62uaF7PBdJ24/6En69B5sPcQoz KTyxM5hKpPGfQ1V2y0VRhOozL/J8xfaGu+pblpKFSepZaE6CzDpfiZyiaUXtEQOb p5ft9fbAhjoR5nApZpbac+hZrSmkHckVjiSJpoZ8SVAPGUxhk2N0cfm2LHEgflIa EbT5WK0GCgr6HOt3vIC5Pt2Qbcaqkn6e1UbUi19owxyuxHDg45VSqkB1Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrgeeigdekudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufgjfhffkfggtgesghdtreertddttdenucfhrhhomhepofhunhihohhk ihcumfhilhihuhhnghhiuceomhgvsegsohhnfhgrtggvmhhunhihohhkihdrtghomheqne cuggftrfgrthhtvghrnheptdduteefgfeiueekleekhfeufedtheetjeeutddujeejhfet vdelgfdtueejfeelnecuffhomhgrihhnpehophgvnhhpghhprdhorhhgnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgvsegsohhnfhgrtggv mhhunhihohhkihdrtghomh X-ME-Proxy: Feedback-ID: ib8a1471e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 6 Oct 2023 11:01:02 -0400 (EDT) From: Munyoki Kilyungi To: Maxim Cournoyer Cc: jgart , guix-devel@gnu.org Subject: Re: IDEA: missing-tests-pypi-error? condition In-Reply-To: <87o7hbkind.fsf@gmail.com> References: <41cf39960ed499205b21e677c872a29f@dismail.de> <87v8bkxgl3.fsf@saitama.mail-host-address-is-not-set> <87o7hbkind.fsf@gmail.com> Date: Fri, 06 Oct 2023 18:00:58 +0300 Message-ID: <87jzrzyevp.fsf@saitama.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Received-SPF: pass client-ip=64.147.123.24; envelope-from=me@bonfacemunyoki.com; helo=wout1-smtp.messagingengine.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -6.86 X-Spam-Score: -6.86 X-Migadu-Queue-Id: 1508175E64 X-TUID: nidqRTsuXLfV --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Maxim! Maxim Cournoyer aliandika: > Hi, > > Munyoki Kilyungi writes: > >> "jgart" aliandika: >> >>> Hi Guixers, >>> >>> I was recently reviewing a patch by a contributor and was discussing th= e notion of preferring upstream to PyPI when tests are missing on PyPI. >>> >> What's the policy on this. Shouldn't we prefer >> upstream over PyPI? Sometimes, PyPI versions lag >> behind upstream versions. > > There's no written policy about it at this time, but I think it's common > knowledge in Guix that we try hard to: > > 1. Unbundle dependencies (that one is documented) > 2. Run test suites (that one isn't) > > We could hint at this globally in the contributing section, and perhaps > expound with more specific details in the Python Modules contributing > section, mentioning that when the PyPI source archive lacks tests, > fetching from the git repository should be preferred. > > Another thing we could do is default to fetch from git for the Python > importer. > Thanks for this info. I'm dedicating an hour of my day from work to try to contrib to the eco-system with Jgarte's help. What's, if I may naively ask, the process for documenting this knowledge? I can take a stub at trying to document this and asking for reviews. >>> WDYT if we also signalled a special condition when there are missing te= sts in PyPI? >>> >> I posit that this should be the responsibility of >> the contributor. Adding extra glue can add >> unnecessary complexity. > > I think an error would help catching this situation; the > gnu-build-system would fail running 'make check' when there is no check > target for example, but in the Python world, running 'python setup.py > test' often succeeds even 0 tests were run, which is easy to overlook. > I'm not sure how easy it'd be to check for missing tests though. > TIL'ed. =2D-=20 (Life is like a pencil that will surely run out, but will leave the beautiful writing of life.) (D4F09EB110177E03C28E2FE1F5BBAE1E0392253F (hkp://keys.openpgp.org)) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJKBAEBCAA0FiEE1PCesRAXfgPCji/h9buuHgOSJT8FAmUgISoWHG1lQGJvbmZh Y2VtdW55b2tpLmNvbQAKCRD1u64eA5IlPwThD/sEbop2LV4pRoXR9bXSecq06rfL +ziys5k66k1w1yme82iUgW/sCCphuPuhcniZVjXmTH1MLHOsoTY1nnCS5PJOvUyX 4aRAXFgvbt9iD60dpRBfpEltLmWyXHTDyiiYw5ga8jCl4tOV98sFj5rfNeCjqa1V O8u1lzMzlQWuoBJXRpe25lGZBur/1gipmHv6vQLLQ4LsoFvy1jLGGPoE0kJrPqoG BDE4WZfFMrDgdMIfGQZeGKFJ2YCyMBfO+yL9mZUlMoZku+PQYKreB1llx7j4I6jx KntETbL5wcpxh2YncviiadX8zpooj4DuEDUndl6Cd8fPxrxxxLPASaRyD0xXhjNc IwMw0harPkG7fX3EPCQDDgjhvXkq+dIjsemmvWG+wtT31RL8v5cFY1HYYEBw2j8b 7mApMr4AVF2q8P6JiYqU1H6VNApZx9nd6n7Nbi7tZAr+qIDHfm978gOYK01EOpmL pRVccs7qRy3XtAtwlTCYukTBx9u3Xe2n13w7kAx9HH1g/ECRQW1ZLD7gebsvCFmS 7irvULMS007Bar6pqD2Yu/PUgEyeDVIq1sOmQSZY6d5i9Cct4kTIoyUWeCL/X0wz ZyYO4DbDwk4olsANZU5tNCeNAKksG+DSMDaZZrYGpAuZXWLEl/O8sFrERxaTA9gQ cnXBXdbv7zZY/EpkVQ== =GSKs -----END PGP SIGNATURE----- --=-=-=--