From: Christopher Baines <mail@cbaines.net>
To: Vivien Kraus <vivien@planete-kraus.eu>
Cc: guix-devel@gnu.org
Subject: Re: QA is back, who wants to review patches?
Date: Sat, 10 Feb 2024 09:42:17 +0000 [thread overview]
Message-ID: <87jzncd599.fsf@cbaines.net> (raw)
In-Reply-To: <0e28946e0983d9d83cb264ab11d9d34240a03d53.camel@planete-kraus.eu>
[-- Attachment #1: Type: text/plain, Size: 525 bytes --]
Vivien Kraus <vivien@planete-kraus.eu> writes:
> Dear QA wizards,
>
> Le vendredi 09 février 2024 à 10:44 +0000, Christopher Baines a écrit :
>> You just need to not be involved (so you can't review your
>> own patches)
>
> I interpret this as it’s OK to review patches if you asked for a change
> in the thread, am I correct? Or is this too much involvement?
That sounds fine. It's more you shouldn't review your own patches or
someone elses patches where you were significantly involved in the work.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
next prev parent reply other threads:[~2024-02-10 9:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 10:44 QA is back, who wants to review patches? Christopher Baines
2024-02-09 12:43 ` Clément Lassieur
2024-02-09 13:31 ` Tanguy LE CARROUR
2024-02-09 13:44 ` Christopher Baines
2024-02-09 13:53 ` Tanguy LE CARROUR
2024-02-09 14:30 ` Andreas Enge
2024-02-09 15:08 ` Tanguy LE CARROUR
2024-02-11 8:01 ` Andreas Enge
2024-02-09 15:04 ` Andreas Enge
2024-02-09 15:57 ` Christopher Baines
2024-02-10 8:28 ` Vivien Kraus
2024-02-10 9:42 ` Christopher Baines [this message]
2024-02-10 8:40 ` Vivien Kraus
2024-02-10 9:43 ` Christopher Baines
2024-02-12 0:21 ` Ian Eure
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzncd599.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=guix-devel@gnu.org \
--cc=vivien@planete-kraus.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).