unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Mark H Weaver <mhw@netris.org>
To: Eric Bavier <ericbavier@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: Patches for midnight commander
Date: Tue, 25 Mar 2014 21:47:31 -0400	[thread overview]
Message-ID: <87ior1k9xo.fsf@yeeloong.lan> (raw)
In-Reply-To: <87wqfihtoi.fsf@gmail.com> (Eric Bavier's message of "Tue, 25 Mar 2014 16:09:17 -0500")

Eric Bavier <ericbavier@gmail.com> writes:

> +       #:phases
> +       (alist-replace
> +        'configure
> +        (lambda* (#:key #:allow-other-keys #:rest args)
> +          (let ((configure (assoc-ref %standard-phases 'configure)))
> +            (substitute* "configure"
> +              (("/usr/bin/file") (which "file")))
> +            (apply configure args)))
> +        %standard-phases)))

The complex 'lambda*' above could be replaced by "lambda args".
However:

Instead of replacing the 'configure' phase with a new one that ends by
calling the standard 'configure' phase, why not just add a new phase
before 'configure'?  Something like this (untested):

--8<---------------cut here---------------start------------->8---
       #:phases (alist-cons-before
                 'configure 'patch-configure
                 (lambda _
                   (substitute* "configure"
                     (("/usr/bin/file") (which "file"))))
                 %standard-phases)
--8<---------------cut here---------------end--------------->8---

     Mark

  parent reply	other threads:[~2014-03-26  1:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-25 21:09 Patches for midnight commander Eric Bavier
2014-03-25 22:41 ` Ludovic Courtès
2014-03-26  1:51   ` Mark H Weaver
2014-03-26 13:46     ` Ludovic Courtès
2014-03-26  1:47 ` Mark H Weaver [this message]
2014-03-26 14:20   ` Eric Bavier
2014-03-26 14:53     ` Andreas Enge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ior1k9xo.fsf@yeeloong.lan \
    --to=mhw@netris.org \
    --cc=ericbavier@gmail.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).