From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 3/5] guix lint: check whether descriptions and synopses
	start with an upper-case letter.
Date: Sun, 28 Sep 2014 18:09:20 +0200
Message-ID: <87iok7afrj.fsf@gnu.org>
References: <1411854568-11187-1-git-send-email-tipecaml@gmail.com>
	<1411854568-11187-4-git-send-email-tipecaml@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36308)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XYH2U-00009K-Bw
	for guix-devel@gnu.org; Sun, 28 Sep 2014 12:09:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XYH2L-0006Qo-9U
	for guix-devel@gnu.org; Sun, 28 Sep 2014 12:09:34 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:40199)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1XYH2L-0006Q4-3C
	for guix-devel@gnu.org; Sun, 28 Sep 2014 12:09:25 -0400
In-Reply-To: <1411854568-11187-4-git-send-email-tipecaml@gmail.com> (Cyril
	Roelandt's message of "Sat, 27 Sep 2014 23:49:26 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org

Cyril Roelandt <tipecaml@gmail.com> skribis:

> * guix/scripts/lint.scm (check-description-style, check-synopsis-start-up=
per-case): New methods
> * tests/lint.scm: Test them.

Please specify the test names, and wrap lines.

> +(define (start-with-upper-case s)
> +  (char-set-contains? char-set:upper-case (string-ref s 0)))

Rather =E2=80=98starts-with-capital-letter?=E2=80=99 (with the question mar=
k, as is
conventional, and more grammatically correct I think.)

Also it may be worth checking that S has one or more character, so
gracefully handle empty synopses.

OK to push with these changes, thanks!

Ludo=E2=80=99.