From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 3/5] guix lint: check whether descriptions and synopses start with an upper-case letter. Date: Mon, 06 Oct 2014 17:58:52 +0200 Message-ID: <87iojxxk8z.fsf@gnu.org> References: <1411854568-11187-1-git-send-email-tipecaml@gmail.com> <1411854568-11187-4-git-send-email-tipecaml@gmail.com> <87iok7afrj.fsf@gnu.org> <5431E21C.5040504@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42649) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XbAga-0001Od-1v for guix-devel@gnu.org; Mon, 06 Oct 2014 11:59:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XbAgR-00075W-1c for guix-devel@gnu.org; Mon, 06 Oct 2014 11:58:56 -0400 Received: from hera.aquilenet.fr ([2a01:474::1]:48956) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XbAgQ-00075N-Qu for guix-devel@gnu.org; Mon, 06 Oct 2014 11:58:46 -0400 In-Reply-To: <5431E21C.5040504@gmail.com> (Cyril Roelandt's message of "Mon, 06 Oct 2014 02:28:12 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Cyril Roelandt Cc: guix-devel@gnu.org Cyril Roelandt skribis: > On 09/28/2014 06:09 PM, Ludovic Court=C3=A8s wrote: >> Cyril Roelandt skribis: >>=20 >>> * guix/scripts/lint.scm (check-description-style, check-synopsis-start-= upper-case): New methods >>> * tests/lint.scm: Test them. >>=20 >> Please specify the test names, and wrap lines. >>=20 >>> +(define (start-with-upper-case s) >>> + (char-set-contains? char-set:upper-case (string-ref s 0))) >>=20 >> Rather =E2=80=98starts-with-capital-letter?=E2=80=99 (with the question = mark, as is >> conventional, and more grammatically correct I think.) >>=20 >> Also it may be worth checking that S has one or more character, so >> gracefully handle empty synopses. >>=20 > Not sure whether the "starts-with-capital-letter" function would make a > lot of sense with an empty string, that why I test this in the caller. > WDYT ? Oh right, I hadn=E2=80=99t noticed the test in the caller, sorry about that. Ludo=E2=80=99.