From: ludo@gnu.org (Ludovic Courtès)
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 3/5] guix lint: check whether descriptions and synopses start with an upper-case letter.
Date: Mon, 06 Oct 2014 17:58:52 +0200 [thread overview]
Message-ID: <87iojxxk8z.fsf@gnu.org> (raw)
In-Reply-To: <5431E21C.5040504@gmail.com> (Cyril Roelandt's message of "Mon, 06 Oct 2014 02:28:12 +0200")
Cyril Roelandt <tipecaml@gmail.com> skribis:
> On 09/28/2014 06:09 PM, Ludovic Courtès wrote:
>> Cyril Roelandt <tipecaml@gmail.com> skribis:
>>
>>> * guix/scripts/lint.scm (check-description-style, check-synopsis-start-upper-case): New methods
>>> * tests/lint.scm: Test them.
>>
>> Please specify the test names, and wrap lines.
>>
>>> +(define (start-with-upper-case s)
>>> + (char-set-contains? char-set:upper-case (string-ref s 0)))
>>
>> Rather ‘starts-with-capital-letter?’ (with the question mark, as is
>> conventional, and more grammatically correct I think.)
>>
>> Also it may be worth checking that S has one or more character, so
>> gracefully handle empty synopses.
>>
> Not sure whether the "starts-with-capital-letter" function would make a
> lot of sense with an empty string, that why I test this in the caller.
> WDYT ?
Oh right, I hadn’t noticed the test in the caller, sorry about that.
Ludo’.
next prev parent reply other threads:[~2014-10-06 15:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-27 21:49 [PATCH 0/5] Add, fix and improve checkers in guix lint Cyril Roelandt
2014-09-27 21:49 ` [PATCH 1/5] guix lint: make sure check-patches retrieves patch names Cyril Roelandt
2014-09-28 10:08 ` Ludovic Courtès
2014-10-06 0:26 ` [PATCHv2 " Cyril Roelandt
2014-10-06 15:57 ` Ludovic Courtès
2014-09-27 21:49 ` [PATCH 2/5] guix lint: Make sure synopses are not too long Cyril Roelandt
2014-09-28 10:09 ` Ludovic Courtès
2014-09-27 21:49 ` [PATCH 3/5] guix lint: check whether descriptions and synopses start with an upper-case letter Cyril Roelandt
2014-09-28 16:09 ` Ludovic Courtès
2014-10-06 0:27 ` [PATCHv2 " Cyril Roelandt
2014-10-06 16:00 ` Ludovic Courtès
2014-10-06 0:28 ` [PATCH " Cyril Roelandt
2014-10-06 15:58 ` Ludovic Courtès [this message]
2014-09-27 21:49 ` [PATCH 4/5] guix lint: Make sure a synopsis cannot start with a lower-case article Cyril Roelandt
2014-09-28 16:11 ` Ludovic Courtès
2014-10-06 0:28 ` Cyril Roelandt
2014-09-27 21:49 ` [PATCH 5/5] guix lint: make sure synopses do not start with the package name Cyril Roelandt
2014-09-28 16:11 ` Ludovic Courtès
2014-09-28 16:49 ` [PATCH 0/5] Add, fix and improve checkers in guix lint Andreas Enge
2014-10-04 14:25 ` Cyril Roelandt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iojxxk8z.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=tipecaml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).