unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eric Bavier <ericbavier@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] guix: refresh: Use bags.
Date: Fri, 10 Oct 2014 23:49:24 -0500	[thread overview]
Message-ID: <87iojrus6j.fsf@gmail.com> (raw)
In-Reply-To: <87zjd3ac79.fsf@gnu.org>


Ludovic Courtès writes:

> I’m surprised gzip, diffutils, patch, and tar are very low, even though
> they’re part of %final-inputs.  Conversely, bzip2 (also part of
> %final-inputs) is higher.
>
> Any idea?

I think this is because fold-packages only looks at packages that are
exported by a module.  Many of the packages in %final-inputs are not
exported.

While the vhash returned by (@ (gnu packages) package-dependencies)
includes dependency lists for packages in %final-inputs, guix refresh
uses find-package-by-name to get the packages that are used as lookup
keys, and find-package-by-name only returns packages that can be found
with fold-packages.  Uff da.

One, possibly ugly to implement, solution would be to merge hash entries
of packages that have the same package-full-name, since the output is
produced in that format already.

-- 
Eric Bavier

Please avoid sending me Word or PowerPoint attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html

  parent reply	other threads:[~2014-10-11  4:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-10 19:32 [PATCH] guix: refresh: Use bags Eric Bavier
2014-10-10 19:42 ` David Thompson
2014-10-10 20:42 ` Ludovic Courtès
2014-10-11  1:46   ` Eric Bavier
2014-10-11  4:49   ` Eric Bavier [this message]
2014-10-11 22:09     ` Ludovic Courtès
2014-10-13 19:18       ` Eric Bavier
2014-10-13 21:31         ` Ludovic Courtès
2014-10-14 17:06           ` Eric Bavier
2014-10-14 19:09             ` Ludovic Courtès
2014-10-20 16:58           ` Eric Bavier
2014-10-25 21:36             ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87iojrus6j.fsf@gmail.com \
    --to=ericbavier@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).